Received-SPF: pass (google.com: domain of linux-kernel+bounces-105924-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <ce8b2b49-b194-42f7-8f83-fcbf7b460970@amperemail.onmicrosoft.com>
Date: Mon, 18 Mar 2024 16:53:17 +0700
User-Agent: Mozilla Thunderbird
From: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
Subject: Re: [PATCH 3/3] dt-bindings: hwmon: max31790: Add
 pwmout-pin-as-tach-input property
To: Rob Herring <robh@kernel.org>, Chanh Nguyen <chanh@os.amperecomputing.com>
Cc: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Justin Ledford
 <justinledford@google.com>, devicetree@vger.kernel.org,
 linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
 OpenBMC Maillist <openbmc@lists.ozlabs.org>,
 Open Source Submission <patches@amperecomputing.com>,
 Phong Vo <phong@os.amperecomputing.com>,
 Thang Nguyen <thang@os.amperecomputing.com>,
 Quan Nguyen <quan@os.amperecomputing.com>
References: <20240311111347.23067-1-chanh@os.amperecomputing.com>
 <20240311111347.23067-4-chanh@os.amperecomputing.com>
 <20240311173438.GA1451467-robh@kernel.org>
Content-Language: en-US
In-Reply-To: <20240311173438.GA1451467-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bHh6QVpteHg4cm1SQmhSOElValM5WVZIcHQzTitPY2c4WWFtS01KblRCRDM0?=
 =?utf-8?B?ZmNzT2UyZVVDMU9uc0hiKzFCKy9zSjBIWlBITS9pZnlCdXpJRS9wQkEyUFlG?=
 =?utf-8?B?OHg1TE9PVE5pWXhEdmhBZzRMdW12QnhuK05xMVZDcURXWEp6MDVuRlpsYWRk?=
 =?utf-8?B?d09tMCtadklTWlFPNWtGZGJQTzhWZXpYU05rTktRcWZ2c3dsZmM2dHFyUEdi?=
 =?utf-8?B?M2hsd0JTQ0ZadVRXNzl4a0lNVVQ5M1pQY3VOcFdYY1ZvZ0UybDE1QS9oazBH?=
 =?utf-8?B?ZDBCSVMxOHVhVGZaQlFkNkR2VzFPT21VM2t0QjBSVXRUQjhaWUVud3pUNFhm?=
 =?utf-8?B?WG9QQXhRMjFmN0w3L3k3eWxyWTJVK0k0ejR0Z3ZISnpNVDVqN2UzY2V0NjVr?=
 =?utf-8?B?eURJVm9tQzlDaFJIVUNYNXpPNytRMFg5QmJUUjZVVUl4MzVhNjh3NmhITnNP?=
 =?utf-8?B?RWlhWE1rRjBZam9JekpJaUlOK3pVSlgrRHFwak9BNHVhZzFaM1hmVzBMaUNz?=
 =?utf-8?B?MFl3SmFHOFp2ZTNCY1ZDN1lNdy9iS25jWjdCZ2xwRitQVTNEakZEOFY0VFE1?=
 =?utf-8?B?djFrMTRGdDBjUE1aT3FpL256S25uYVR5WVJIcFNrNmxKWWxYNUNxNWdoeGxT?=
 =?utf-8?B?bkw3Y1NzK0Y3d2d1dkNqa24wbEZsM0hkTm8xejlnK3hkWDZ1emlRbW1XQjg5?=
 =?utf-8?B?ak5OZUZVbnlqVlkvL05Gc0QyaCtIdE84OEovSFJBNkFWZ04xM0M1UFQzWlU4?=
 =?utf-8?B?V1lBN3BWSHFSYUhHbVI2U25qTGpqR0NiY2daOENETFAxdVFBbDViV2FicEky?=
 =?utf-8?B?MVB1cTczRkVPYjdBc2NOWVVLVjVIbkJ1WGUrYWI4Rit5MHdoQVQrSW1IdzFJ?=
 =?utf-8?B?dGhZNU84dzRFYTlsMkZ6MkdCMzFSQUVQOXpRWXBtY1dFeVRGUUZoQ3NrWGZE?=
 =?utf-8?B?UXhGME1PWkpxcjd0UHZNRlFhWTlkdmlMUjRhU28zVzhOWTNwSGM1aGs3SSs4?=
 =?utf-8?B?MjBWMW9qYVg5RTFBeTVNejhVVmc0bGZ0M3Y1UjgvQW84elpXSGtDLzJ4ZTRM?=
 =?utf-8?B?aVdxRmhDU25JWndEZTZwVHVzWnFCaUVhUS90MmlEaHZnZUNKaFErc0Q3dG5E?=
 =?utf-8?B?Nzl5VzFZQ0dCT2NOVmlZYmN4NXN4NjRWVmxac3Z1M3hkb3J5TU50SG9tZE82?=
 =?utf-8?B?cEJKVnJOc2x1NnYrNWRTVEpHMWNlcHkxSW1QWEQwMmtGODhEMzRNdEFEQ3lR?=
 =?utf-8?B?QmttNFhnc3NITnQzZ3NMVGJzdUZSQWh6S3JsdjBlRmxXYUdlQ25oVWp0RzhE?=
 =?utf-8?B?K1JkamNZL1JiNzJtLzdTeUlXVWl0anBuWnd0UE1lKzB5U3FrdjRDMG84MUhY?=
 =?utf-8?B?R1dYZUxIS0Z5a21GdDRGM3ZiZWhPZmRxOEU1Z05KaW9pYjRMT1pZZ2ZXaUpR?=
 =?utf-8?B?OFEra2xJRTNWUlVyQlM2VDNLT1ZZRWxCZVVZd3ZkaGdwem5KSDN2ZUhFODFE?=
 =?utf-8?B?cmttQjNadnhDSkRYdnNjZGxNdC9RSVBhZTdncmprWEpNRzFEYUwrSWlnS0VS?=
 =?utf-8?B?NEZYU2VPVkFjamtDSGxzakVLdldLTUp6ZkI0VUQwc0cwTGNFeit1ZUtNZGwz?=
 =?utf-8?B?TFpSQ2Q4cnJ0VnBzeUNraklta3NWcGxCLzdCZFRTdElmanp0MWVDV0dyNmFV?=
 =?utf-8?B?UWgwK0VxNW5QUWEvNlVlenZmc0hRZUhyY01ORGlEa0pVWHVZemR4SDVvRnNE?=
 =?utf-8?B?TS8zTG4xU3VqblpFdjdBM0xXY2JoRk1KUU1NOVBRZVd5NTBORXpLZk5ERlVz?=
 =?utf-8?B?ODRLM0gyMlBXcjRoRkdra2NlTDMxb2VhZ1Z6aFZmR0p5NmJMMlhoNWsvaitm?=
 =?utf-8?B?VDRpMzFYRTE4c0ZqSFVFVlhSdFVWUVRwTVdIQzByeGw4ZndSWG1KOTU2OWQ5?=
 =?utf-8?B?cGdoWkwwRlk3R0tuVEV5WGFicXEwc0FyMmRLNGVWY3FsWUxlK0R1Mmt0bzNv?=
 =?utf-8?B?QUpMQTRlcmtHOEVtRUk3b1VXZGZHV2xxK2xiWXNPME02S0wwN002NTFKVmdo?=
 =?utf-8?B?em5vMnJXWGV0d1BMQmZRYnM3eEo3T0Njejl3bS95aHI2ZUNBN1JZN005WTJ5?=
 =?utf-8?B?bWVNdzltd0R5cWprUWU4eGNsR21tUnpqeHQ3NEp4NHhmUGZxTXMzQm96VW1N?=
 =?utf-8?Q?hQMc8AIIM4U8l+UOgfPQRjI=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d41d6db9-370a-4cfc-bf23-08dc47313fa1
X-MS-Exchange-CrossTenant-AuthSource: DM6PR01MB5947.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 09:53:22.9691
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: K5IB0STQqwkP5PmG+PpN41urW14l4zlI/49DFS+NTql2/PWA1FAwX8AsGKtpvofo4TOsKRxFfxUBfXd82HxR39evHaNDFvOOcvomkVB3jHWyj4HoGozS6rY4FmScbKC4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR01MB6473


On 12/03/2024 00:34, Rob Herring wrote:
> On Mon, Mar 11, 2024 at 06:13:47PM +0700, Chanh Nguyen wrote:
>> Add pwmout-pin-as-tach-input property.
>>
>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>> ---
>>   Documentation/devicetree/bindings/hwmon/max31790.yaml | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/hwmon/max31790.yaml b/Documentation/devicetree/bindings/hwmon/max31790.yaml
>> index 5a93e6bdebda..447cac17053a 100644
>> --- a/Documentation/devicetree/bindings/hwmon/max31790.yaml
>> +++ b/Documentation/devicetree/bindings/hwmon/max31790.yaml
>> @@ -25,6 +25,16 @@ properties:
>>     reg:
>>       maxItems: 1
>>   
>> +  pwmout-pin-as-tach-input:
>> +    description: |
>> +      An array of six integers responds to six PWM channels for
>> +      configuring the pwm to tach mode.
>> +      When set to 0, the associated PWMOUT produces a PWM waveform for
>> +      control of fan speed. When set to 1, PWMOUT becomes a TACH input
>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>> +    maxItems: 6
>> +    minItems: 6
> 
> Seems incomplete. For example, fan tachs have different number of
> pulses per revolution, don't you need to know that too?
> 
> There's a common fan binding now (or pending). You should use that and
> this property won't be needed.
> 
> Rob

Thank Rob,

I checked in the 
Documentation/devicetree/bindings/hwmon/fan-common.yaml. I found the 
tach-ch property, but it seems define the tach channel used for fan.

   tach-ch:
     description:
       The tach channel used for the fan.
     $ref: /schemas/types.yaml#/definitions/uint8-array

I would like to define a new vendor property to configure the PWM-OUT 
pin to become a TACH-IN pin. So I introduce the 
"maxim,pwmout-pin-as-tach-input" property. Please help me share your 
comments!