Received-SPF: pass (google.com: domain of linux-kernel+bounces-105926-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e4a48c97-dd95-4ef5-8895-84f6f0e76355@amperemail.onmicrosoft.com>
Date: Mon, 18 Mar 2024 16:54:52 +0700
User-Agent: Mozilla Thunderbird
From: Chanh Nguyen <chanh@amperemail.onmicrosoft.com>
Subject: Re: [PATCH 3/3] dt-bindings: hwmon: max31790: Add
 pwmout-pin-as-tach-input property
To: Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
 Chanh Nguyen <chanh@os.amperecomputing.com>
Cc: Jean Delvare <jdelvare@suse.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Justin Ledford
 <justinledford@google.com>, devicetree@vger.kernel.org,
 linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
 OpenBMC Maillist <openbmc@lists.ozlabs.org>,
 Open Source Submission <patches@amperecomputing.com>,
 Phong Vo <phong@os.amperecomputing.com>,
 Thang Nguyen <thang@os.amperecomputing.com>,
 Quan Nguyen <quan@os.amperecomputing.com>
References: <20240311111347.23067-1-chanh@os.amperecomputing.com>
 <20240311111347.23067-4-chanh@os.amperecomputing.com>
 <20240311173438.GA1451467-robh@kernel.org>
 <43f62612-bd16-4d66-b1ee-26932f6ab2f7@roeck-us.net>
Content-Language: en-US
In-Reply-To: <43f62612-bd16-4d66-b1ee-26932f6ab2f7@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZmxSa0RYZkpVVkRDczUvaFByd3BwaU96blduaS9iMUJMRC91MEVhTUZNWERJ?=
 =?utf-8?B?cnFDaStkeXpsQTJER25VbTdGNDEvMVllVUhGOSs4dStQNnJFM0wxZTI1T3ZJ?=
 =?utf-8?B?djYvU285NmU0Y1RjWFVNZFVvQ3NkMlNxdlF4T3hHZWhDRmZuRjdDYWFmeHFm?=
 =?utf-8?B?eXFGbExPdno0ZDVGcmJBK3p2K0Z6b0JDZXdiNVZZVDJHaXVaZDVBUlZmTnY0?=
 =?utf-8?B?QnZNSm1tU1FMTzN3RC9iYklnSmlYSUN4ZTBqOW9ERGlDSWRwQ0tkbVlob1Ja?=
 =?utf-8?B?R1dtaEpIbVI4Vy8vU3BUUE45TldKOHlPV0djYzZpRXJrMVh3YkkvVDZtd1Uz?=
 =?utf-8?B?ZU51S2VyeittZ0tZcE14K1FhcGMzR1ZFM2lRTXVlSUcvU0srTFQxMGhvQlpY?=
 =?utf-8?B?MER4cSs5cWhBUGE2RWgwRzhvQjhOblo5N3hrYlJGYk1JcFdZTnJUN29iVGh6?=
 =?utf-8?B?d2NoeUdsSUtuczRKZXVVZ3lLUEljNnd5R3NINlBaaEFkNXlxeVkvaDRYWDQ1?=
 =?utf-8?B?WEllSWpaYUI0NGFKQVBLQTZkdk1WV0JhYXRjN21OWHR4eklZc0dlRE8va2lG?=
 =?utf-8?B?YVRWdnR2c2t0aTdodmE3SlZUZy82dHN0T2FGL1hFNnh4WGxNOUtQZy9OVUxo?=
 =?utf-8?B?bnpPOHR3VkZRMzBmcTJPcktydDRqOXcvM0RiTEFyY0prQ0FwWVJ5eVZmSDho?=
 =?utf-8?B?aDF1L0Ftc0cxaHJFa3QvUnp4aGgrTGF6cStCeldYU2RWQkg2enVnaEhXY3h4?=
 =?utf-8?B?Um42blRZbFp3SkVBUXdOSW9ER2dZNzBVYnZGeis5QUh2Tk1xUEo5YTc5UnQv?=
 =?utf-8?B?TjRSY2RlNjZVZnJBelF5T0JHa3FVaHpnR0dNVFo0WmpyR041Wm5DZzZLdUlx?=
 =?utf-8?B?REl4MHlidTZxY3hWOTlZSVZkRVJNNTZzU2VXamFwWVB0Q0hRNEUvNEZHQ1FF?=
 =?utf-8?B?QkhJSmxxVDM0bG4vNm9rWEFSUTc1cXhobFdBdGl1YXd0NVN3N0pFU1h1aTFh?=
 =?utf-8?B?Nk9ZM1pNUjM0REYvN2R4aHJhT25Wd29tZ05uN3BLTmVXbTFHRUpHM2NLc1ZO?=
 =?utf-8?B?V01uSy9Fb0M2b3ROaXBTTHF0SFdtUWV3ZmtBS1pLYkdpckpzTDczT3J0alpZ?=
 =?utf-8?B?ZE9xYngxZ0FKRWtzbXYwNVhpckJ1R0RSakZLeG5vVzBaaWRmL2xMaFo3cXIy?=
 =?utf-8?B?ZWtvMmhHbTJzNC9qczQ4Y0Nsb25NenQ1YnVYMXV0Q3dmMTBLOWNmVUFMTTFF?=
 =?utf-8?B?U1pUZ2FZOUFyWWl3SmxuUnNZREN1b2NQdmVKbGJyQ2cxZ2tMUUw2b2JhVXgr?=
 =?utf-8?B?cUxKRXk4K2xnbG5xRXlpVS9ZN2txR2RBL1hUL1hRMmdxVFdKaDBBVkhmb1JP?=
 =?utf-8?B?VEZVamFNSCt6dEIwUnB1NVNPQ1dKamMrQmZKaEtyaWhwY3JYL1lmcVdVdWZy?=
 =?utf-8?B?bXJPeXg5ZUVBZzJzWFZXV2E1d3llVFJQTC9QNmNMMjB6K0xGL1VXY2pZYUdT?=
 =?utf-8?B?amtiQ0dmUkhMMXM2anczakJDb0czbW1iTGVDMEErNGtOWkpORGt2WXlqYzAy?=
 =?utf-8?B?Rm1GMWNKNW01TksyNVVQMkNHck8zYUFkN0Z5ZDNzSCtHamlTWFBxOEozRkkw?=
 =?utf-8?B?ZURtUktSVVU3b2JEUVZuMnpBZHN4T3FuclVpWlBKUElRUTdXbGdWbTRnL3Zz?=
 =?utf-8?B?RGNoaU4vSEk4V3VQNms0Tk4xOGM3c2gwWjFFRTlzeDZEcXpmZ3pWV0ZJTU00?=
 =?utf-8?B?eDQvVEZ3SlU4M1pqbkRZNC8zanJqM3AyS3VmM2t4Z2JiTXBGVVJrT3JVWGlj?=
 =?utf-8?B?VHdDaGdsN3dDWnF6MkI1NGV3ZHpETEU3SHhIcCt6UjZteHBHRy9OblpQZ2E1?=
 =?utf-8?B?ejNBeTMxNmxYRFBrTjVNbm9VYThEeGdrUGJnQ29UeTRDOG91RUh2SSs1Z0V5?=
 =?utf-8?B?VEFtTzNrR0RvTkhxODJZRURWYWxHOVZIZTcwMmVCdkQ5cWVCanBaUjVKS2da?=
 =?utf-8?B?OW5MK204Z3pYVTY0enE2SHRRb09YTzFBVHd1bnVCRGFQSndHczJNSVlUdkdj?=
 =?utf-8?B?eU9DZkdRVlNFN2wrNnU3WUpRT1VaMmtGTXRBcjFIZ2xiRXNzbmhYRXhVYW12?=
 =?utf-8?B?WDlTQ0NmY20xVUVzZVIrL1hCUHhhQ2N1ZFR2bnlkNXJPZUhmUlBUazB0QkZJ?=
 =?utf-8?Q?XtlK5gTKlQMKlf6dOzlqMgo=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb936daa-fe48-4e88-1a01-08dc47317897
X-MS-Exchange-CrossTenant-AuthSource: DM6PR01MB5947.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 09:54:58.3222
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i+JV/do8pXV3DfgCKSKXnVuqy+3MMSPJPSHrYTvWgkt9XjHmHBQU6Yd6FR+YcoWCOjGuc3Zx6cPnz4bod2r00WMXrgwLfzYaFgeWY6G3waLE6VwcjMEue7r3xyWZwE/+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR01MB6473


On 12/03/2024 00:52, Guenter Roeck wrote:
> On 3/11/24 10:34, Rob Herring wrote:
>> On Mon, Mar 11, 2024 at 06:13:47PM +0700, Chanh Nguyen wrote:
>>> Add pwmout-pin-as-tach-input property.
>>>
>>> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
>>> ---
>>>   Documentation/devicetree/bindings/hwmon/max31790.yaml | 11 +++++++++++
>>>   1 file changed, 11 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/max31790.yaml 
>>> b/Documentation/devicetree/bindings/hwmon/max31790.yaml
>>> index 5a93e6bdebda..447cac17053a 100644
>>> --- a/Documentation/devicetree/bindings/hwmon/max31790.yaml
>>> +++ b/Documentation/devicetree/bindings/hwmon/max31790.yaml
>>> @@ -25,6 +25,16 @@ properties:
>>>     reg:
>>>       maxItems: 1
>>> +  pwmout-pin-as-tach-input:
>>> +    description: |
>>> +      An array of six integers responds to six PWM channels for
>>> +      configuring the pwm to tach mode.
>>> +      When set to 0, the associated PWMOUT produces a PWM waveform for
>>> +      control of fan speed. When set to 1, PWMOUT becomes a TACH input
>>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>>> +    maxItems: 6
>>> +    minItems: 6
>>
>> Seems incomplete. For example, fan tachs have different number of
>> pulses per revolution, don't you need to know that too?
>>
> 
> Per Documentation/ABI/testing/sysfs-class-hwmon:
> 
> What:           /sys/class/hwmon/hwmonX/fanY_pulses
> Description:
>                  Number of tachometer pulses per fan revolution.
> 
>                  Integer value, typically between 1 and 4.
> 
>                  RW
> 
>                  This value is a characteristic of the fan connected to the
>                  device's input, so it has to be set in accordance with 
> the fan
>                  model.
> 
>                  Should only be created if the chip has a register to 
> configure
>                  the number of pulses. In the absence of such a register 
> (and
>                  thus attribute) the value assumed by all devices is 2 
> pulses
>                  per fan revolution.
> 
> We only expect the property (and attribute) to exist if the controller
> supports it.
> 
> Guenter
> 

Hi Guenter and Rob,
Most general-purpose brushless DC fans produce two tachometer pulses per 
revolution. My fan devices also produce two tachometer pulses per 
revolution.

In max31790.c, I saw the formula that is used to calculate TACH Count 
Registers, which defines the pulses per revolution as 2

	#define RPM_TO_REG(rpm, sr)             ((60 * (sr) * 8192) / ((rpm) * 2))

Do you think we should support the pulses-per-revolution property in 
this case?