Received-SPF: pass (google.com: domain of linux-kernel+bounces-106016-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <6b0c6f19-b054-0ffe-ad45-776b2f7c441f@amd.com>
Date: Mon, 18 Mar 2024 16:14:09 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
From: Ravi Bangoria <ravi.bangoria@amd.com>
Subject: Re: [PATCH] perf/amd/ibs: provide weights for all IBS op samples
To: Stephane Eranian <eranian@google.com>, linux-kernel@vger.kernel.org
Cc: peterz@infradead.org, namhyung@kernel.org, irogers@google.com,
 sandipan.das@amd.com, ananth.narayan@amd.com, Ingo Molnar
 <mingo@redhat.com>, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20240313175453.433166-1-eranian@google.com>
Content-Language: en-US
In-Reply-To: <20240313175453.433166-1-eranian@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?VWhmY2tOQklRWk02VlBIWjY5aUFXTFhkeVdLTHdYSzBBcWlIMWlCNFFCUFIz?=
 =?utf-8?B?R0w0ck5QL0NWdGdXN2JWNGJUdTFiOVlHZXAzcnpwaFN5M09ldHZSTmV6dzRT?=
 =?utf-8?B?OGI3eEhpMUNOc0hUYXprUVJjbk9kL0VVSlVzTUtiV3R3bmZlRGdva1VQT0I0?=
 =?utf-8?B?dXMwTFg5YkhUYzFHS2FSemFjeW54b0dUVTRqVGpoY01JbWIrR3JEUkpGcFpj?=
 =?utf-8?B?YkNmTzR4eFA4UmVkRzdad05yUjZmQ2s2UitOZU9IZlFaYzgvYkRMbkxPRUVC?=
 =?utf-8?B?dmZOWnVGdTQrSWU4b0xuM3V3S1VhTk56b1Z1a3BIN2JFR1U4OHNCeHlzWWJS?=
 =?utf-8?B?TWxNczA2OXhWN3hPNU1UaVllZTl6R01GSFNOb1BEY09JQmlTMmEzekpGc2pv?=
 =?utf-8?B?YnYrTEd1S3RLR1lTUTZ3UHdMUFhUaXJRc0hva1hkVHFjRGsydnlQZ1RtVjdl?=
 =?utf-8?B?TDBhWXUxU1ZyaWg1eVZjQytiL3lsczBkZC9aenE1VjhHZ2U2UDQvenVmYVl1?=
 =?utf-8?B?MG5kdDQvQkwrYTk0ellLNE1KQjI0eXVkWHBRZC9IbDc3QnM5VGR0SXFtMlhh?=
 =?utf-8?B?N1FDT2JBeUxUeGF1bTNBWVpBbWZybEt2Y3VhK3ZuS0licm56YWRUdEFBazlm?=
 =?utf-8?B?WllabkFsSEg2Y3UwOTJyWVdhUDRmaHprVzZTUjFpNTdNNTg3T0duaEM2QUh3?=
 =?utf-8?B?d0tZaUN1Wi9EN1hXK09DK2Q0Nng2Tm1FbmFJTFFrMVo1VmhNeGZoNmpSV3NM?=
 =?utf-8?B?aU41ZXJEa2ZyVGRSR25HdytGYjlkZkJJKzlMNWRQNFlPdE1LTE9Gd2NEVUZI?=
 =?utf-8?B?NjdVVWpPRnRKNHQ1NWhMdi91WEVybG9rRGZHdFc4S1Uzdm1vWlIxV00zRUpY?=
 =?utf-8?B?RFpjT1ZQclJyWUE1T1RwNHJML2FhUTBNNDJUZ2RYNlFsbC8yempIZUF4a1FI?=
 =?utf-8?B?SXduQy9rSzlNOUFpQS9qdmNvTlllakZvbFdsUVZ5RE0wUDM1NFpVSVR5LzdE?=
 =?utf-8?B?TG1KWHRoWmVMdEt5QjQxK1MxbGRMZW9RR2J5cFIvLzBuSW8wRTY5K1duQi8x?=
 =?utf-8?B?eVVZZklRNVNyOFJacmdoMXo0VHk4SENHbkU1TjF1Ym8zZ1R6eVozNjhuSkY4?=
 =?utf-8?B?SW1ER3NHeXVJTTlMcTAzNTNUSlBIT0lIMVNoVU5iQms4MkxpQWxRTmwyWlcx?=
 =?utf-8?B?bnpMdVpjUytSSnYwSWkwZUVZQkZhSDZyN0EwbFUwWUE1cUh1MEFFb1dQckJC?=
 =?utf-8?B?YlVVRlhSZFlISlhwVE41bEdoUTRhOFA4SEhMZHlCSEg5dVpKZkpONHgvcVBL?=
 =?utf-8?B?NlVLa0JLM0JicFF0TUorc3ZVOTArQThrWXViY0dEdTNHV3dqV0xueWltOERZ?=
 =?utf-8?B?UWxhRmlTY1NCOWtBVG53SWl0YSt5Z1hrczdBbFhTT2g3Z05LalJ3Y2tFZEZT?=
 =?utf-8?B?dVNVNkZrUmZRbndBa3hGNWJaNXJxSHp0RS9obmVyWlRuOUxkSWg0Ykk0Q0sw?=
 =?utf-8?B?b0NWNSthM2Y0OVhiWjBFbzdBa1RXbllTSjNRQ0pVTnprd3ZoUXpHbXhOY3Fv?=
 =?utf-8?B?eGpFQTdxNS93R0VaTzhuOTNJYlVic29XM3RzVkxWeENmcDY4NGJsd1dOcWdU?=
 =?utf-8?B?NGxJZHFid3YrdndIK1piNHhiVWx5RmVzOWtDVXN0S1VERnFpSTBiOUkydEs0?=
 =?utf-8?B?YnllSlhuU3RUOGhqWmc0STRreHg0V1pTZnhMQUZOQzNkM2I2bXh0RDdwbjhC?=
 =?utf-8?B?YTVOWUp2eEM2YUZwWE9VUXlWQm1GWVZLY3pVYVlid0FpODUrRlJuRVVuckhv?=
 =?utf-8?B?dXVveGJENkRwRFFxZVB3czlVTW54SzFoR2g4YzU4NERETXBnV1EvVmMybWlG?=
 =?utf-8?B?QVYwMUJqN21UMGVNaC9qYWNkaGxRaFZ2N255Nnc5c3MxN3E2QVZzdXBnbVBz?=
 =?utf-8?B?SWRPVEh0bDJQMEk3Y1pjN0wzckxLeitVQ2lFQ3RUdVhPaHhnY1A1Z1RveVVE?=
 =?utf-8?B?dE1XVm1zWlN3cG4zVnZzVjJFU1IrRkFTcUdoeDJ6ZEduTHhMMWwyeWdTaEph?=
 =?utf-8?B?NzFEZXd6bHJrcExMejgxRTR4eGNsc1NwNTJLMlRqanJqeVFDLzdCc2hTb2V1?=
 =?utf-8?Q?IbwSu4YbpzrqS/V3dtQrSfsUb?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d61ea95f-e529-4e40-4073-08dc47385be6
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 10:44:16.9113
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mLBVr7Dg9Ij/zWABg8Dw1CTSnl1HiDtCO8817TvFbQqZTT+IU/LZ3Vdas6YUlzBwQsAHyTEKAa4zI4jnfXU88g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8239

cc: +Ingo

On 13-Mar-24 11:24 PM, Stephane Eranian wrote:
> IBS Op provides instructions latencies for each uop sampled. The current
> code was only providing the weights only for loads. This is useful
> information for performance analysis. This patch modifies the logic to
> provide the weights for all uops.
> 
> $ perf record -a -W -c 100003 -e ibs_op/cnt_ctl=1/GH ....
> 
> Signed-off-by: Stephane Eranian <eranian@google.com>

Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com>