Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp133507lqt; Mon, 18 Mar 2024 03:57:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUBWEAVPoCimCgiy52RTxTQMO/Da2k0+u1q97/diPy1/dwP2fIKfakiwfB01oefdAxp/JQdZhKHUgQUxzJulZXHxDPTSIulEkloe6NRoA== X-Google-Smtp-Source: AGHT+IEzt7WMkaiF8MaQa8YnTqVt1C2DacmLh7LIBTW5MqI4rgSgWR6EycEcZCRlaxkL5HtyBMMx X-Received: by 2002:ac8:7d14:0:b0:430:c2c1:3ed4 with SMTP id g20-20020ac87d14000000b00430c2c13ed4mr7550468qtb.15.1710759447416; Mon, 18 Mar 2024 03:57:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710759447; cv=pass; d=google.com; s=arc-20160816; b=zfytW7xTtHrinm/T2q0UIuLOVAyTccM1xGt96kf2Dy2aYgd/GUC9sljR9x5HkZd4xK eo33wN2Q5i/eMWIisWmooKjsuV0lyWtZWP7vVwGRPl5r+u5wWME/F4RBQhRaKNROGwbs Gh/bT3cYd28cUTqpRr4Smf118rWNM8iSkc9/n7Wka2CrrgE2Uhtip4F4JWYug7deozHO atWiUeDR+uQSMj+qU8dlUTtbyLKgqkjDHNolWH71163Un0MwPG8C1iZjLvZx9PcaOCuj hH6Sjw0jDRuTgqXvstH0Y6KkIqV87BGkyAUhaW709Gdo/FWm+F6cusxRXLYm+8gNVvSn SoPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=DMEQFRnKe/GtgVhTR33NYEWIYjxVZMpk768Ijuz317k=; fh=McSdclzvdY2mxMVCG1mwlJoD22LqaGJKyov+7To2TMM=; b=PESNIDUTwOCIi3elge+ZX6YQPGnBgX8D+OEoUoEOAwJKgLtq00bFiZca5OVYXMpvYp RFj1Ig56TT57wTh8mP7QycTP1xUkkBDY6FNuvDI4iTH56VXbSBwhIKwzDYkhDUMymAs8 6Agnx65dbloRBX960TMRhUWoDi5bY/VftFaBDJkCSPyY2DCGhdrUZJspEGKMnzfAbZkO c2fEj6rQ9lelGcPbwK8KnV588cbZivIdnHnbltIBbuBSd6dvpW5R000XViITSJK2vOZx yiBCxy6G+qh8U+QPkJkf6/S2OJ5DLyDfq7E2g5uKozKqxe01VfgX5t8/qmH8E2KMwduL j0wA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xGNBF0zR; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-106025-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106025-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id gd25-20020a05622a5c1900b0042e5a0d43fdsi188865qtb.251.2024.03.18.03.57.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 03:57:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-106025-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xGNBF0zR; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-106025-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106025-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 248A01C214B0 for ; Mon, 18 Mar 2024 10:57:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 074A52E827; Mon, 18 Mar 2024 10:57:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xGNBF0zR" Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81F3A2E83F for ; Mon, 18 Mar 2024 10:57:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710759439; cv=none; b=nFgXFwrvN9q5G18KY/saM3XTICti3LaUthdc4zO51DmZLvw45dYbGAb4BufAWusxU66QcxcOVngKVy3rLEayEip5EUwoijMrsvWtURb4WwJ4+U/TsnhQSiEiYi9L6ESI/pLCBmadQ8O2SSnpFMAVUmWZqlm4BY/7+o8ikGLgVlg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710759439; c=relaxed/simple; bh=3h+E+hcgQ4vcDM0k4nAVO71XgCj8+OwE4lTWOvy8hsU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZPGA6NwQAsCxq979zZJcRbA2BTtmv2cJcBjFyuYs2E6IsKNdnJuMv7SocaafZi9OGSjSC5JASXk7T/QOFQvJrDjW2KSKA08D6KPoLmdyT5fxaQpLo6l5hVelnRUaY0CyQnYXNQ6V4m3I1N9Y9BuBGtXhx8mKhXcl5dLm7WwKyRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xGNBF0zR; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4140fcf4d02so6635295e9.2 for ; Mon, 18 Mar 2024 03:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710759435; x=1711364235; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DMEQFRnKe/GtgVhTR33NYEWIYjxVZMpk768Ijuz317k=; b=xGNBF0zR5Fwu0oS6poTVpQUyv4pei3sC9K0g5Ihq+4QNvcWHwD9Ytrxl1es17beuFo agwAWOf3WO9SzSHn7xMY4HLUpTT1gNabQs1CB8LIPZ3ZupkUcB5qFVXHyacQmhEYjhW0 LmZHX77hcDKi8pfUU1ppQr5WkkmgWFB6OLewQrSpNmhHC8ztBsL6uG6CVpdcxu0W0PQG azpDuhcuPt1G2o/nrr4nyrZKjOAEU8xaC1bBXLpFAELR4P/u/KWdgxtZHXTKF4TrEp62 svwJ8GB0aEA2itwO7nIAfvlGm4gSYCmHMBJw4zzjf+4F42JxyCB5AFvyuBUK4bjeO6wp ysUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710759435; x=1711364235; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DMEQFRnKe/GtgVhTR33NYEWIYjxVZMpk768Ijuz317k=; b=ZIAesvOkr9sVj1DIWic6QWXmx/RtuhwIBwuKLV//FNsb27MbOE5PgmYvbJKPMHPrZg CSFWFYbevCrsthNvRGAxNKV4jhXaC89dK0HNwybG/PbO+KToWGbWsMwV2DjIThivATQ1 XHe05VLbnuq9t2BVXRaJYCyk1n+hzuNTHjV1AZxDtC7uGoUcZsgs5tPTsQYe1rEYbfWC 2TGeWX6TzUBY95Rkfs2qqzPf2GBBRBF5pE4N//DVl8sUlTNTQvbLD1Ns2EIQu14hOebZ ktjBcgaRDvWBrZd2MbfOpJDtF/ZfXClqkLi5OrbSoekrDQcvLOgbcCJRj4BP3YWyoj/9 PkCg== X-Forwarded-Encrypted: i=1; AJvYcCVyRH4fYztBmXqG29l7iyktSA+rEtzC8swuJiW15RcTBuDlNsUdU4xNXCShKeE4OYULyuFP4BxWM+ZEZOUX/Y82C64v0xu+U3aj+CB5 X-Gm-Message-State: AOJu0YyrScVwz21FJT61NbQbv9LA+dCOs8CbcRG87kyb8vGUkQ4ppXmv 9I40VZUySjsGX70IVGF5EeYghptzs4N9oBz+zlS/JkIZW7uexK9pNFQh2JhyzvU= X-Received: by 2002:a5d:4e11:0:b0:33e:7404:be91 with SMTP id p17-20020a5d4e11000000b0033e7404be91mr7884838wrt.43.1710759434720; Mon, 18 Mar 2024 03:57:14 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id bn23-20020a056000061700b0033ec812ee0esm6824449wrb.71.2024.03.18.03.57.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 03:57:13 -0700 (PDT) Date: Mon, 18 Mar 2024 10:57:11 +0000 From: Daniel Thompson To: Dan Carpenter Cc: Andy Shevchenko , Flavio Suligoi , Lee Jones , Jingoo Han , Helge Deller , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] backlight: mp3309c: fix signedness bug in mp3309c_parse_fwnode() Message-ID: <20240318105711.GA16260@aspen.lan> References: <74347f67-360d-4513-8939-595e3c4764fa@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74347f67-360d-4513-8939-595e3c4764fa@moroto.mountain> On Sat, Mar 16, 2024 at 12:45:27PM +0300, Dan Carpenter wrote: > The "num_levels" variable is used to store error codes from > device_property_count_u32() so it needs to be signed. This doesn't > cause an issue at runtime because devm_kcalloc() won't allocate negative > sizes. However, it's still worth fixing. > > Fixes: b54c828bdba9 ("backlight: mp3309c: Make use of device properties") > Signed-off-by: Dan Carpenter Reviewed-by: Daniel Thompson Daniel.