Received-SPF: pass (google.com: domain of linux-kernel+bounces-106118-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1710754409.git.perry.yuan@amd.com> <b9a60328afad40581eeef694937cebd6158f1f2d.1710754409.git.perry.yuan@amd.com>
In-Reply-To: <b9a60328afad40581eeef694937cebd6158f1f2d.1710754409.git.perry.yuan@amd.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Mon, 18 Mar 2024 13:35:42 +0100
Message-ID: <CAJZ5v0ghYCDv2-e0UKXEjSFFbHQ2ingRc1aJco4dSJUknFLadQ@mail.gmail.com>
Subject: Re: [PATCH v8 2/8] cpufreq: amd-pstate: Document the units for freq
 variables in amd_cpudata
To: Perry Yuan <perry.yuan@amd.com>
Cc: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com, 
	viresh.kumar@linaro.org, Ray.Huang@amd.com, gautham.shenoy@amd.com, 
	Borislav.Petkov@amd.com, Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, 
	Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 18, 2024 at 10:49=E2=80=AFAM Perry Yuan <perry.yuan@amd.com> wr=
ote:
>
> From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>

No changelog.

> Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

Sender sign-off missing (when sending somebody else's patch, you need
to add your S-o-b tag to it).

> ---
>  include/linux/amd-pstate.h | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> index 212f377d615b..ab7e82533718 100644
> --- a/include/linux/amd-pstate.h
> +++ b/include/linux/amd-pstate.h
> @@ -51,15 +51,15 @@ struct amd_aperf_mperf {
>   *               priority.
>   * @min_limit_perf: Cached value of the perf corresponding to policy->mi=
n
>   * @max_limit_perf: Cached value of the perf corresponding to policy->ma=
x
> - * @min_limit_freq: Cached value of policy->min
> - * @max_limit_freq: Cached value of policy->max
> - * @max_freq: the frequency that mapped to highest_perf
> - * @min_freq: the frequency that mapped to lowest_perf
> - * @nominal_freq: the frequency that mapped to nominal_perf
> - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear=
_perf
> + * @min_limit_freq: Cached value of policy->min (in khz)
> + * @max_limit_freq: Cached value of policy->max (in khz)
> + * @max_freq: the frequency (in khz) that mapped to highest_perf
> + * @min_freq: the frequency (in khz) that mapped to lowest_perf
> + * @nominal_freq: the frequency (in khz) that mapped to nominal_perf
> + * @lowest_nonlinear_freq: the frequency (in khz) that mapped to lowest_=
nonlinear_perf
>   * @cur: Difference of Aperf/Mperf/tsc count between last and current sa=
mple
>   * @prev: Last Aperf/Mperf/tsc count value read from register
> - * @freq: current cpu frequency value
> + * @freq: current cpu frequency value (in khz)
>   * @boost_supported: check whether the Processor or SBIOS supports boost=
 mode
>   * @hw_prefcore: check whether HW supports preferred core featue.
>   *               Only when hw_prefcore and early prefcore param are true=
,
> --
> 2.34.1
>
>