Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp215119lqt; Mon, 18 Mar 2024 06:08:38 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWNwqch7YXbUxWj6h/D88dqNU/RBlJsA7VgYLsWUHBacftPYd1zcAsTl4ZSzVdub6QJSvw4pN7ujtggQqY/Nu+DYd/NzXiXqIvUou68bw== X-Google-Smtp-Source: AGHT+IEILNGOcBndTIzNn8yvotK5DXrjKH6XhphM/OZqTn7fPAYb3CeV5E7Musn+jzg8cMW1GbvM X-Received: by 2002:a05:6402:1f8c:b0:566:1794:7b2 with SMTP id c12-20020a0564021f8c00b00566179407b2mr8704800edc.13.1710767318648; Mon, 18 Mar 2024 06:08:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710767318; cv=pass; d=google.com; s=arc-20160816; b=rhbadQ2AHqHuoQJiLjG7F6qBuxXko5gtGyMs1nkd1u4c60R7PzoxFaeTmljlJqmS8i YpBOyQw0nXHKsEVo1j0zTuDNKmEhy56G27VYgjIqNHFPK0RrgHYyxvYnTMzpDRZ/4V9f A5U/NeVKfk44zkWoATTX24vCr1SvB+7O7AElI6FLF3GAg0HTyV2bj6Q+ZSFqDbLwTVua yS41G4fcwSf46WwX3i+StL5Mc8OEP8Pc5E5ETzNjxl+mmAz5HMdlA5vaparl3ZIhvpiS LJeCmN5PLPx0qgKEBOiqY8YevCaFGkwIOXOiT/tHWa+1P4lfqyFgQjgQEPgIcDMbr+3x tDmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=0b3lVbJ/u4Iyr/bGVB60L+I6TRPbyfigHd10qyDtAt8=; fh=+qbOq/ssDQFWsqYfwdE+PZSW5i0LdaZ5540Z1+Aac+I=; b=G/TxqoX/1wpr+L4e2tRzwDBVAs8OibKiObfsH1U1KqUzQOzqFwXjiKI4U16dtU7gC/ Zjhel6pq1yZ9Z4HW7wfkj3GOv6NWZFulfcpcqVdD7EmJu0j5C2W3WXjftIwELlF9La+X ZNGo8TcbHBlx0lSV2FVhjZgonFsHV3n/KJpUkFEBjUBkH6s99WPL1qntdw4sCyYR0Q/o mqzz/6gvwfazwwR5A8PZISKKcEBvDA91djmggAlvv1DPXgUknRpxzMfqQ6IQvaW7fKef CvYpOu6t82TScAah7ZDUhbV/GqKSaw5bW7yBbK98nXIO8b0NiwvFM1BHxQj+yvPdzGf8 I+gw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=HlykcDMR; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-106146-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106146-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id g7-20020a056402428700b0056b7e4655a0si540306edc.218.2024.03.18.06.08.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 06:08:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-106146-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=HlykcDMR; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-106146-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106146-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 608D01F21E26 for ; Mon, 18 Mar 2024 13:08:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4692B38F98; Mon, 18 Mar 2024 13:08:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HlykcDMR" Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8CC41DA23; Mon, 18 Mar 2024 13:08:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710767305; cv=none; b=d4nh1ShB0JeDU5EDRb9RCdtVYrPV81E3O9a1x0yyST1xSOL4sk20cJh3Wbfv1ppujspJoz/WFlAzNS6LcHBM0jw85Vgu1iFUr1LvFzP0oLYeJWfDd3+8drrQn2r+wcEuYHTEW2YgOsqrIISxwbZRmsplBBNcqU0YknTqf9gCT0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710767305; c=relaxed/simple; bh=9y8WJjFyw32pW/zJbqRdgBfGpHDDLgekVbv5GaetnbY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=b+np8t2Mj+ZxBQVmzxkZLF5CMY3IjsA0tokAKvV3ezafh4qZ9CHqYJwZ3SMXnwg1nw7SWkwI/nCC/eRFek+O3xEfNhKKYJQ090VeSh4QbhpSxVgEWE1ZGYHzLJNghKyZW9A8i3QjtyM68vOWlGaicJ0NeSALI9HW45pJyp22MRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HlykcDMR; arc=none smtp.client-ip=209.85.167.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-3c1a2f7e302so2445909b6e.0; Mon, 18 Mar 2024 06:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710767303; x=1711372103; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0b3lVbJ/u4Iyr/bGVB60L+I6TRPbyfigHd10qyDtAt8=; b=HlykcDMRwV8Y3mbA9rjIDRX0GEs3DCbCc54OLQ3sD2B+AYRBn/FBTeRYXntab2Toyq 9uxtn53mvPyuvpZxwkZEBWTHgPqRRxjDKWUGT3Odn1W5dDr5Anfd7NERRwng3xGKUIM0 OLRsVSLzpso8PLJ/0zW5idIa7XxaX+fKM6sm27UHXwFz1LFuwYFbgBlwFkW39+TKnfmm xCXjd92QJvoL8TzNCgyuNgq0RMx1WxNB4+7I6cfvXPusnWobo2QC9km963uyWk9F/IX8 Zyo57EM9D4T6l5QF0D8MC+LSb4AWcnQrKgV/87berIwGkoBaDnFhGuHQSdOxXGFFeAib GA1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710767303; x=1711372103; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0b3lVbJ/u4Iyr/bGVB60L+I6TRPbyfigHd10qyDtAt8=; b=LFZN9qTe0Jif2481Gjwytcw8fXFGMuP31h/+Z6jqdXwaJDeFYyUBVir1hfA9dFAHVn mAurXMa8dBTPjSipMk9T49OXxTHERKi4HnxDdf/56ZHL9YgGYUmcb/udHS0NRNIvmrAa 1HeR+utGR47ioc3UAD/y1g3/BC9p/Vj55NsGXRJe9TcGpYQ1cE/3LcbjhqD6Ft0JcJBJ mH+umE5ZaZcf75Az8Az0o96E1tfeMNS8zulnNBUXrnZeFmAfxwgXwK5sJiF1U50Np+YZ Zs5TVQkCwjNECCoBzEy3Gne+P/RTybK6yB6827fwIxFJt52FKmpkQfDtcjC7r9fgcWfw 6I2A== X-Forwarded-Encrypted: i=1; AJvYcCWust3m/oJ1x+4DDLrDX52gFxnAbYKQGw9CU9TWrC1dW0bUQnYDWADaUlCGYlFElQH7dQGDpKWnNfewaksCtMZTfQ+pgOdhWh8HAxZd4Q8QSgJUTQeBAU/s+deqIv1qP8wVceKp X-Gm-Message-State: AOJu0Yw+LlrpqVTG+mSJO3mlbnfa1bacecP3Sd3SRF/ZIr8nmAnLYtiL kHXzv4L6x+HDbab749DwgMhfWNQh2Ziv7ZYJPfR7fttxdHv+yMm4 X-Received: by 2002:a05:6808:2289:b0:3c3:82a1:e6e with SMTP id bo9-20020a056808228900b003c382a10e6emr7831238oib.53.1710767302926; Mon, 18 Mar 2024 06:08:22 -0700 (PDT) Received: from [192.168.1.3] (ip68-4-215-93.oc.oc.cox.net. [68.4.215.93]) by smtp.gmail.com with ESMTPSA id l16-20020ac84a90000000b0042ee243ca95sm4953118qtq.50.2024.03.18.06.08.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 06:08:22 -0700 (PDT) Message-ID: <50d8a099-1274-40a7-937e-b2618bfe65be@gmail.com> Date: Mon, 18 Mar 2024 06:08:18 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] net: phy: mediatek-ge: do not disable EEE advertisement Content-Language: en-US To: arinc.unal@arinc9.com, Daniel Golle , DENG Qingfang , Sean Wang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?UTF-8?Q?Ren=C3=A9_van_Dorst?= , Russell King , SkyLake Huang , Heiner Kallweit Cc: Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20240318-for-net-mt7530-fix-eee-for-mt7531-mt7988-v1-0-3f17226344e8@arinc9.com> <65f7f17d.050a0220.c6db1.02bdSMTPIN_ADDED_BROKEN@mx.google.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== In-Reply-To: <65f7f17d.050a0220.c6db1.02bdSMTPIN_ADDED_BROKEN@mx.google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 3/18/2024 12:46 AM, Arınç ÜNAL via B4 Relay wrote: > From: Arınç ÜNAL > > There's no need to disable Energy-Efficient Ethernet (EEE) advertisement on > the MT7530 and MT7531 switch PHYs. EEE works fine on MT7530 and MT7531 > switch PHYs. Remove the code where EEE advertisement is disabled. > > This is a bugfix because there's a possible race condition where the > mediatek-ge driver would kick in after the MT7530 DSA subdriver which would > have EEE disabled until manually enabled. > > Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver") > Signed-off-by: Arınç ÜNAL Could we get Sean to chime in, maybe there was a valid reason to disable EEE advertisement in the first place? -- Florian