Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp230304lqt; Mon, 18 Mar 2024 06:30:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWLpmqzzBFWn2MdIFb2uYV6qwwGRPM1XK4wUDFlGAayy0L1XwjT/20pCFstBNrsBnNRl2nLG0MLfoZW+vqOIfHIS/eMJ9YWP+CSK9upBA== X-Google-Smtp-Source: AGHT+IHWdcA9r32qHLxouoBnogHzx0K+iGxpyRQSQp3WtCueOznyVd8j3sBzcHHNIA1VjEsf5Gyo X-Received: by 2002:a17:902:f7cc:b0:1dd:76f0:3dde with SMTP id h12-20020a170902f7cc00b001dd76f03ddemr9064836plw.31.1710768635837; Mon, 18 Mar 2024 06:30:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710768635; cv=pass; d=google.com; s=arc-20160816; b=iXrrZiH0QBgatmpM+5AiS5tGCFnZrZPDIsdOuiMCJi0OK7kwAqO5NgxVQ2mgthDJiw ncBlBzJ5NqIFE7oMw5djaUP1gJG//gXz09pVyytZUs2mdzvM6TLhfAuBxe7aM7DqIwrh rXrQr6t38u5bNP+fTaJcA469mHdA83PBpDbNa8UdkyGAVjR4Cihn4iI3wBGgBoxBu3zw g0akw6ffWS38e/jClpL9SFotcEwWxrIQOUboAqWRr/Q7WzcoUerYIjXsSrZy04a/mJni U7HNbQdwRcNl2UOAOAHMDfDyZ5LO8GvxxV4AHkXXnQ7xSLsPDD4aXrPcIQNJwtgVvvPJ CUWQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=H4T7GRxUc7yBWQ/u7+eX/MPNWtS9olwvn5w3951JJzo=; fh=OlhUSvOu7zodas5aR1gxxmi5cZZZmowVzKBXR1cwRLA=; b=RDZn17/jrhu6Bp7u6Ee0OXcA6H+++gDKFi2WVTFTDMpCCEqnbINvd5wawP5Ql+q309 Rtr3HrxItG2ADVwx9dBRROGpokm2SI2aEvLQqXWWW1W+I9k0HKJfqZBV9xa7QyG4TbW9 h+xQGq5gAgYTpLIZqaoUYJDxBJ31d8sWeL9F6sDkpgQS6ygXDGifAcdUb4hyMz8NP+yZ 1XIvWglshgRW4OFgo+AMnR9qUNflkXimnubvLVOOmP7uAJX8Dk7Rhg6oW4BYw0EZj5nK MeisiUoSSL1QHW8gFBWxmuMDEzJdcBneQACqW9VRtAgybFfWE7u/d+ZzvYikbi2sAnQ7 wA5g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KPwx81na; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-106165-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106165-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id b13-20020a170902d30d00b001dca617fbfasi8594495plc.289.2024.03.18.06.30.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 06:30:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-106165-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KPwx81na; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-106165-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106165-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9FF3CB215B5 for ; Mon, 18 Mar 2024 13:29:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 34EDF47F7E; Mon, 18 Mar 2024 13:28:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KPwx81na" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5726547F50; Mon, 18 Mar 2024 13:28:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710768533; cv=none; b=AFL/XfWCmI/o6+DjxtA/9hx+nYqN1D0MhXd4IHVTm+Vg2PLgOdIPNCVJizwLE+YMTCORykEkFHuXacEmOvhg0qiIkijmRGxdLdUfD2DA4XLugl+RI88msoyqKiOJutWkY8O5F/TTYD2JxCxXfQE7NnkSqiSgQHBWam/2rrEj67g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710768533; c=relaxed/simple; bh=H4T7GRxUc7yBWQ/u7+eX/MPNWtS9olwvn5w3951JJzo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tTSlN6IwMW/ovnS5iKPhMUAyqqSXJRlYWdzfHR46b4m9RH/8XV+xN3mKAZNQxQ2AZ5nen9YjVqaYTbrZqTDTZDATVUia99aYK8in2NVT3FPHVLaa4XX8afVYYxuLk/olykt7c0xo7CcxE1u3JP/P3mvllZtzo+FtAr2UtQ0/H6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KPwx81na; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FDDAC433F1; Mon, 18 Mar 2024 13:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710768532; bh=H4T7GRxUc7yBWQ/u7+eX/MPNWtS9olwvn5w3951JJzo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KPwx81naHa13NzOUadChg3ZXXlM4Sfuiu0hyjqME8CSu7bbn6dPXX9fM3Av51MWwp lC6BjSjjKXisOf6Kvo0k30BSGCQfHKEVSPAMVo8LAwdYWGTUZUMS5aHHFpJ390HQE+ KystrWwhb03wJgV+GuBOFmbQN4WUyAEUbeJhFnSroQKxi7YHBnKb5X335rck3OiuZ9 ORW1KLzz9YcbC7cPhtj5UZHvZ5wZYTZeVlMIjuTMINnEH3fjFVqS6Fc1MYzCQHwGpv wfrxRv5tLvclqRosigeSDxi4ltoMjD44u15AGBfr1C1z9WAHE4aRdcLrAEkwvokDGa apDTwQGa95aFg== Date: Mon, 18 Mar 2024 13:28:44 +0000 From: Mark Brown To: Bastien Curutchet Cc: Herve Codina , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Ujfalusi , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni , christophercordahi@nanometrics.ca Subject: Re: [PATCH 04/13] ASoC: ti: davinci-i2s: Replace dev_err with dev_err_probe Message-ID: <0ee075c8-7c74-444b-9024-ad5440c36789@sirena.org.uk> References: <20240315112745.63230-1-bastien.curutchet@bootlin.com> <20240315112745.63230-5-bastien.curutchet@bootlin.com> <6102130b-b496-4e75-9b9f-f960484848fb@sirena.org.uk> <20240315152332.57c8fdc4@bootlin.com> <2f58922d-8964-4693-ab8a-612eb2f427e1@sirena.org.uk> <622b8b7e-7bd1-4e88-b705-79f7077b754a@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sdrGDqd8KEdxafwD" Content-Disposition: inline In-Reply-To: <622b8b7e-7bd1-4e88-b705-79f7077b754a@bootlin.com> X-Cookie: Alaska: --sdrGDqd8KEdxafwD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 18, 2024 at 08:40:24AM +0100, Bastien Curutchet wrote: > On 3/15/24 15:40, Mark Brown wrote: > > I'm not convinced TBH, the fixed error code smells pretty bad. > Ok. I'll keep the dev_err() for the fixed errors then, and use the > dev_err_probe() for the others, would that be ok ? Yes, when we can get a deferral it's the right thing. --sdrGDqd8KEdxafwD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmX4QYsACgkQJNaLcl1U h9DEsgf+Ny9qlyRP+/by6BPfHGXB+skGcS3TPXz/GIAnirpIiVrZg4hPTC/uSxWF kuUx+m7UnPWUrUm7rBjDOhBNBpF16YY06MguCTLpBoOJ1f79tVB6Pn/8afzpGWS5 GjmCKVR8riUNwbh+/WvWF6t9FPMnjRWYPqudsy8w/Bw2zgkDzFCYUhKzdfhii7bp TxBsaLFP8c+OT4plH/ofuW/RJNidJwn/f2cC2PWF5pv3uv2s3Jy4IAl/KvKRaYzl Q+H3bGkfGslxduSxefjqGmB5WW0eFmOfefTZ0OVckvp5GdORBWPp8uGLq+Ge+sh0 poWhOCiuHaeY5JEeyFx2YXhxaFrCLw== =wK3n -----END PGP SIGNATURE----- --sdrGDqd8KEdxafwD--