Received-SPF: pass (google.com: domain of linux-kernel+bounces-106175-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240318055054.1564696-1-d-gole@ti.com> <20240318055054.1564696-2-d-gole@ti.com>
In-Reply-To: <20240318055054.1564696-2-d-gole@ti.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Mon, 18 Mar 2024 14:47:45 +0100
Message-ID: <CAJZ5v0giafbnGFHgT7pZm+o6KzKznxVDJvc04K6XvP1ShG2YKw@mail.gmail.com>
Subject: Re: [PATCH 1/3] PM: wakeup: make device_wakeup_disable return void
To: Dhruva Gole <d-gole@ti.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, "Rafael J. Wysocki" <rafael@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, Tony Lindgren <tony@atomide.com>, 
	Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Viresh Kumar <viresh.kumar@linaro.org>, 
	theo.lebrun@bootlin.com, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 18, 2024 at 6:55=E2=80=AFAM Dhruva Gole <d-gole@ti.com> wrote:
>
> The device_wakeup_disable call only returns an error if no dev exists
> however there's not much a user can do at that point.
> Rather make this function return void.
>
> Signed-off-by: Dhruva Gole <d-gole@ti.com>
> ---
>  drivers/base/power/wakeup.c | 11 +++++++----
>  include/linux/pm_wakeup.h   |  5 ++---
>  2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
> index a917219feea6..752b417e8129 100644
> --- a/drivers/base/power/wakeup.c
> +++ b/drivers/base/power/wakeup.c
> @@ -451,16 +451,15 @@ static struct wakeup_source *device_wakeup_detach(s=
truct device *dev)
>   * Detach the @dev's wakeup source object from it, unregister this wakeu=
p source
>   * object and destroy it.
>   */
> -int device_wakeup_disable(struct device *dev)
> +void device_wakeup_disable(struct device *dev)
>  {
>         struct wakeup_source *ws;
>
>         if (!dev || !dev->power.can_wakeup)
> -               return -EINVAL;
> +               return;
>
>         ws =3D device_wakeup_detach(dev);
>         wakeup_source_unregister(ws);
> -       return 0;
>  }
>  EXPORT_SYMBOL_GPL(device_wakeup_disable);
>
> @@ -502,7 +501,11 @@ EXPORT_SYMBOL_GPL(device_set_wakeup_capable);
>   */
>  int device_set_wakeup_enable(struct device *dev, bool enable)
>  {
> -       return enable ? device_wakeup_enable(dev) : device_wakeup_disable=
(dev);
> +       if (enable)
> +               return device_wakeup_enable(dev);
> +
> +       device_wakeup_disable(dev);
> +       return 0;
>  }
>  EXPORT_SYMBOL_GPL(device_set_wakeup_enable);
>
> diff --git a/include/linux/pm_wakeup.h b/include/linux/pm_wakeup.h
> index 6eb9adaef52b..428803eed798 100644
> --- a/include/linux/pm_wakeup.h
> +++ b/include/linux/pm_wakeup.h
> @@ -107,7 +107,7 @@ extern void wakeup_sources_read_unlock(int idx);
>  extern struct wakeup_source *wakeup_sources_walk_start(void);
>  extern struct wakeup_source *wakeup_sources_walk_next(struct wakeup_sour=
ce *ws);
>  extern int device_wakeup_enable(struct device *dev);
> -extern int device_wakeup_disable(struct device *dev);
> +extern void device_wakeup_disable(struct device *dev);

This change will introduce a build error in sdhci-pci-core.c AFAICS,
so you need to modify this file in the same patch to avoid bisection
breakage.

>  extern void device_set_wakeup_capable(struct device *dev, bool capable);
>  extern int device_set_wakeup_enable(struct device *dev, bool enable);
>  extern void __pm_stay_awake(struct wakeup_source *ws);
> @@ -154,10 +154,9 @@ static inline int device_wakeup_enable(struct device=
 *dev)
>         return 0;
>  }
>
> -static inline int device_wakeup_disable(struct device *dev)
> +static inline void device_wakeup_disable(struct device *dev)
>  {
>         dev->power.should_wakeup =3D false;
> -       return 0;
>  }
>
>  static inline int device_set_wakeup_enable(struct device *dev, bool enab=
le)
> --
> 2.34.1
>