Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp244895lqt; Mon, 18 Mar 2024 06:53:58 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXzwZ/Kdq6jVrS058qYkf+3ENXA45qArbN5jXED76tUcsaVCptNk8zi3CwH8QGaoDdNPEQk41MJTD7v5Flhu84LAfqAsKKXpabLISbVDg== X-Google-Smtp-Source: AGHT+IEP5nn3sh8DRdMu1yxbdx3v7uehRewccJvGVuSnagJJxZfiLJqh1A/iP1y8GEyv3yaykYD9 X-Received: by 2002:ad4:58c1:0:b0:696:22ae:eb67 with SMTP id dh1-20020ad458c1000000b0069622aeeb67mr1233124qvb.33.1710770037833; Mon, 18 Mar 2024 06:53:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710770037; cv=pass; d=google.com; s=arc-20160816; b=LX04IOMyJSLDQtqPvBPv83Xbf1RISTmv1L07+IazISogyMnq7KKqLEk4U4DMkcKqzm 6dqxmtIo7pFXwEDRglJmKFmW1sBrBx1749bh9MSqVYL8XkjUusrbHMoidGp4fJaZ9HvZ VrYo8QwVFXDvzuyNkhWqMiZpxzgt7lghC3DaWNkz8obZGPeR3Ms8hLa48jDP9mKobzni 9uo7Th03qy1yMnm7i3U1CdHCatdZLpt+e0Kcj+muDt9LYWPqiCRLgSUwQN8Ll7hOrIou fgYMai5K9skMniGu4IWX3QIuX3BgKZ4wwqDFr7n2DshYc5ZUBt1XsNJbCrFWmG1vA/yb Abkg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=u1yyzTi2c2/Td6SHQKiI6i7cubGL5WL4Kr8KIUiJjvE=; fh=y+vgqhL53ZnSJ0mIMqDKTwtkNbEYitl9joXTZY6nBiU=; b=DX8MSV5BD/Nyt5ndk97mYAjQ14R3/qAbbFYxmJYWvd2TfTkH5/7E5Wnt18Ux9VTbsx wgN1JxkKQwtjeLRH7yB6sQfK8d7MOtt+IU3hSFnlV/Eau7GqXl2NcLsQ1TEwdpXAvJEj 0KbXKpj3daf42NCPpabr4Xe1Ta3N5fG49GDehSoxlbTK5IgwUB6fBnG+wIJGrkEdYkBF wpb7Y850nUEp9lRgkO+Yale9Z3ehwIYh4Yokxiy/1P06blaE6DJZQZLrc6nisCdB3Kfs duK9CA+EpCWtM48ibCTpx8sPCwBfa4EJO9zlcEGZJOdYzMotaxW3yIGQnTM1xZcR8Nu7 UKsQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-106183-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106183-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 2-20020a056214202200b00690a5754ceasi9203164qvf.245.2024.03.18.06.53.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 06:53:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-106183-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-106183-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106183-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 651561C211D1 for ; Mon, 18 Mar 2024 13:53:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8BA104AEEC; Mon, 18 Mar 2024 13:53:49 +0000 (UTC) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2AE33B1AA; Mon, 18 Mar 2024 13:53:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.35 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710770029; cv=none; b=oAJ5gmoOkXd8VXCXiwcqFDORpWVNkx+wXOyLo+SVLBaPPXTNFrvVJ698hfkBmHnjtyuaLhP85vGeqY1aJ3NOIAMXDWTXNio/zBHbmvRIWRytXHWEnl3xOx/VJ6aS7AlLOABDuEhWdqgyGh6Yb33OqnSUsUcK4W+lsxN/biA4vtA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710770029; c=relaxed/simple; bh=Vu96on3ELce8oj2lYXDb7Wwq/sWwPtuQ5VXawLVemTk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BxiXZ6BcuEjYfkahmS7eN+5KlmaZYDJal4a12hB5lr0qn/eBlfYX/fbwvEDIFBuE36QW5tL/IsL4wSBBuSjYMqffFleEShBFzZsHS35K/2JlNQFUeGxJA9zyQ4RWoxQ0VsNh8yPUtzGrVkQwelTPWH5Y1dd4PvLZymXAL6fLmqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Tywkq0z5Vz1QBtL; Mon, 18 Mar 2024 21:32:19 +0800 (CST) Received: from kwepemm600007.china.huawei.com (unknown [7.193.23.208]) by mail.maildlp.com (Postfix) with ESMTPS id 3A19C1400CB; Mon, 18 Mar 2024 21:34:51 +0800 (CST) Received: from localhost.localdomain (10.67.165.2) by kwepemm600007.china.huawei.com (7.193.23.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 18 Mar 2024 21:34:50 +0800 From: Jijie Shao To: , , , , , , , CC: , , , , , Subject: [PATCH V3 net 2/3] net: hns3: fix kernel crash when devlink reload during pf initialization Date: Mon, 18 Mar 2024 21:29:47 +0800 Message-ID: <20240318132948.3624333-3-shaojijie@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240318132948.3624333-1-shaojijie@huawei.com> References: <20240318132948.3624333-1-shaojijie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600007.china.huawei.com (7.193.23.208) From: Yonglong Liu The devlink reload process will access the hardware resources, but the register operation is done before the hardware is initialized. so, if process the devlink reload during initialization, may lead to kernel crash. This patch fixes this by checking whether the NIC is initialized. Fixes: b741269b2759 ("net: hns3: add support for registering devlink for PF") Signed-off-by: Yonglong Liu Signed-off-by: Jijie Shao --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c index 9a939c0b217f..80db4f7b05f6 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_devlink.c @@ -40,8 +40,9 @@ static int hclge_devlink_reload_down(struct devlink *devlink, bool netns_change, struct pci_dev *pdev = hdev->pdev; int ret; - if (test_bit(HCLGE_STATE_RST_HANDLING, &hdev->state)) { - dev_err(&pdev->dev, "reset is handling\n"); + if (test_bit(HCLGE_STATE_RST_HANDLING, &hdev->state) || + !test_bit(HCLGE_STATE_NIC_REGISTERED, &hdev->state)) { + dev_err(&pdev->dev, "reset is handling or driver removed\n"); return -EBUSY; } -- 2.30.0