Received-SPF: pass (google.com: domain of linux-kernel+bounces-106201-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 18 Mar 2024 15:16:15 +0100
From: Michal Kubiak <michal.kubiak@intel.com>
To: Jijie Shao <shaojijie@huawei.com>
CC: <yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <rkannoth@marvell.com>, <shenjian15@huawei.com>,
	<wangjie125@huawei.com>, <liuyonglong@huawei.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 net 3/3] net: hns3: mark unexcuted loopback test
 result as UNEXECUTED
Message-ID: <ZfhMr6t0pQG+Dp63@localhost.localdomain>
References: <20240318132948.3624333-1-shaojijie@huawei.com>
 <20240318132948.3624333-4-shaojijie@huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240318132948.3624333-4-shaojijie@huawei.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/XH/3sfHzoGm+ITWECqBHA9O82rcG/k/VuUc+rYeUohxdEJwOmV2LlGsgkoN?=
 =?us-ascii?Q?GL/Vh+yI2iqawTJMZS+On2IFaeTiFl3ym0BWwZd3ziscqJNYZUbEPkoYeEYp?=
 =?us-ascii?Q?4oKnSVs7LEduiUQGfI+oHFLvi6HEYrly0NyFdopuS+IJAdk9w8OCLXwOGU2c?=
 =?us-ascii?Q?vWu5VHLfTQgIicH2u4c6J+xJm4Pfk36JaV2MDmdVw9LPuPUqUOJl5X0xya1g?=
 =?us-ascii?Q?Cm17h/1SE8iSbikis2M4yDxkhFl/fDz0DGTW52B8R6n1hb8I1aOgb/xqO/Zp?=
 =?us-ascii?Q?dBBl/NmHq0ky2/CbLYAnvqTcUxgZQCLVdX2AZRvwFri/Wm38Ne0uwCxYfBla?=
 =?us-ascii?Q?pWa9tttgBs9cE06/JQd0DX63xx/sjbmI83BFvm5OZ7DFLKYCCtQIP8bJitA7?=
 =?us-ascii?Q?xVBFjp9FD2Zgd+paa50ZR8gFHkOLTHeaEYKMyU+jYpeauMQq8O6ZBpWShQe3?=
 =?us-ascii?Q?cLFZdaRqLoEoLXGFbRpgXbir1rvAXmmPstUyXSbIYCjGDmRAGL76pBRyxhwy?=
 =?us-ascii?Q?L4jDtBchXSAIdu2GS9eQ9FH5svZQ51g+EcfZltMJpHqMP2DVn/teKa0+wZig?=
 =?us-ascii?Q?eY+sPRZtJoVgU8S2umZ5o37sniiLqonsLo841JjQLlKavpOW6v2i2XYyGmUL?=
 =?us-ascii?Q?JqEKRvl8bFviOO3XGSY60uBcWIYLdP/V3eMM+o1v49DSn8Ia1Num0jR79nKX?=
 =?us-ascii?Q?/TIQMb8UuKU6DvAvsE29EEqAt8BIoGhuLSBVPVbLroLkcxawNK2LTLQenw/l?=
 =?us-ascii?Q?Kr7rvqKHfx83RV0BhvdliEILP5PmQV7FhvycgCtzQrld3ru18Vi2CFJrnr98?=
 =?us-ascii?Q?2WMzn52zXdm5f1JbDNONJMOchl13pqbJXjlm8qLs9Xa6PjvENgEGntX2Vi4n?=
 =?us-ascii?Q?OXW/vrE+rfsLOuRfXZ2LyPUM2trfk+Kn/DjA+j0MEH055La84TtDa5Sz7PmA?=
 =?us-ascii?Q?7Iubp4mhOpkZau5cFhezzQWOSOnahNGnxW7fwXrOtkph6SRifcYaP/e9p1u9?=
 =?us-ascii?Q?sIAqrpFy89l858FLFqTwzRrQxInvzwMisa0JIt+PLoKauW6+NKRX30NtpkTH?=
 =?us-ascii?Q?tsBuL06wxagMEukmd7yla1/ko94XB0EBvQ/FjrFvf8ZIbMMbAgUvXRec9i8w?=
 =?us-ascii?Q?ol8XB0ldkyBIxnjFjhMs7oti7U795EXemXo6Z4xlfXo/kDRpfdnTqjNsYl/l?=
 =?us-ascii?Q?AFn3DecFgxRgHHb1UvJvCEoXuGmRZ3LFMk2cmv0iZNsJxNl5uQW2DoYKGgYT?=
 =?us-ascii?Q?d/V6fpSaX69dsOYBSIUPebpHDhVN1dHdLE9sK+S6OZGVeKG4NWoPbFJ7CvAg?=
 =?us-ascii?Q?H3bbo+3dwP4hc8WglJUx0kTm30IXKG6eHbBg4hynEbIK0L4RfbDJjrBYKnAs?=
 =?us-ascii?Q?L9yrOo4A9Irn6VkdwNwaD3ng7bXhQiJom7Uzj20VBPvCcNUp1s4rqOiT5spv?=
 =?us-ascii?Q?aeR1H23xIggkZKzujm9NN9k6d7GpRLilWf/saxzCgurFHJJetPaclr61nvur?=
 =?us-ascii?Q?TXKImJ7O22A1pUiPKjKov85j4a5q5p89kz+JE3KRUaNCBS4zU4Wb9SlX7K5J?=
 =?us-ascii?Q?Uh7+uVluD7pzX6tm9LuGOfh76uIRZr0NIVt2R/GQu9MLKwsXPLTJm0VXUujZ?=
 =?us-ascii?Q?EQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a9895ab3-59c9-4016-eeff-08dc47560087
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5782.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 14:16:28.2583
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qteVdxyXepuFPVTY7tVGpAflToyTmDw0yxcpGNoGxZvdmXVCrvEtb4ksfjyrzBwYBE2AYW1fiL7DgcizoskTZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7768
X-OriginatorOrg: intel.com

On Mon, Mar 18, 2024 at 09:29:48PM +0800, Jijie Shao wrote:
> From: Jian Shen <shenjian15@huawei.com>
> 
> Currently, loopback test may be skipped when resetting, but the test
> result will still show as 'PASS', because the driver doesn't set
> ETH_TEST_FL_FAILED flag. Fix it by setting the flag and
> initializating the value to UNEXECUTED.
> 
> Fixes: 4c8dab1c709c ("net: hns3: reconstruct function hns3_self_test")
> Signed-off-by: Jian Shen <shenjian15@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> ---
>  .../ethernet/hisilicon/hns3/hns3_ethtool.c    | 19 +++++++++++++++++--
>  1 file changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> index 999a0ee162a6..941cb529d671 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
> @@ -78,6 +78,9 @@ static const struct hns3_stats hns3_rxq_stats[] = {
>  #define HNS3_NIC_LB_TEST_NO_MEM_ERR	1
>  #define HNS3_NIC_LB_TEST_TX_CNT_ERR	2
>  #define HNS3_NIC_LB_TEST_RX_CNT_ERR	3
> +#define HNS3_NIC_LB_TEST_UNEXECUTED	4
> +
> +static int hns3_get_sset_count(struct net_device *netdev, int stringset);
>  
>  static int hns3_lp_setup(struct net_device *ndev, enum hnae3_loop loop, bool en)
>  {
> @@ -418,18 +421,26 @@ static void hns3_do_external_lb(struct net_device *ndev,
>  static void hns3_self_test(struct net_device *ndev,
>  			   struct ethtool_test *eth_test, u64 *data)
>  {
> +	int cnt = hns3_get_sset_count(ndev, ETH_SS_TEST);
>  	struct hns3_nic_priv *priv = netdev_priv(ndev);
>  	struct hnae3_handle *h = priv->ae_handle;
>  	int st_param[HNAE3_LOOP_NONE][2];
>  	bool if_running = netif_running(ndev);
> +	int i;
> +
> +	/* initialize the loopback test result, avoid marking an unexcuted
> +	 * loopback test as PASS.
> +	 */
> +	for (i = 0; i < cnt; i++)
> +		data[i] = HNS3_NIC_LB_TEST_UNEXECUTED;
>  
>  	if (hns3_nic_resetting(ndev)) {
>  		netdev_err(ndev, "dev resetting!");
> -		return;
> +		goto failure;
>  	}
>  
>  	if (!(eth_test->flags & ETH_TEST_FL_OFFLINE))
> -		return;
> +		goto failure;
>  
>  	if (netif_msg_ifdown(h))
>  		netdev_info(ndev, "self test start\n");
> @@ -451,6 +462,10 @@ static void hns3_self_test(struct net_device *ndev,
>  
>  	if (netif_msg_ifdown(h))
>  		netdev_info(ndev, "self test end\n");
> +	return;
> +
> +failure:
> +	eth_test->flags |= ETH_TEST_FL_FAILED;
>  }
>  
>  static void hns3_update_limit_promisc_mode(struct net_device *netdev,
> -- 
> 2.30.0
> 


Thanks!
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>