Received-SPF: pass (google.com: domain of linux-kernel+bounces-106221-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 18 Mar 2024 15:26:55 +0100
From: Michal Kubiak <michal.kubiak@intel.com>
To: Jijie Shao <shaojijie@huawei.com>
CC: <yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <rkannoth@marvell.com>, <shenjian15@huawei.com>,
	<wangjie125@huawei.com>, <liuyonglong@huawei.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 net 1/3] net: hns3: fix index limit to support all
 queue stats
Message-ID: <ZfhPLzmM+1r1duo1@localhost.localdomain>
References: <20240318132948.3624333-1-shaojijie@huawei.com>
 <20240318132948.3624333-2-shaojijie@huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240318132948.3624333-2-shaojijie@huawei.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NR8AKvwkLWUvqIZI+Xe4puVYDibE51q95ZHjnZZByIzU3FBjbM2oaE2YJwck?=
 =?us-ascii?Q?KIbrBbf4oELIR9ozn9Yct1iFXxcq8ZbTc98QoGaJoTw4MDgj/2lvgOW7iPmg?=
 =?us-ascii?Q?2Voosla1xpD2QjX4E7g8RlCAxsZkXrBFjMbypgHdHifqJL6KlxVRqOu0O34G?=
 =?us-ascii?Q?d8opEVAjKAJ08x4uQA3OiUHJ3afOuEvSjKYSvqDynVT9LRbl+D7ZWnR8XsM+?=
 =?us-ascii?Q?adDzx7+eW6P0a0PHuIG8REVq052fzsoVQrvwfFJeZY8CXeh67pjyxYO1MF/3?=
 =?us-ascii?Q?K5GkTQHoKVHV1HrVwFuTs6YQ9+HBCPAESYNVkzxvWQ7FW79/Jw+S5wrHYTlz?=
 =?us-ascii?Q?62S8ORVO908gmFBpWTzJQIoSSEXX/WRHk2Dwr9bskm0zxKLecA/z3JF5AGbd?=
 =?us-ascii?Q?gytdJM9sS+I4ABNI4GBe7KGcUWOgqYyOlUhYl/FyLG9K7xM+CN/lv1h0WpwQ?=
 =?us-ascii?Q?XCFo4keJBugS0qFmD4yDpIUsku2E7wpD+T5TSvQjIGap5ywNjBJWpJL9wiHQ?=
 =?us-ascii?Q?ZiNQZo1+CZZwe9ns5TH3irZ9jzklc83w+An6niuSJvXZMT6eYwI+wSRyyEv+?=
 =?us-ascii?Q?g4egPuxDzUeIyH/Hgz0BxYFfAaMbeWv8xs/zJNdqBKnb2DeJL9HbYETZSlv0?=
 =?us-ascii?Q?Wype478NlBFxvNwO5m4HOuCsSPfoaZ8TOl8rRmNPRHfO4+g1tvowgUTPEM9r?=
 =?us-ascii?Q?oazk24ariRniDQgtpL1qeMi+jJQlfgwgJwZC0zZrprTl9t6ov6KFPENvctBQ?=
 =?us-ascii?Q?3gnqNPhqorqUUB/cQR4YT4b4r0seADODl9AGSO+5HVfxaxCDtsibvOQaM4i0?=
 =?us-ascii?Q?FH0qNUQt+IRjCir/Vo3loHx5IgWzYPvrRObAH5GXlGl+oFWC1dDFEgQaSrvw?=
 =?us-ascii?Q?AuxLbC36uTHfY3YSijBP9BQVBS+vA+FWet7HWRslfNr7xgSS+E203Mrgg8Vp?=
 =?us-ascii?Q?e/vhhDKg7o5LJqIgiH3dKtQHoyQyVanVmwh9JdPvE+VULDlBPWiaEgz2SryP?=
 =?us-ascii?Q?bPnKV3eFgMRB0gdc1GuDGJhTTKAzRwcs7TD2eYCjIzv3ZW1fl0K+bL5ZsvA0?=
 =?us-ascii?Q?S7yc+V/sjXNW53FpadCCMLB1X7aeP9UENL883u3cWimmgoJbpQL8b6GETx+o?=
 =?us-ascii?Q?stxAPxwggNumNfHhdH5+CKTf0bN31AQGM63MQ05d0bUURt8bctDqeHtLwtWq?=
 =?us-ascii?Q?P2iKjtbptmeiUVfEd6EG6j/+FAiHOfuQYO+ajhOrPLzsb43pKOvX5+U8CsOg?=
 =?us-ascii?Q?ZQxDlHxAzGwgZk23bL42sAcR24/KZG9KlrEmwGh6zbB4lcSnHvbUGpLhLQlT?=
 =?us-ascii?Q?fPmlJ56HUxjp/F0cLaQcstsbzjle4RNq+Hheb8677Q+p9U3CpndzAgA3/7by?=
 =?us-ascii?Q?/AjyANhGK4rTeOzER9BVCzbHVLn+ddeRo4WIvTj3Goknw09q0GghwwIYWC6y?=
 =?us-ascii?Q?2cRUnds/P/gklTt3Ew3rglIUzb6OFoHfVMqDLUmQeCnQeaqVp5OPol587wBB?=
 =?us-ascii?Q?rhtEvVHIL3iQ2XlXSzt0Z6GVuA+SVRm2MX7Z9WaoyzfCshTT4pTDqF4L9n2t?=
 =?us-ascii?Q?bTmJVxPRfKRKE/k2SK9mXYP5i6Mhj8ylKZMDbpU5gMH2NiqYTX2SHaQUX0ql?=
 =?us-ascii?Q?kA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a5148dbd-4c40-416f-1ec9-08dc475779cc
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5782.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 14:27:01.3500
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5ZFYaGpTZC2jLF5AY293+Me3G5l//kDNcz9Jc+5Ik7SdRO0GdHcgMyfLr/U3zLtcGXvybaNd5QRTffjOJVpM7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8381
X-OriginatorOrg: intel.com

On Mon, Mar 18, 2024 at 09:29:46PM +0800, Jijie Shao wrote:
> From: Jie Wang <wangjie125@huawei.com>
> 
> Currently, hns hardware supports more than 512 queues and the index limit
> in hclge_comm_tqps_update_stats is wrong. So this patch removes it.
> 
> Fixes: 287db5c40d15 ("net: hns3: create new set of common tqp stats APIs for PF and VF reuse")
> Signed-off-by: Jie Wang <wangjie125@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> ---
>  .../ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c  | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c b/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c
> index f3c9395d8351..618f66d9586b 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_tqp_stats.c
> @@ -85,7 +85,7 @@ int hclge_comm_tqps_update_stats(struct hnae3_handle *handle,
>  		hclge_comm_cmd_setup_basic_desc(&desc, HCLGE_OPC_QUERY_TX_STATS,
>  						true);
>  
> -		desc.data[0] = cpu_to_le32(tqp->index & 0x1ff);
> +		desc.data[0] = cpu_to_le32(tqp->index);
>  		ret = hclge_comm_cmd_send(hw, &desc, 1);
>  		if (ret) {
>  			dev_err(&hw->cmq.csq.pdev->dev,
> -- 
> 2.30.0
> 

Thanks,
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>