Received-SPF: pass (google.com: domain of linux-kernel+bounces-106237-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <2b5e831b-baf1-4681-b3b1-b223df07ab83@gmail.com>
Date: Mon, 18 Mar 2024 08:42:46 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [BUG] selftests/net: icmp_redirect.sh: 12 out of 40 test result
 with [FAIL]
Content-Language: en-US
To: Hangbin Liu <liuhangbin@gmail.com>,
 Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
 linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
 Po-Hsu Lin <po-hsu.lin@canonical.com>
References: <dfb4b2fa-1728-43f2-ad73-f06145399fc9@alu.unizg.hr>
 <ZfepK3xItcv3ARVV@Laptop-X1>
From: David Ahern <dsahern@gmail.com>
In-Reply-To: <ZfepK3xItcv3ARVV@Laptop-X1>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 3/17/24 8:38 PM, Hangbin Liu wrote:
> Wild guess, the last change of icmp_redirect is my netns update. Maybe
> there are something default sysctl settings in netns cause the error?

It is most likely sysctl settings. It would be good to chase those down
and make sure we have the script setting them.

Mirsad: What OS are you testing with? That script has a verbose option
(-v) to get more output like the commands run and pause-on-fail (-p) to
manually debug at that point.