Received-SPF: pass (google.com: domain of linux-kernel+bounces-106262-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <10919f69-4008-4156-88e4-3c72e3775562@amd.com>
Date: Mon, 18 Mar 2024 11:06:02 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, linux-kernel@vger.kernel.org,
 avadhut.naik@amd.com, muralidhara.mk@amd.com
Subject: Re: [PATCH 1/4] RAS: ATL: Read DRAM hole base early
To: John Allen <john.allen@amd.com>, bp@alien8.de,
 linux-edac@vger.kernel.org, tony.luck@intel.com
References: <20240314163527.63321-1-john.allen@amd.com>
 <20240314163527.63321-2-john.allen@amd.com>
Content-Language: en-US
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240314163527.63321-2-john.allen@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UCtVMUdXcnNtcXNDNFFnUTBjTjlGaURuU1NxbkxMK2QzK2htaXFXMmlpR0pQ?=
 =?utf-8?B?MGxQWDQvVGtRRTVPTE1yNDk5SmFBSHpzMnBJNGp2ZmRaR1NKZnJmOTVFVGJs?=
 =?utf-8?B?Um0yM2t5eDBjUzUrbXZITDhjSURkaTdZbCs1Vk42NjdaZlA3WXNRak1xNWRQ?=
 =?utf-8?B?UzVnYkZjbDFBS1BKRGh0eWRmbWZhalFFYk4rc1J4UFFSRWI4cEFpQU8zalNr?=
 =?utf-8?B?dEh3Sy9jZGh5QzBPallVdTE5QXFGWlh0MW0wRm54OUdTNCtCVlFBVW9GQnlU?=
 =?utf-8?B?YjNaSGlpWnRpZGdOMWtJL001U2dGRVZsdTFSUmlobGNOTC9RQVRhUlFFaTFX?=
 =?utf-8?B?VXUwbDBvelZrWklUTzMxSzB6dWN3SEZpanZQd2dOemxoT0daWS9KS3doNjZo?=
 =?utf-8?B?RUMrZWwrUzZpT2RUMVZxUWMyN0srUVo0U09FMG9JYXp0TU4xRk5Qbm90R1Ri?=
 =?utf-8?B?NFhhSE44Vk1veFdGYTJWQUFQRDdwYWhIL3ljZURhR2g4blo3U243eEZ2YU0z?=
 =?utf-8?B?bFVNOHgvZnVLSmFpWCtrNnpIRnhLY2Q4cVM2SHZBcnM0aEFqcFVmbU9tdm15?=
 =?utf-8?B?YmkrNGR0NmhzMFNJZmRET2grb2Y5YWN1MnUrYWl2QXpNWWwyYnFFaW5OaE5m?=
 =?utf-8?B?SjZyRWJhSW53MWV4ZkJXRzN0aEpRdWtLWlEwc1RSL0JRUEtXVE9qUWJXeHNE?=
 =?utf-8?B?RWJEalNwb1lkY3kvNWZ3RzI5bXlualZPR3YrU3B5TTlROTFQYURYeFh2OVZX?=
 =?utf-8?B?YnprY3dweWw4WHh3SEw4eFVBeG5EZUVDbHRobHFMeU81dVpqVUhiTVU1dFcw?=
 =?utf-8?B?eVNjOU5WSEp6ZElsZ1JyeFEvdnRXZWdxdzB6VUw4a3phQ2xxZDU5c3dWcTk5?=
 =?utf-8?B?elY2dGNNbGl4RUgwSjM5c1pPWURwN0FkRjBmaGhDS3BJTlFzQ0o5YmQvVUla?=
 =?utf-8?B?VjFNdGFIekhoUE4wWmZSWW5uR29YSzRHRnV3VTlLVWdLS1RpbjFWMVdDZjNS?=
 =?utf-8?B?djJXVWVKMlBjeGl6UmY4cGtpRU0vaGRSK3VTQUw3eWR4bEh1VE5YeUhuR29Z?=
 =?utf-8?B?Y1pCMGs2Z0tiSDRSUVZPMGJIYWtRV0tQYTdwWWxLVVZsNmVoUUhBVnBDNEpX?=
 =?utf-8?B?TllnZmV3c296UC9lL2RjdnZvdmdKcGNIK2oySENGVGZCYTBiaExhWkJzNzg4?=
 =?utf-8?B?RG9nU3k0NzFDSVpReUJ0clYrMHFjTWR4eC9kc1dTZ1Zrb1pGWllZb3J2ZXJN?=
 =?utf-8?B?N014ZjBKc3BZT1IwZC8wWDFXMHljdlJsNVRvd3A5Wk1NUytESVpjSUV4UU5q?=
 =?utf-8?B?cld2dDBEdDk4QjB2M0lwUHVqZVFYdlgrRTJGTllGeW83YjJpaUNsMUNpQnh1?=
 =?utf-8?B?bSt3eTJzMFpHWjgwOVY2WUZ0dHFDVXg4VTJuVkZnaG1LYWc2cmRQUU1wMWF0?=
 =?utf-8?B?UnkwNzZXVXl4YjAybjlTMVFhemRVS3FIaFZSSzlHdGNNa3E2UGN0a004TDY1?=
 =?utf-8?B?UDR4Wk1XYWxHaXIrcFBTVnRYRVhEaHdGcXdIcFBkaGFKUDRra3RCZVBxZWQ1?=
 =?utf-8?B?YldkWU5SN1RiWlAvVi9zNEdPZ2NtS0ZYakttOUNNdFdDQ2xic1d4cWNCbk82?=
 =?utf-8?B?Qmp4ZUtQUGdpb3N2ai9HYllneHNoSGoycFdIRlFCRHhseHkwa0FQVjkwdDNk?=
 =?utf-8?B?YnVaSkg2bzF5TCtmbjVJZXRWVXIwR1J1b0VER1NEdFZLWFVBTU1FV05DSGs4?=
 =?utf-8?B?Tnp1aWtLRnI1bXQzaTFEbXdqY0NiNlJCdytSZ3hXTjZNK3ZLZ1UxQklpenZ0?=
 =?utf-8?B?bjVZTXQrUlJleW9OMy9Cc0lrRlh6WWkyOTBVd05XMTVtSXhwK0p3a3A1VWRM?=
 =?utf-8?B?ajZ3L3JnWVVaYkdPTzB0b3l2NXd0WWdic016dlVUdWs0SlRuU04welFoWEVP?=
 =?utf-8?B?U09ZZjMrekJVSzNnelVUY1NEZHFZVnJSZjMya243Tlp0dDd6RStXeXE0VUxw?=
 =?utf-8?B?VWNJZlBaMk15WUxQVXZsWjliUXhrd1lOL1RlY3A3cHIyeUZSRDc3MnFGS3Vh?=
 =?utf-8?B?TFZBSmZHbDVXS2poSzdON3FpS05kOE8rRCtHdmpWR2VwZ28wVVU2SzVoWUg5?=
 =?utf-8?Q?Z0VaEaPfLNW5ztUNKq+vKVQ4y?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bcf1705-441a-495a-a00a-08dc475cef83
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 15:06:06.3497
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lDGdKWqpJN61j0sJWUS4aFoydZi+Pyit3iyZiIS45BeFe7zRTylxlvEL/Lbikf9qYHPisv703MpbDxLumfOADQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6370

On 3/14/24 12:35, John Allen wrote:

Please use "RAS/AMD/ATL:" for the $SUBJECT prefix.

> Read DRAM hole base when constructing the address map as the value will
> not change during translation.

More specifically, the value will not change during run time.

> 
> Signed-off-by: John Allen <john.allen@amd.com>
> ---
>   drivers/ras/amd/atl/core.c     | 15 ++-------------
>   drivers/ras/amd/atl/internal.h |  2 ++
>   drivers/ras/amd/atl/system.c   | 21 +++++++++++++++++++++
>   3 files changed, 25 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/ras/amd/atl/core.c b/drivers/ras/amd/atl/core.c
> index 6dc4e06305f7..c1710d233adb 100644
> --- a/drivers/ras/amd/atl/core.c
> +++ b/drivers/ras/amd/atl/core.c
> @@ -51,22 +51,11 @@ static bool legacy_hole_en(struct addr_ctx *ctx)
>   
>   static int add_legacy_hole(struct addr_ctx *ctx)
>   {
> -	u32 dram_hole_base;
> -	u8 func = 0;
> -
>   	if (!legacy_hole_en(ctx))
>   		return 0;
>   
> -	if (df_cfg.rev >= DF4)
> -		func = 7;
> -
> -	if (df_indirect_read_broadcast(ctx->node_id, func, 0x104, &dram_hole_base))
> -		return -EINVAL;
> -
> -	dram_hole_base &= DF_DRAM_HOLE_BASE_MASK;
> -
> -	if (ctx->ret_addr >= dram_hole_base)
> -		ctx->ret_addr += (BIT_ULL(32) - dram_hole_base);
> +	if (ctx->addr >= df_cfg.dram_hole_base)
> +		ctx->addr += (BIT_ULL(32) - df_cfg.dram_hole_base);

There is a compilation error here. Please make sure to build each patch
individually.

Thanks,
Yazen