Received-SPF: pass (google.com: domain of linux-kernel+bounces-106284-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 18 Mar 2024 20:48:39 +0530
From: Dhruva Gole <d-gole@ti.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
CC: Ulf Hansson <ulf.hansson@linaro.org>,
        Adrian Hunter
	<adrian.hunter@intel.com>,
        Tony Lindgren <tony@atomide.com>, Len Brown
	<len.brown@intel.com>,
        Pavel Machek <pavel@ucw.cz>,
        Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>,
        Viresh Kumar <viresh.kumar@linaro.org>, <theo.lebrun@bootlin.com>,
        <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 2/3] PM: wakeup: Remove unnecessary else from
 device_init_wakeup
Message-ID: <20240318151839.okplnfpakp5y5lxj@dhruva>
References: <20240318055054.1564696-1-d-gole@ti.com>
 <20240318055054.1564696-3-d-gole@ti.com>
 <CAJZ5v0hP0TR1zVc1hNMw+SnqCw7hJUcFM-J5Y6Mtgh-tnrrdEw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJZ5v0hP0TR1zVc1hNMw+SnqCw7hJUcFM-J5Y6Mtgh-tnrrdEw@mail.gmail.com>

On Mar 18, 2024 at 14:52:02 +0100, Rafael J. Wysocki wrote:
> On Mon, Mar 18, 2024 at 6:55 AM Dhruva Gole <d-gole@ti.com> wrote:
> >
> > Checkpatch warns that else is generally not necessary after a return
> > condition which exists in the if part of this function. Hence, just to
> > abide by what checkpatch recommends, follow it's guidelines.
> >
> > Signed-off-by: Dhruva Gole <d-gole@ti.com>
> > ---
> >  include/linux/pm_wakeup.h | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/include/linux/pm_wakeup.h b/include/linux/pm_wakeup.h
> > index 428803eed798..76cd1f9f1365 100644
> > --- a/include/linux/pm_wakeup.h
> > +++ b/include/linux/pm_wakeup.h
> > @@ -234,11 +234,10 @@ static inline int device_init_wakeup(struct device *dev, bool enable)
> >         if (enable) {
> >                 device_set_wakeup_capable(dev, true);
> >                 return device_wakeup_enable(dev);
> > -       } else {
> > -               device_wakeup_disable(dev);
> > -               device_set_wakeup_capable(dev, false);
> > -               return 0;
> >         }
> > +       device_wakeup_disable(dev);
> > +       device_set_wakeup_capable(dev, false);
> > +       return 0;
> >  }
> >
> >  #endif /* _LINUX_PM_WAKEUP_H */
> > --
> 
> This one is fine with me, but not 6.9-rc material.

OK, I completely understand.

-- 
Best regards,
Dhruva Gole <d-gole@ti.com>