Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp307169lqt; Mon, 18 Mar 2024 08:23:10 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXwgyP4rGEpRGfR+mcBN0a12lKLa/qFxz+/YJJi/Eekityjlj0DKFgtLsogNBfePS+G/thyupo+0ieKNbhrKiM9eDEgSgAsk3ztzkWwvQ== X-Google-Smtp-Source: AGHT+IGrOGHdvQZPeOzkf/Mm6hEfkrBzUNWjDNCgw90Xbm4VdQeMcdohPp1RMseSlsh+1dxiUkn0 X-Received: by 2002:a05:622a:13c6:b0:430:b9de:9c4c with SMTP id p6-20020a05622a13c600b00430b9de9c4cmr9415865qtk.16.1710775390254; Mon, 18 Mar 2024 08:23:10 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710775390; cv=pass; d=google.com; s=arc-20160816; b=Ds6XMh/T39uT4N7VMLaKJH8LekdXgIeC8oIzqdjfCq/Knh+gbu5U66BsTIgh01nxEl o6ldThyS+VLxCNztJq3cfa9DNe9ivgbSMakZZffCFrA0KjvjPRj8pYF4Y/epCCEiL97q 9wAckRZKicfSbkG9Lsvr3MwcNpSPxd7Mys/L3X5jE8MvbYRjw1C1TjjF9ePeyKtBf/WI t78dXBs/uqY4IYRTpBxrhQp6fINJ+2fLb0BfUtbF3BvzBtJJI9AgKrnpAKAJcfNUgOKw MGp0As9sEYHx9BH4ZFiA34+azq3SB8AAaiJAmTvk54PHwHAGVjpQfNkeM19yp2hGwy0X wUaQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=eM5Vyp4val6gHlW4UCse9Nuq31PUAHMp+cCr8q2taE0=; fh=bt8MYHKlNe1+Vky+lpKWTMdNQWalmJ2H/IiU/hqObyU=; b=z1P58lS2xZAfXHWfhcRqotsxQAUc9rH1tdZBODGGgVKylv4ybntEB4i++AQMmtaqWj JTxTB4PEhokwrNEKraBQUm+DdvnZPqhyLNhU0C0url4cE/JDvGvJNWhlTjFjkuZxuoBJ F+8z5D4zMfg4IIt61AySmT5bOL9tUYbD4dGtKf9JPUQe5RkiXONLKTNStpal4sQF6hQA grRrlczMXYbzbAVkAzPKIANYm1d37iMchs5IxeF2mnEBNJsSLna0Fv4Q+AzqXPxZTmyU ZWX6MrpR3/6PB1qZ6Os4jdb9+fIeS4nkts6/6WbFryEKwV+xsJCAXKzzDL7qHOrMfvjV DUFA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iSxH6qYY; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-106290-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106290-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d19-20020ac85ad3000000b00430b90b3dccsi6131961qtd.0.2024.03.18.08.23.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 08:23:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-106290-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iSxH6qYY; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-106290-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106290-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id F3FBF1C21187 for ; Mon, 18 Mar 2024 15:23:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D55044F1E3; Mon, 18 Mar 2024 15:23:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iSxH6qYY" Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 638D74F1F6 for ; Mon, 18 Mar 2024 15:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710775384; cv=none; b=cqTIiQXcXL9CJ4omhn5rqoApQSUFgDSvW/PcPzx3E4i4mnx0UAqxgib5APJA7niAjuDpSHXOL+MK2YsfIsvv2gL6TT2pJBRJsWrV+u4cmpj9CFzXGOoP3zkybgQII+5RTG8/LzabG6tCm5JsoEbAdDGwkkCE6dOtEA5M5IrHjH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710775384; c=relaxed/simple; bh=MChX38X33+qCYxehnqOCzQXAVNjcuSCivllsMiwyntQ=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=Bpywp+/lEYoEfGpgjXZa7SjnjLPhd0maPnxG1f7XvI8gwN/vApB4DSqgrID850D9mTt5UTCZ6kNuCHCRCFC0sQYc25rMHdZEsBBkXToTKEQEIhVhyP8P1sf40ODE8VVnMVv7UMqlNVTryoQgnlZtEDu/2Of2nXHwMtXjn7eiNig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iSxH6qYY; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-41400a9844aso16414305e9.0 for ; Mon, 18 Mar 2024 08:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710775381; x=1711380181; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eM5Vyp4val6gHlW4UCse9Nuq31PUAHMp+cCr8q2taE0=; b=iSxH6qYYppBbIIm6hBr0J1R5051YnzDvSpRQez0gJA00LdxiH3rCPBuNjTeFjHil0j jq0tZRR73H8NOiaaSgtBTbqoCL1DQjBEph+fsIyU5fRoJ2PotgXZt8AMu97WT8gnOAUK PgDhEoAjm91E1Qg7qwxFBH4QycS//g7vO/i7jJ01qSPsV+/pk8xHCtssrZtafP6dpn1z a4rMCpNwQcBBc35AEX1sXk+uPMtsDYacr0uJdJGAfBsSgJ4xZ1tOhRs1YY2PpD2SEcoC nMKzzTT5BonYGR2i/qm8EvnUzBYhzjEET5q/RiXLO4p5K0mfREqSU9FySUvZ6+E6frGf Veeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710775381; x=1711380181; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eM5Vyp4val6gHlW4UCse9Nuq31PUAHMp+cCr8q2taE0=; b=kOrPFxkDa5j/Mg6oHC9h3WD+nM119QRfK+g1ZQVzlVyEQd3SedTwtR7S4wiYlZTYoy 0Pzfe4CeJzdYmYg/X7csyN7HRRT32cwqu0yscu9xlR/QQRhqNJRmi0Aa5ZUMf/gFuM9j vyCMNosMGwclDjpXzOXCyXmrT4GvU4ZqxxG8MiP/ZMnZsVdAjv/8M/acgVwfAnymGT+t dRH0wBETTadXhXkWKFPc8F/h7RT+d/aIabchgLeX5u/nNxjW/3sxAnGaHCuTAJFEqWiI xRbvkuyjv99AunRG6LncRTcsi6/rRY3rykCcaA9rN/uqfSl9Iq6X14B+rNkO4SUQoHuY zDaw== X-Forwarded-Encrypted: i=1; AJvYcCU2Uz/6R3sQuDQ7Hhwe8rlCifETXmNKEfqUXoyNGSdacdBeqYeve6zPhqXyvN7C1p5oXtKef1f/kaL+CEZJl2ba1ZjDfIfaM8HocENA X-Gm-Message-State: AOJu0YwXm3yo81k1OT0FBr9kkEGpbK4Ae1CLDOQgTP/OJxQuxfVPZkpW hIUpvmeosLiRJTtLyiy5MUbJLaXfdi1+8czOE6gjb4zuwN8rpVNIE3DkniFmevA= X-Received: by 2002:adf:f68e:0:b0:33e:9f16:33c with SMTP id v14-20020adff68e000000b0033e9f16033cmr10363269wrp.18.1710775380663; Mon, 18 Mar 2024 08:23:00 -0700 (PDT) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id g6-20020a05600c310600b00413294ddb72sm15047500wmo.20.2024.03.18.08.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 08:23:00 -0700 (PDT) From: Neil Armstrong To: Phong LE , Sui Jingfeng Cc: Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org In-Reply-To: <20240316160536.1051513-1-sui.jingfeng@linux.dev> References: <20240316160536.1051513-1-sui.jingfeng@linux.dev> Subject: Re: [PATCH] drm/bridge: ite66121: Register HPD interrupt handler only when 'client->irq > 0' Message-Id: <171077537978.2168000.7565900207355472778.b4-ty@linaro.org> Date: Mon, 18 Mar 2024 16:22:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.4 Hi, On Sun, 17 Mar 2024 00:05:36 +0800, Sui Jingfeng wrote: > If a specific design doesn't wire IT66121's interrupt signal output pin up > to the display controller side, then we should not register the interrupt > handler. Such a decision is valid usage, as we can fall back to polling > mode. So, don't make the assumption that a specific board always supports > HPD. Carry out a sanity check on 'client->irq' before using it, fall back > to polling mode if client->irq < 0 is true. Such a design increases the > overall flexibility. > > [...] Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/bridge: ite66121: Register HPD interrupt handler only when 'client->irq > 0' https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/ba2d3e6709681b6c16ba8d65a23d72c706d82b5c -- Neil