Received-SPF: pass (google.com: domain of linux-kernel+bounces-106328-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <893141c6-41f8-415a-a1a3-d3e4267ec333@amd.com>
Date: Mon, 18 Mar 2024 11:46:39 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, linux-kernel@vger.kernel.org,
 avadhut.naik@amd.com, muralidhara.mk@amd.com
Subject: Re: [PATCH 3/4] RAS: ATL: Add map_bits_valid to header
Content-Language: en-US
To: John Allen <john.allen@amd.com>, bp@alien8.de,
 linux-edac@vger.kernel.org, tony.luck@intel.com
References: <20240314163527.63321-1-john.allen@amd.com>
 <20240314163527.63321-4-john.allen@amd.com>
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240314163527.63321-4-john.allen@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NXhmTExWWE5UZmpXd3dxemdMTWo1d3oxWG9LWlZlTXZhc1Y4TjJrK3lhQVpC?=
 =?utf-8?B?R0JjZDNPRDMxWE1qTG5SR3NJMHpwdno1cmU3SUw3UGYzMWdmeGJ3VlhqbzMr?=
 =?utf-8?B?c3JMdnJnNlR6eFR0UEN0MkU1VFJJSWFyZFNHL0pRZGdRT1VjL0VRT0Q1UjhV?=
 =?utf-8?B?bms2cU50SEJ5UVgyYkJEd3NFWmN4Q3dZNHJydTVkQVkrSDlzb2ZtT0JUWkJ2?=
 =?utf-8?B?cFpsM2FMTU5hSGVSemR6dHdlWm10TmVtQ092UlpCVFdaVnlnRmZIVzVTeWhk?=
 =?utf-8?B?eUlsRDlFbENMVTRqdmRSVGdXd2djUVRVOVM3VHcyZEl1MnJ6cmNpblkxK3Vs?=
 =?utf-8?B?WGY5U0FTdmtBL3B5VXloTnlVNWlrNE1mM0J5TmlkTnhrMXBxUk00M016MEhv?=
 =?utf-8?B?NWMydzB1SEw5bTlRUU5JblMxNjNpbENybU0xelJDcjl1UDFYdTg5dDU2VEsr?=
 =?utf-8?B?YjlIK3RPY2dQcmtvYjJnUG1iOWlldzJRdXRNWno0KzNZYmU1cnVtdlZzTmZ3?=
 =?utf-8?B?VUZBeUhOYjBDdm9zQ0RtbG5MZkE1Qmo3dGxIZXJvdTBjVUlqR2o0YVU2ZGhu?=
 =?utf-8?B?ZWNiUU1lUTNRd3krUm5qQkxzd2RZRzY3Um84T3FXV1U4Mkx6WlJFeFV2SnlJ?=
 =?utf-8?B?bWVoSUZBZXV4RzFLbVFsZEZadEdNNGhmWDdteUFSVU0vVmZZUzM3YTMxdHBU?=
 =?utf-8?B?TUpHSmFBZGJvWmdjcDZOWUNPeUdLSGhQcW5GOEQxTFRtSk5tNjFDVW9PamN1?=
 =?utf-8?B?LzJVM2oxTzhyWG02M2NyMXFvWXIvTC9xRGFBVXZuNkYwZ2FJNys1ZVNDRGJh?=
 =?utf-8?B?eWJ3VHp4alc4eDZpMDdncnh5eGczL1BRWGtkY0NQcnpPL0hUSjFwRmh3ZlJi?=
 =?utf-8?B?eHltUEc3Q1BTY2dTRHZUamJpWlNUb3lMSmpQakoyb2sxL0VOV3l6cWhRS0p3?=
 =?utf-8?B?bVFWR2NOckUyWFhjOGwxRlVrZ0lITnJyMzdVQ1RPVkdveW9aQ0dEL1FtTTZs?=
 =?utf-8?B?QTdLU21VODQvVTNuVGN4MG9nQnNBSUhHRzg4UlJpWkQ1YU9TODV4dFRRaGJn?=
 =?utf-8?B?ZlJWeGw2U09sNmMwdTY3RTNBaTJDTjhOazA4dVc1V0dZeG9RTHRjV3NrbUJa?=
 =?utf-8?B?NmhHNUZ5eHNrdWxaUXltbmtzRFBUMmlaRGIxRjBGYlA2SnhxamlDbXRadFh2?=
 =?utf-8?B?eUQydFgvN1dEZlRreFRwVHNNRXpTU05tTU0wSnhKbldZTHA5REY3Mjl0WTJN?=
 =?utf-8?B?RHY5K0ZUNU9nQ05Sdy95bjMwYVY5VXc2dVVpK2JuWjBPT0FYalRRTGFvSVJJ?=
 =?utf-8?B?MGpxVEp3Vlp1czdidWZCcGNWTEFmWVZjWFBPY0NQRUcwcDlBc0RNaHpJU0Ix?=
 =?utf-8?B?YVVTOW50a25lOFFzbFJhdXgwZ0RueDFxeENHNXdWMVhwT05sY0dTNnFWcEtZ?=
 =?utf-8?B?T01NQWRDUVh6aFp4ZG5taGQyaFVZTFNMdHR2azJWODJ6NUViSjBCN3lKdHox?=
 =?utf-8?B?dDNheHNCM3F0dC8veG94djdKMFV1TlY3d2hBaVVHVXR6NDJZcHFjdGFJNnhK?=
 =?utf-8?B?bEZQaU1ZR1k2dE9zajdBUnd2enFCNC8vZ2tnSDJQcHBRV3RLb0g2MXpSK1Rm?=
 =?utf-8?B?Myt2N0xKalVjTEZjdEI1c3huSjB3RDJJcytoS1luSHdwTjV2NXJZdHBkUzN6?=
 =?utf-8?B?cWNyNDZYa1p6NmdCajJMUEN2SDJHSFRQTThCTGxTZmE2NEJvL1ovQlhBMkZ4?=
 =?utf-8?B?YlBWRVFVaFlJRjVKbUJ6aEtmY1V3ajRHb1V5eUNCaE9iaVUvZVdubkk1dEov?=
 =?utf-8?B?bzVJR0lHQXlLRzkzZDhST0FmVVNsL2R3MGVpL0JqckYzK294QTdjazI4NEFv?=
 =?utf-8?B?RC8rc2xmSFhIOHVQdTZWT2FBQldvUGlFZ3FNeW9Oak4wK2YxUzJuVjVGSXFI?=
 =?utf-8?B?S1BzMEt6eWFFVkF3ZlFQRWVVYVVwR2dsZzN0N0oxdVE5dWovZzl0c1IyeHFW?=
 =?utf-8?B?MkR2N3Bta3cvdTRKdXpjek5TdGNhL1hTSUhNNlI5TlI2R2xyY3JvYTdtb3Fr?=
 =?utf-8?B?c0tmaEZiaG1lK0NwbXhjNjBEVGxTRFlTRTdObjhaMmowMkhpdG9SdEd2dm9H?=
 =?utf-8?Q?xMJJjpx7HEBmmzSiP/WBH0X49?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ecf0c62-8448-4851-cc06-08dc47629bbe
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 15:46:42.6481
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vImc4rj12zOm+JJ6hSOpXTk1vUkKfEW+tWdJTbKwPphNYalte1zs1DgiMaxXIRtTiYuAuNfkuGrIYn26/6kMOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6578

On 3/14/24 12:35, John Allen wrote:
> Make map_bits_valid available in the AMD ATL internal header as the
> function can be used in other parts of the library.
> 
> Signed-off-by: John Allen <john.allen@amd.com>
> ---
>   drivers/ras/amd/atl/dehash.c   | 2 +-
>   drivers/ras/amd/atl/internal.h | 3 +++
>   2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ras/amd/atl/dehash.c b/drivers/ras/amd/atl/dehash.c
> index 4ea46262c4f5..a20cf615b83a 100644
> --- a/drivers/ras/amd/atl/dehash.c
> +++ b/drivers/ras/amd/atl/dehash.c
> @@ -19,7 +19,7 @@
>    * If @num_intlv_dies and/or @num_intlv_sockets are 1, it means the
>    * respective interleaving is disabled.
>    */
> -static inline bool map_bits_valid(struct addr_ctx *ctx, u8 bit1, u8 bit2,
> +inline bool map_bits_valid(struct addr_ctx *ctx, u8 bit1, u8 bit2,
>   				  u8 num_intlv_dies, u8 num_intlv_sockets)
>   {
>   	if (!(ctx->map.intlv_bit_pos == bit1 || ctx->map.intlv_bit_pos == bit2)) {
> diff --git a/drivers/ras/amd/atl/internal.h b/drivers/ras/amd/atl/internal.h
> index 05b870fcb24e..4681449321de 100644
> --- a/drivers/ras/amd/atl/internal.h
> +++ b/drivers/ras/amd/atl/internal.h
> @@ -239,6 +239,9 @@ unsigned long convert_umc_mca_addr_to_sys_addr(struct atl_err *err);
>   u64 add_base_and_hole(struct addr_ctx *ctx, u64 addr);
>   u64 remove_base_and_hole(struct addr_ctx *ctx, u64 addr);
>   
> +inline bool map_bits_valid(struct addr_ctx *ctx, u8 bit1, u8 bit2,
> +			   u8 num_intlv_dies, u8 num_intlv_sockets);
> +
>   /*
>    * Make a gap in @data that is @num_bits long starting at @bit_num.
>    * e.g. data		= 11111111'b

Ultimately, the maps should be validated as soon as they are gathered. I
figured we would do that later. But that would wipe out this change.
And, after looking at dehash.c again, map_bits_valid() isn't used in too
many places right now.

So I think validate_address_map() from the following patch should be
done for all modes first. That way we don't need to add and then remove
this function from the header.

Thanks,
Yazen