Date: Tue, 8 Jan 2008 14:47:02 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Michael Halcrow <mhalcrow@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, ecryptfs-devel@lists.sourceforge.net,
       thighlan@gmail.com
Subject: Re: [PATCH] eCryptfs: Load each file decryption key only once
Message-Id: <20080108144702.a5c0624f.akpm@linux-foundation.org>
In-Reply-To: <20080108211733.GD10989@localhost.austin.ibm.com>
References: <1198289130.8560.14.camel@buster2>
	<20080108211733.GD10989@localhost.austin.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1232
Lines: 31

On Tue, 8 Jan 2008 15:17:33 -0600
Michael Halcrow <mhalcrow@us.ibm.com> wrote:

> On Fri, Dec 21, 2007 at 08:05:30PM -0600, Trevor Highland wrote:
> > eCryptfs: Load each file decryption key only once
> > 
> > There is no need to keep re-setting the same key for any given
> > eCryptfs inode. This patch optimizes the use of the crypto API and
> > helps performance a bit.
> 
> There is no reason for the crypt_stat->key value for any given
> eCryptfs inode to change during the life of the inode, and each
> crypt_stat gets its own crypto transform, so I do not see a problem
> with Trevor's suggestion. It will save unnecessary calls to
> crypto_blkcipher_setkey(), and I expect it will speed things up a
> little.
> 
> I include an updated patch against 2.6.24-rc7.
> 

Your new patch clashes horridly with the pending
ecryptfs-set-inode-key-only-once-per-crypto-operation.patch.

I shall drop ecryptfs-load-each-file-decryption-key-only-once.patch and shall
then sit back and sulk.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/