Received-SPF: pass (google.com: domain of linux-kernel+bounces-106375-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 18 Mar 2024 12:20:33 -0400
From: Frank Li <Frank.li@nxp.com>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: will@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, john.g.garry@oracle.com, jolsa@kernel.org,
	namhyung@kernel.org, irogers@google.com, mike.leach@linaro.org,
	peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, adrian.hunter@intel.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	imx@lists.linux.dev
Subject: Re: [PATCH v7 2/8] perf: imx_perf: add macro definitions for parsing
 config attr
Message-ID: <Zfhp0beAtsYtaNn7@lizhi-Precision-Tower-5810>
References: <20240315095555.2628684-1-xu.yang_2@nxp.com>
 <20240315095555.2628684-2-xu.yang_2@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240315095555.2628684-2-xu.yang_2@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?CNufahuKI5mjv5WdKT/aS8Sq/bO6RK8FAYwvoMzV1naecFo+UY+gv1GVNzWR?=
 =?us-ascii?Q?0BK1YxLTY2Ie88xwCG1j+SAxZvXeADvtzSxcVQqb8woRsONHe5ev2s/2AiXb?=
 =?us-ascii?Q?8voOUCsaBM6YWlO+HhmxjIfSuCIO9ppxwmSmnPP7kaztfzVq03ZBRPZZP3wR?=
 =?us-ascii?Q?f6DcuqZSA5BiNDE3kLhNVPovKxqjESdQL7FTIgeG+ph3k2mzNprD6YWZ/QB4?=
 =?us-ascii?Q?w9nblYCmXlEKaMZAbNKg5OgUpHCh4rBLT65ux+TuQL6Hq44e+S6H1wLJi4rN?=
 =?us-ascii?Q?N74ecWZVCM6EHpn/DEeWyoY1jDJiulcqExLY9VSPvA0zilU9meV0KEyCq1+D?=
 =?us-ascii?Q?Wkl65sue38QB4GE6o2ulOrlY4/EKIQ91iGSx9Kh+ebFS7UyTvXiu66nlty8o?=
 =?us-ascii?Q?xQfFFpxLopgsnD1OHV0GnUYMB8uDjVGu6EVzWOht/g2uMFNySDXcV3APprAP?=
 =?us-ascii?Q?ddIkY8EKxo2fdm1mRlYKjq8oa9ii45A/uMN+urj6RJRGrtyK325Bhmn0a9jt?=
 =?us-ascii?Q?9J6KMQzoJzvsXbM3X5RHnvHxaJF7lDUGbBhsluUFy4UWIq0wAJwgSpYh2fI1?=
 =?us-ascii?Q?5YnWGWmraG+KYPY0pU5n4k0wOvSpItnclUYY3aq36ccPbbwQoGC3sdDXt0aV?=
 =?us-ascii?Q?5HCXdGUUSgS8wY0wF5YKLfTOmzq0NKE0+s54rsDSLrE0ojJOOuzgju0xxPLS?=
 =?us-ascii?Q?mPSDOPfA7Lk7F3KLViblYDoI+TejJqPj/NesCgkH4HUn+fuhCJ78H2L7zAzU?=
 =?us-ascii?Q?EyTBt6ZymBnmRoNBPTb7q1ALp+rOAvhr7y6B7B8wUVJ6A5GBzXOD57rVs0//?=
 =?us-ascii?Q?KRpVIcRDgPXnid7rw7iHnWRvUKyuDqlBHczr4LohpRo1HgkAvTUNrtCEjL/e?=
 =?us-ascii?Q?FZYMq4QtEQp59p9JBMLdjYOlkuQAmN1/k9QQqCybui3V277n+83cTx2skW/n?=
 =?us-ascii?Q?7nlukCHEFl4JvX544vUc30nMTev/buDT3dPJcQkiXtHd3XXvfJPxclt6E67G?=
 =?us-ascii?Q?BLnhF1ucOAirWXYs9x75GSC5wncWWUTzmi8xrtYhQqXTMaWSlfsteC9wy3e6?=
 =?us-ascii?Q?V3HyUS09Y69W5PlvueOnhYGrM8V/duy9ktUb4MX7ByjwSZIRQy1COj46a4hn?=
 =?us-ascii?Q?75vcn8cVv0k6aIoIDbHgC5BQTs7LDV3Wlh/jnKAesiSUL1idKN1QoyiA37KM?=
 =?us-ascii?Q?ZnpCqHfyKmSxU9h8F5gjWcHV4fXsy0ZT6KzZMMJ9IQzsbhAVWDxYE6CIDPLS?=
 =?us-ascii?Q?BPcPjlZp7HamL1gbUaSLPjagWlHN67Khp0pDdqCEqirS8aJUKDAqu3r3DwVl?=
 =?us-ascii?Q?ywymSjPln5y7cpwwbKj/c++ZEMDlyPDuc3SmtBe8tU5Rqd7O2oyM5AU1HSo8?=
 =?us-ascii?Q?85vexlCi4YvG9Hfb//S7TSsvQk9iSENsaJznNNtlIy5yZt3uX6TSoeouew7l?=
 =?us-ascii?Q?eSVVCMb282p7gQzGk2RSNEVloRkhx2pSSCFxNaDwYmSZhm201JmI1ImiS7yZ?=
 =?us-ascii?Q?YH2Ct9+BrqBdCMIs/sWNKhB7g6BWrpA9X+NM1ELx92Gk3wOVregdKdnlaDw/?=
 =?us-ascii?Q?/K8IpGS1hDa6sQ/rI/xIeALORc9Ew3JLaCWEYfhA?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42a7edd3-ea81-4a69-5f27-08dc47675c11
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 16:20:43.3559
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /f/9vshXpIY97xGRlac7ZkUR8Gbk/HjyHyDX2YL6gssG7lsR1kV4M91dJW1Rql2CwkPrmHpyIMtMSxYmx7pfiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7324

On Fri, Mar 15, 2024 at 05:55:49PM +0800, Xu Yang wrote:
> The user can set event and counter in cmdline and the driver need to parse
> it using 'config' attr value. This will add macro definitions to avoid
> hard-code in driver.
> 
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> 
> ---
> Changes in v4:
>  - new patch
> Changes in v5:
>  - move this patch earlier
> Changes in v6:
>  - no changes
> Changes in v7:
>  - use FIELD_*
> ---
>  drivers/perf/fsl_imx9_ddr_perf.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
> index 9685645bfe04..4ec70775d1f0 100644
> --- a/drivers/perf/fsl_imx9_ddr_perf.c
> +++ b/drivers/perf/fsl_imx9_ddr_perf.c
> @@ -42,6 +42,9 @@
>  #define NUM_COUNTERS		11
>  #define CYCLES_COUNTER		0
>  
> +#define CONFIG_EVENT		GENMASK(7, 0)
> +#define CONFIG_COUNTER		GENMASK(15, 8)
> +
>  #define to_ddr_pmu(p)		container_of(p, struct ddr_pmu, pmu)
>  
>  #define DDR_PERF_DEV_NAME	"imx9_ddr"
> @@ -339,8 +342,10 @@ static void ddr_perf_counter_local_config(struct ddr_pmu *pmu, int config,
>  				    int counter, bool enable)
>  {
>  	u32 ctrl_a;
> +	int event;
>  
>  	ctrl_a = readl_relaxed(pmu->base + PMLCA(counter));
> +	event = FIELD_GET(CONFIG_EVENT, config);
>  
>  	if (enable) {
>  		ctrl_a |= PMLCA_FC;
> @@ -352,7 +357,7 @@ static void ddr_perf_counter_local_config(struct ddr_pmu *pmu, int config,
>  		ctrl_a &= ~PMLCA_FC;
>  		ctrl_a |= PMLCA_CE;
>  		ctrl_a &= ~FIELD_PREP(PMLCA_EVENT, 0x7F);
> -		ctrl_a |= FIELD_PREP(PMLCA_EVENT, (config & 0x000000FF));
> +		ctrl_a |= FIELD_PREP(PMLCA_EVENT, event);
>  		writel(ctrl_a, pmu->base + PMLCA(counter));
>  	} else {
>  		/* Freeze counter. */
> @@ -366,8 +371,8 @@ static void ddr_perf_monitor_config(struct ddr_pmu *pmu, int cfg, int cfg1, int
>  	u32 pmcfg1, pmcfg2;
>  	int event, counter;
>  
> -	event = cfg & 0x000000FF;
> -	counter = (cfg & 0x0000FF00) >> 8;
> +	event = FIELD_GET(CONFIG_EVENT, cfg);
> +	counter = FIELD_GET(CONFIG_COUNTER, cfg);
>  
>  	pmcfg1 = readl_relaxed(pmu->base + PMCFG1);
>  
> @@ -469,7 +474,7 @@ static int ddr_perf_event_add(struct perf_event *event, int flags)
>  	int cfg2 = event->attr.config2;
>  	int counter;
>  
> -	counter = (cfg & 0x0000FF00) >> 8;
> +	counter = FIELD_GET(CONFIG_COUNTER, cfg);
>  
>  	pmu->events[counter] = event;
>  	pmu->active_events++;
> -- 
> 2.34.1
>