Received-SPF: pass (google.com: domain of linux-kernel+bounces-106521-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 18 Mar 2024 14:33:58 -0400
From: Frank Li <Frank.li@nxp.com>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: will@kernel.org, mark.rutland@arm.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, john.g.garry@oracle.com, jolsa@kernel.org,
	namhyung@kernel.org, irogers@google.com, mike.leach@linaro.org,
	peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	alexander.shishkin@linux.intel.com, adrian.hunter@intel.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	imx@lists.linux.dev
Subject: Re: [PATCH v7 5/8] perf: imx_perf: fix counter start and config
 sequence
Message-ID: <ZfiJFj1IO67FR/z4@lizhi-Precision-Tower-5810>
References: <20240315095555.2628684-1-xu.yang_2@nxp.com>
 <20240315095555.2628684-5-xu.yang_2@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240315095555.2628684-5-xu.yang_2@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?eHylLoPewnUxVuXLVzd/24ic8HJo9kfCVrHX23yeU9SZUs0oSiyG9EJV+dkR?=
 =?us-ascii?Q?igMxDJo0qruLsA2LRklKgDdEoz9HKVrkNwbtPkukoPyl+kAW+BIajTOtruVZ?=
 =?us-ascii?Q?2NmC8/Gy4yAWOkajuknDY1QsbdCoIua6U+gdDy5CCbwWQjhrRz3OiUgJ6aOz?=
 =?us-ascii?Q?LXRBsrFQfT/QPpDEMaSa+BDDQzfWpdS0FGWvyJQJPBsycPJFBJh37Aq6NNXg?=
 =?us-ascii?Q?rs7Uv5jQjluDk8FkYsOsq7iQr3zkpCD5jPh4X3qwUuIkIojMZg1JrEcBStmB?=
 =?us-ascii?Q?CH35HsqgOEXoNJgfHT/r4RGV3n1UacJAgrbEGiXqzcWL2DNWw7Q+YofeEjiS?=
 =?us-ascii?Q?TtgFpYFTYH3DePLb5lp5Lnu/Y7HTpPP3q6WfRp9dmDKvzvXYs20hup5h8Q+g?=
 =?us-ascii?Q?qegQ/84gEfvg4Ub98LQM9WBcb7w3JUzGIKg7oC5iUjM7ohTSgN4TQK790NGG?=
 =?us-ascii?Q?52ozzg6D0RSidlop2pe/daNpH7H0LHTwxa6h039rrnlFnV6IsTGKHxd+agJY?=
 =?us-ascii?Q?VyWE07GQOpAFe2esrFeHoZwhvyiHnAFPs2W5tNL5ja7S0QH/n55QAaRHcI2E?=
 =?us-ascii?Q?j49UChfcidgxOReNMiBOM6q23pPvuJJyq017wbu3qfl3JMDtPyFB0JFmav/V?=
 =?us-ascii?Q?GsqG8+ZkrjkXVWoHREyAUxmWmC+DC7HYrb5EnyWCnyrDGQajoLrYMzEQIjFs?=
 =?us-ascii?Q?cW50p8WfbeE57hek0WeLw7l+EeENF9YnSpXeZnPrw5eETrkoBgvwe5xPQJbv?=
 =?us-ascii?Q?6ttmgIm9I01IlARAUSer1/wmEsGnG20vxTUDv3n1prlDMCR3HW4NAx8vbzy4?=
 =?us-ascii?Q?PW7uTEw+zpgaBOofpCitMGSWwPbXNaE+fO6X7mmwY2+2SfIw0yqJZr4JK0hX?=
 =?us-ascii?Q?14CfIF7934vk4PifV3FfBg6ALN4PcTnx18bq8x2goKJ2nmMJtJhZJGr2wKl3?=
 =?us-ascii?Q?uq6xGWg10RWqp4HI3f550qYG09FeFTtx3MpxBuYXNMMP/8t+ltczCIMhqa5Q?=
 =?us-ascii?Q?ABDwPZB5Hly1x1ufk57IXck70/aa6JeDwBNvdKuC4CY8wE7QdAcOFOwFUf2P?=
 =?us-ascii?Q?jjYPKuUO9UcO28hC5ab96b3zwJJskQY1CDFOZWdAGyzABq7Tx+0JfnNqFgRa?=
 =?us-ascii?Q?zN3+If3irj3NmJMbRKp0aJMskKfsbdOWCJdg/HXFMgW8Fsz25YngaT3Fsgxr?=
 =?us-ascii?Q?lvauep1SmvcY+eApDPmkR17bFZYRdvPD8PIQ9uet4XlvKcwEbMuacWj+g4a/?=
 =?us-ascii?Q?fDtTzKacwC9LdDqImkqOd+2Zm9/PTOSMDbbcv77pRWBxNwnl6smpAiLTuoXc?=
 =?us-ascii?Q?Q2J2frF/nharhW4l7AgLs20lWdTHtlqzikfCPnaOnCw0s9xPutbMr3U0NBID?=
 =?us-ascii?Q?ID9w/zb+C0ChS2i4d/bihv+1VAJJAAFzGchKSMGSvl3bQebzB5Tbce4viPm+?=
 =?us-ascii?Q?VvZjx/DNUAwxcGKsA5YlKCqoDusAVQmzKfhtesH9oj8lZ37Cq6xbsjTiYuVi?=
 =?us-ascii?Q?Y2v3JgBtMGuNCZRbfPR+8BMtGFbQTPJDlR5KrO5B2dwG/7M8+HtfYryLMGm9?=
 =?us-ascii?Q?qKRKnZH6LAP326QbmB0=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e5a7df5-0353-4d10-2359-08dc477a0034
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9626.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 18:34:09.9188
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LaAOsb/YhrTMC3yekoJmWRvFeHBm69pfTVTAHsSug7A2YGIonV/QgSRyUElMlHcsFSjA7ciaVY+gd2r4a1HCAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8371

On Fri, Mar 15, 2024 at 05:55:52PM +0800, Xu Yang wrote:
> In current driver, the counter will start firstly and then be configured.
> This sequence is not correct for AXI filter events since the correct
> AXI_MASK and AXI_ID are not set yet. Then the results may be inaccurate.
> 
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>

This one should be bug fix. Can you add fixes tag?

> 
> ---
> Changes in v5:
>  - new patch
> Changes in v6:
>  - no changes
> Changes in v7:
>  - no changes
> ---
>  drivers/perf/fsl_imx9_ddr_perf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/perf/fsl_imx9_ddr_perf.c b/drivers/perf/fsl_imx9_ddr_perf.c
> index 5537f4e07852..c99c43b214cb 100644
> --- a/drivers/perf/fsl_imx9_ddr_perf.c
> +++ b/drivers/perf/fsl_imx9_ddr_perf.c
> @@ -523,12 +523,12 @@ static int ddr_perf_event_add(struct perf_event *event, int flags)
>  	hwc->idx = counter;
>  	hwc->state |= PERF_HES_STOPPED;
>  
> -	if (flags & PERF_EF_START)
> -		ddr_perf_event_start(event, flags);
> -
>  	/* read trans, write trans, read beat */
>  	imx93_ddr_perf_monitor_config(pmu, event_id, counter, cfg1, cfg2);
>  
> +	if (flags & PERF_EF_START)
> +		ddr_perf_event_start(event, flags);
> +
>  	return 0;
>  }
>  
> -- 
> 2.34.1
>