Received-SPF: pass (google.com: domain of linux-kernel+bounces-106522-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 18 Mar 2024 14:35:11 -0400
From: Frank Li <Frank.li@nxp.com>
To: Joy Zou <joy.zou@nxp.com>
Cc: ping.bai@nxp.com, lgirdwood@gmail.com, broonie@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v5 3/3] arm64: dts: imx93-11x11-evk: add pca9451a support
Message-ID: <ZfiJX0NZG5N587Ai@lizhi-Precision-Tower-5810>
References: <20240318095633.4079027-1-joy.zou@nxp.com>
 <20240318095633.4079027-4-joy.zou@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240318095633.4079027-4-joy.zou@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?mk41X1bSCqyRUyXDF0E2HXuwGy8ZdIZm6B81vR1/5JZ2FYPmy/b0CfHkVDFS?=
 =?us-ascii?Q?GGGXqFJ/IgiZ4w5q4BEIxY6Dk2gNRsFY7lM6MC+0lhx/uDw7guVumSC+lEGd?=
 =?us-ascii?Q?wqbbRR01GIiIsJ0zfHXFptuaL9G8aiwu75iCjsq2EZ0ybQP8KvN57P0mwh7z?=
 =?us-ascii?Q?z/RnBS9dMAHQkzVhHgAEzHS41anNvmrctc2jUU8rokN70HpgjwyC+huOHg5u?=
 =?us-ascii?Q?U5AXGg/XI9s8Ybq7dZbQjmoIUAi/cDRNJwaonsw584vmXIBdKwzEImC7JxzJ?=
 =?us-ascii?Q?MnX1ky1YNcELtSgXFaoe70WtG4PDsFL5hMkKsJPmdEtDnkgoz612sJJWVOrB?=
 =?us-ascii?Q?oVthapJ9HtEcdRD15V5qq1lj6sBv4mVw3ugf/fbPJNvcZ9N2QMOvV0WB/F5K?=
 =?us-ascii?Q?fZKTzlCaFEyAHHdRcgv/dqyETcSCF0ObIxzmWX2To3f8NMusOwfwwwDH89BE?=
 =?us-ascii?Q?k+neolhIJyR3nr4amTbeyQ7sQQVALBLbE4wwuMGThURzmNa1ok1gEVRRAoE/?=
 =?us-ascii?Q?FXIpUTzxKt40F7iNuviA9X4nS4llak9W0OH8DOT9vEKo7vsA3Hvsyt9YVCKf?=
 =?us-ascii?Q?FSPJl8oAGUXs4pXd/65iJFF+G8W0mw4mrWfqpW3VjJf1gNsr2brf+Qay0xQS?=
 =?us-ascii?Q?xVFhkgVZnDqpscwx+BA3VKY9b6yypMaXkQK9KS2CLFfVp5j5VsWmwP9NjIDr?=
 =?us-ascii?Q?+F6UHFBnDMN2Scl9Q/ZXmLhPEOrhXAPB0T8GCja04ZkjpQHGv6EQY4e/T9I9?=
 =?us-ascii?Q?uCJX2T3U8oGDzeo8P51RUU+kb3/+bvaRnCSopPsfNvB3j+/PlqYQIHK/yNYr?=
 =?us-ascii?Q?RCklPKqnlG4GhaXGvDRCvMLtF6bi2eTZ4GCKLRnDmkmVBzJQyxOW7ZttOIJS?=
 =?us-ascii?Q?ogin29+dqC7PTvVlonIABC4jkfmhBRGMlympL8gw31CWVnx+GJAPrrNtJvr3?=
 =?us-ascii?Q?8fcqHVcgOls5BvuFNx9qURwx0prqfcB9z4SWH63BB0MEnzUid7v7wN5EfWpw?=
 =?us-ascii?Q?lFOL+kVMqVMPLJ2S1FQMoDOuzxnIkXNBVsKuwhVOJtU93mgnhAOGk9R8NVIU?=
 =?us-ascii?Q?RaYzJXRYTXOPMG22XWI8NGBA2af3w08Q7DG3omvZxLV1qRExotdGKL43ql1U?=
 =?us-ascii?Q?l/kdsqPb2BO9sF/cEosLc4OBVTeEo6ZXolaSGqtiPGGTO88xymUrCo3Kv7oZ?=
 =?us-ascii?Q?Ufdfa4qpFcWO9LV8pRXTBX5JI46qm7Fa6p9TFPFbnZcAZWwU81xpqZdi+aye?=
 =?us-ascii?Q?cUQpthk75afIqe04LoJBvM3ZHSy18akZ6VGO/FdxBXMg93hBPDpaFHzdkhZ9?=
 =?us-ascii?Q?zvSxt3v/YrOQ4SRx5WAChRzdSPda8VPrR3m9lYESOYDkH4jvoEpRz3zB2ssJ?=
 =?us-ascii?Q?nUISeBTajOOn4aAgrHydKQS6YCwPTxFFs42ja2dbONDGBMmPdbHl/yovZ0Nn?=
 =?us-ascii?Q?q2sgy25cx0CBvCxL9QahCBsyoHrJKnwic8Irz5e164OuklMnjRNssZGHd/lz?=
 =?us-ascii?Q?IzNUkc0c5NILYmsn0vnYSnsnKFSsFoccDjKWXi0+tJLB0nHlfreQ+RW2NkfO?=
 =?us-ascii?Q?J8BrWz0ftbn2GCVO3SWIs/uIRg8DpEoysM93AQFi?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9bca2c12-f078-4f40-74f7-08dc477a3090
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9626.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 18:35:31.1145
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2oENnaTzr5U9oiBl0PRO32N1YibHMZn3c1qXAeKfO1uvmZ1WNmwc+mACoA4UHe9KR+2JOMgBkCyx+BULgxrXeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8371

On Mon, Mar 18, 2024 at 05:56:33PM +0800, Joy Zou wrote:
> Support pca9451a on imx93-11x11-evk.
> 
> Signed-off-by: Joy Zou <joy.zou@nxp.com>

Reviewed-by: Frank Li <Frank.Li@nxp.com>

> ---
> Changes in v5:
> 1.adjust gpio@22 to the front of pmic@25.
> 
> Changes in v4:
> 1. modify the comment for uSDHC but not i2c.
> 
> Changes in v3:
> 1. modify the voltages constraints according to the imx93 datasheet.
> ---
>  .../boot/dts/freescale/imx93-11x11-evk.dts    | 111 ++++++++++++++++++
>  1 file changed, 111 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> index 9921ea13ab48..478a134d4416 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> @@ -183,6 +183,104 @@ &wdog3 {
>  	status = "okay";
>  };
>  
> +&lpi2c2 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	clock-frequency = <400000>;
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&pinctrl_lpi2c2>;
> +	pinctrl-1 = <&pinctrl_lpi2c2>;
> +	status = "okay";
> +
> +	pcal6524: gpio@22 {
> +		compatible = "nxp,pcal6524";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_pcal6524>;
> +		reg = <0x22>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +		interrupt-parent = <&gpio3>;
> +		interrupts = <27 IRQ_TYPE_LEVEL_LOW>;
> +	};
> +
> +	pmic@25 {
> +		compatible = "nxp,pca9451a";
> +		reg = <0x25>;
> +		interrupt-parent = <&pcal6524>;
> +		interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
> +
> +		regulators {
> +			buck1: BUCK1 {
> +				regulator-name = "BUCK1";
> +				regulator-min-microvolt = <610000>;
> +				regulator-max-microvolt = <950000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +				regulator-ramp-delay = <3125>;
> +			};
> +
> +			buck2: BUCK2 {
> +				regulator-name = "BUCK2";
> +				regulator-min-microvolt = <600000>;
> +				regulator-max-microvolt = <670000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +				regulator-ramp-delay = <3125>;
> +			};
> +
> +			buck4: BUCK4{
> +				regulator-name = "BUCK4";
> +				regulator-min-microvolt = <1620000>;
> +				regulator-max-microvolt = <3400000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			buck5: BUCK5{
> +				regulator-name = "BUCK5";
> +				regulator-min-microvolt = <1620000>;
> +				regulator-max-microvolt = <3400000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			buck6: BUCK6 {
> +				regulator-name = "BUCK6";
> +				regulator-min-microvolt = <1060000>;
> +				regulator-max-microvolt = <1140000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			ldo1: LDO1 {
> +				regulator-name = "LDO1";
> +				regulator-min-microvolt = <1620000>;
> +				regulator-max-microvolt = <1980000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			ldo4: LDO4 {
> +				regulator-name = "LDO4";
> +				regulator-min-microvolt = <800000>;
> +				regulator-max-microvolt = <840000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +
> +			ldo5: LDO5 {
> +				regulator-name = "LDO5";
> +				regulator-min-microvolt = <1800000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-boot-on;
> +				regulator-always-on;
> +			};
> +		};
> +	};
> +};
> +
>  &iomuxc {
>  	pinctrl_eqos: eqosgrp {
>  		fsl,pins = <
> @@ -238,6 +336,19 @@ MX93_PAD_DAP_TCLK_SWCLK__LPUART5_CTS_B		0x31e
>  		>;
>  	};
>  
> +	pinctrl_lpi2c2: lpi2c2grp {
> +		fsl,pins = <
> +			MX93_PAD_I2C2_SCL__LPI2C2_SCL			0x40000b9e
> +			MX93_PAD_I2C2_SDA__LPI2C2_SDA			0x40000b9e
> +		>;
> +	};
> +
> +	pinctrl_pcal6524: pcal6524grp {
> +		fsl,pins = <
> +			MX93_PAD_CCM_CLKO2__GPIO3_IO27			0x31e
> +		>;
> +	};
> +
>  	/* need to config the SION for data and cmd pad, refer to ERR052021 */
>  	pinctrl_usdhc1: usdhc1grp {
>  		fsl,pins = <
> -- 
> 2.37.1
>