Received-SPF: pass (google.com: domain of linux-kernel+bounces-106679-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 18 Mar 2024 22:14:11 +0100
From: Robert Richter <rrichter@amd.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	Alison Schofield <alison.schofield@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-cxl@vger.kernel.org, Derick Marks <derick.w.marks@intel.com>,
	Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 1/3] x86/numa: Fix SRAT lookup for CFMWS ranges with
 numa_fill_memblks()
Message-ID: <Zfiuow9LiOIl3C7X@rric.localdomain>
References: <20240318210904.2188120-1-rrichter@amd.com>
 <20240318210904.2188120-2-rrichter@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240318210904.2188120-2-rrichter@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?NSFoOhp2u1Mc4bort+dxXWcgeJ5UdDY7UFU7+3sOh4EyPhrUXGEEn5hk+Bia?=
 =?us-ascii?Q?6GP6edKmbKpQf6twQ2LFvvMZBC/KDWtxIaald54Nbfvp9oMwbgD9tJXdC20c?=
 =?us-ascii?Q?QmMhPKulUiNnNgSRRu1dtTh9X2HBcGfH/VL+47f/z+jGk/XkwJcm930RGD8/?=
 =?us-ascii?Q?h8oGmkSO8xla6cxVr+4uHu1GtovbkUZ+OR14ltTyLAOkGeOQTVjmr3o3GrzS?=
 =?us-ascii?Q?Fc5xeQVLmv0SY4gEOQDbpemiUQ9Uny5aKCPyn8lwfFp2Wo3Egc1UeClsefpe?=
 =?us-ascii?Q?h3EA4z9O0iVLIxf+Cg5knQzpKyDpR7E+J9bvSdqutOubmpdHtWVtVOV3JHe3?=
 =?us-ascii?Q?4ueYSLG3Sag8FybVi5YUyY2Y5MOkFa1lqPZoD9qbdfhgFC/nd4WF2y9FtpWN?=
 =?us-ascii?Q?vXRF/t60J+OSM+FPO3Nu0qKQGF1iUmMuiqNLhdi9SAPqaRX8wrFDOGVL9twM?=
 =?us-ascii?Q?KypMhW1oU/i+CaD3HxVF2xnI431kTRBO4x/0bd7ZS74RYkaq2RtENwtirZ0t?=
 =?us-ascii?Q?ShQmB3ravBhL/9fU1zOHnnRuwez1n+JVN8AiLQU2dmMfaeZowZH1y3/RsYNi?=
 =?us-ascii?Q?YEZQ4UWqLZ54vD9NArJR+AX3loTk6zjE0BX0QGj9oDCTERbL//tGLBGluG0V?=
 =?us-ascii?Q?fBfSCTuJLtIBB/shvtNPKzGdSX7btTGmkm6RMkzbQANn3TCC6+Ev1+1ce7i0?=
 =?us-ascii?Q?Y6jwK73nIuOuJtlJnWIh5rlco7wnqyBe0yYSJqcw2v3TNuzQqiAfT46+O1DZ?=
 =?us-ascii?Q?HWI0v1Wgui/PbbVwRNuXIBPddLKXQ8uodKwPd0xH+FNuSceBJij1LGnVnar+?=
 =?us-ascii?Q?kPVMRbIO0IEqYvuZuYBbxVYTN3kB/VcxSPx/F3dLrxdvcdLwqxnEA7KnKsSc?=
 =?us-ascii?Q?HvbX30MRFQnzfbPw5WmQJa8Eaw+J2aq8upmgXFKfXhcFyBTY/oC80NRS0853?=
 =?us-ascii?Q?dosAPJtRCzn/XZeaFEPJYkl/8G4zCBONRhKUt8B0BDDRZTgBzT2BrcSBkNlE?=
 =?us-ascii?Q?y3bALedboq23f2IrjYLfg4N3vrQ0T31C4PfMnMJ/pEPfeSEhabauH3miQFYZ?=
 =?us-ascii?Q?HuemZlXVQwT0chHMByW22OYwGj5OBj074Eo+CqmyyCQERIHyNge9vCuWxmcb?=
 =?us-ascii?Q?x3HI+8VR62q1KoNfj/siYBjTr+/RGNn43fMnnfNI17oesU/jB9eukcg18e/T?=
 =?us-ascii?Q?KOJe9wgQdPAjASWTu2M87e1jc0pSuDUGi7anW1QUA8ySxXNn4IpLL8l+Zslt?=
 =?us-ascii?Q?ME5cIqIsqh8pijIuvqqvCFZ8UBCL7DjgwCt8XyCbJnVFYXGOTh52kOBt03OY?=
 =?us-ascii?Q?FMznReM3yRsgJ86m5mp9iYExLNDQRW/8uw2gZWwIQq1zYW53jicTeyBMy7j/?=
 =?us-ascii?Q?QttjugJa/n7zbECXGsS2z4ihdA53aCU4OzhUFmIVXZLu9Py/3537SPZO26EQ?=
 =?us-ascii?Q?V4FmSh/l0PsbpO13JuZonH3+eARS5aU1Pe0ikTXH5ur8ctYY6pQZzpe+rnHX?=
 =?us-ascii?Q?kq261gvyJxduWholhFUZgn2pWQ/7iYnY0b8JMXYhOpZb0IEChbLf/4WbzF8W?=
 =?us-ascii?Q?iKZbddtC+3zKDGoKr1H9kLXb1JjFT4jJsvXZE7MD?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75d329b2-b21d-48ef-c4e2-08dc47905e9e
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8750.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 21:14:16.9135
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rwQCQBH5j601LdQhj+Mmo5Udk5/2L3XF16imWZXxj0RZu/yQRlGF4gP0NcoBuGu3OLGsqaypfDFmeaLUVG+3TA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5747

On 18.03.24 22:09:00, Robert Richter wrote:
> With kconfig option NUMA_KEEP_MEMINFO disabled the SRAT lookup done
> with numa_fill_memblks() fails returning NUMA_NO_MEMBLK (-1). An
> existing SRAT memory range cannot be found for a CFMWS address range.
> This causes the addition of a duplicate numa_memblk with a different
> node id and a subsequent page fault and kernel crash during boot.
> 
> Note that the issue was initially introduced with [1]. But since
> phys_to_target_node() was originally used that returned the valid node
> 0, an additional numa_memblk was not added. Though, the node id was
> wrong too.
> 
> Fix this by enabling NUMA_KEEP_MEMINFO for x86 with ACPI and NUMA
> enabled.
> 
> [1] fd49f99c1809 ("ACPI: NUMA: Add a node and memblk for each CFMWS not in SRAT")
> 
> Fixes: 8f1004679987 ("ACPI/NUMA: Apply SRAT proximity domain to entire CFMWS window")
> Cc: Derick Marks <derick.w.marks@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Alison Schofield <alison.schofield@intel.com>
> Signed-off-by: Robert Richter <rrichter@amd.com>

This patch should be dropped in favor of the other 1/3 patch, it is a
leftover.

Thanks,

-Robert