Received-SPF: pass (google.com: domain of linux-kernel+bounces-106685-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <000000000000bbb3d80613f243a6@google.com> <CAKEwX=MAX0km1p43DQmKbeSy2G4dPFHiF+deH_qzqygc2Vnjig@mail.gmail.com>
 <CAJD7tkbEuFkGuQeYjKS02rQoAAKOKieAJ1P2mwukirW3e2JN9A@mail.gmail.com> <20240318210917.GA4210@cmpxchg.org>
In-Reply-To: <20240318210917.GA4210@cmpxchg.org>
From: Yosry Ahmed <yosryahmed@google.com>
Date: Mon, 18 Mar 2024 14:18:51 -0700
Message-ID: <CAJD7tkZhCt_r1uULbfe4eg=zo7=o7muJ787wyEw1yN7x+ijYGA@mail.gmail.com>
Subject: Re: [syzbot] [mm?] kernel BUG in sg_init_one
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Nhat Pham <nphamcs@gmail.com>, 
	syzbot <syzbot+adbc983a1588b7805de3@syzkaller.appspotmail.com>, 
	akpm@linux-foundation.org, chengming.zhou@linux.dev, 
	linux-kernel@vger.kernel.org, linux-mm@kvack.org, 
	syzkaller-bugs@googlegroups.com, Barry Song <v-songbaohua@oppo.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 18, 2024 at 2:09=E2=80=AFPM Johannes Weiner <hannes@cmpxchg.org=
> wrote:
>
> On Mon, Mar 18, 2024 at 01:17:19PM -0700, Yosry Ahmed wrote:
> > On Mon, Mar 18, 2024 at 11:00=E2=80=AFAM Nhat Pham <nphamcs@gmail.com> =
wrote:
> > >
> > > On Mon, Mar 18, 2024 at 9:58=E2=80=AFAM syzbot
> > > <syzbot+adbc983a1588b7805de3@syzkaller.appspotmail.com> wrote:
> > > >
> > > > Hello,
> > > >
> > > > syzbot found the following issue on:
> > > >
> > > > HEAD commit:    e5eb28f6d1af Merge tag 'mm-nonmm-stable-2024-03-14-=
09-36' ..
> > > > git tree:       upstream
> > > > console output: https://syzkaller.appspot.com/x/log.txt?x=3D13043ab=
e180000
> > > > kernel config:  https://syzkaller.appspot.com/x/.config?x=3D19bb57c=
23dffc38e
> > > > dashboard link: https://syzkaller.appspot.com/bug?extid=3Dadbc983a1=
588b7805de3
> > > > compiler:       arm-linux-gnueabi-gcc (Debian 12.2.0-14) 12.2.0, GN=
U ld (GNU Binutils for Debian) 2.40
> > > > userspace arch: arm
> > > > syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=3D1706d=
231180000
> > > > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=3D13ba795=
9180000
> > > >
> > > > Downloadable assets:
> > > > disk image (non-bootable): https://storage.googleapis.com/syzbot-as=
sets/8ead8862021c/non_bootable_disk-e5eb28f6.raw.xz
> > > > vmlinux: https://storage.googleapis.com/syzbot-assets/0a7371c63ff2/=
vmlinux-e5eb28f6.xz
> > > > kernel image: https://storage.googleapis.com/syzbot-assets/7539441b=
4add/zImage-e5eb28f6.xz
> > > >
> > > > IMPORTANT: if you fix the issue, please add the following tag to th=
e commit:
> > > > Reported-by: syzbot+adbc983a1588b7805de3@syzkaller.appspotmail.com
> > > >
> > > > ------------[ cut here ]------------
> > > > kernel BUG at include/linux/scatterlist.h:187!
> > >
> > > Looks like the provided buffer is invalid:
> > >
> > > #ifdef CONFIG_DEBUG_SG
> > > BUG_ON(!virt_addr_valid(buf));
> > > #endif
> > >
> > > which is "src" from:
> > >
> > > sg_init_one(&input, src, entry->length);
> > >
> > > Looking at the surrounding code and recent history, there's this
> > > commit that stands out:
> > >
> > > mm/zswap: remove the memcpy if acomp is not sleepable
> > > (sha: 270700dd06ca41a4779c19eb46608f076bb7d40e)
> > >
> > > which has the effect of, IIUC, using the zpool mapped memory directly
> > > as src, instead of acomp_ctx->buffer (which was previously the case,
> > > as zsmalloc was not sleepable).
> > >
> > > This might not necessarily be a bug with that commit itself, but migh=
t
> > > have revealed another bug elsewhere.
> > >
> > > Anyway, cc-ing the author, Barry Song, to fact check me :) Will take =
a
> > > closer look later.
> >
> > I am not a highmem expert, but the reproducer has CONFIG_HIGHMEM=3Dy,
> > and it seems like zs_map_object() may return a highmem address if the
> > compressed object is entirely in a single page to avoid copying to a
> > buffer:
> >
> > if (off + class->size <=3D PAGE_SIZE) {
> >    /* this object is contained entirely within a page */
> >    area->vm_addr =3D kmap_atomic(page);
> >    ret =3D area->vm_addr + off;
> >    goto out;
> > }
> >
> > The virt_addr_valid() check seems to indicate that we expect a direct
> > map address in sg_init_one(), right?
>
> If the page is highmem, kmap_atomic() establishes a temporary mapping
> to it in the direct map, such that we have a legit kernel pointer to
> the memory. Otherwise the memcpy() in zswap also wouldn't work... Am I
> missing something?

IIUC kmap_atomic() establishes a mapping in the kernel portion of the
address space, but not a direct map mapping (i.e. not a linear
mapping), right?

Does virt_addr_valid() check for addresses being in the kernel portion
of the address space, or it being a linear mapping? I thought it
checks for the latter.