Received-SPF: pass (google.com: domain of linux-kernel+bounces-106688-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <4a69382c-5fb2-4703-8176-f1833eeffcc1@quicinc.com>
Date: Mon, 18 Mar 2024 14:21:12 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] drm/panel: simple: Add POWERTIP PH128800T006-ZHC01
 panel entry
To: Nathan Morrisson <nmorrisson@phytec.com>, <neil.armstrong@linaro.org>,
        <sam@ravnborg.org>, <maarten.lankhorst@linux.intel.com>,
        <mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
        <daniel@ffwll.ch>, <robh@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <thierry.reding@gmail.com>
CC: <w.egorov@phytec.de>, <dri-devel@lists.freedesktop.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <upstream@lists.phytec.de>
References: <20240318161708.1415484-1-nmorrisson@phytec.com>
 <20240318161708.1415484-3-nmorrisson@phytec.com>
Content-Language: en-US
From: Jessica Zhang <quic_jesszhan@quicinc.com>
In-Reply-To: <20240318161708.1415484-3-nmorrisson@phytec.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 3/18/2024 9:17 AM, Nathan Morrisson wrote:
> Add support for the POWERTIP PH128800T006-ZHC01 10.1" (1280x800)
> LCD-TFT panel.
> 
> Signed-off-by: Nathan Morrisson <nmorrisson@phytec.com>

Hi Nathan,

Acked-by: Jessica Zhang <quic_jesszhan@quicinc.com>

Thanks,

Jessica Zhang

> ---
>   drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++
>   1 file changed, 29 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 20e3df1c59d4..02d238123753 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3465,6 +3465,32 @@ static const struct panel_desc pda_91_00156_a0  = {
>   	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>   };
>   
> +static const struct drm_display_mode powertip_ph128800t006_zhc01_mode = {
> +	.clock = 66500,
> +	.hdisplay = 1280,
> +	.hsync_start = 1280 + 12,
> +	.hsync_end = 1280 + 12 + 20,
> +	.htotal = 1280 + 12 + 20 + 56,
> +	.vdisplay = 800,
> +	.vsync_start = 800 + 1,
> +	.vsync_end = 800 + 1 + 3,
> +	.vtotal = 800 + 1 + 3 + 20,
> +	.flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> +};
> +
> +static const struct panel_desc powertip_ph128800t006_zhc01 = {
> +	.modes = &powertip_ph128800t006_zhc01_mode,
> +	.num_modes = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 216,
> +		.height = 135,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH,
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
> +};
> +
>   static const struct drm_display_mode powertip_ph800480t013_idf02_mode = {
>   	.clock = 24750,
>   	.hdisplay = 800,
> @@ -4639,6 +4665,9 @@ static const struct of_device_id platform_of_match[] = {
>   	}, {
>   		.compatible = "pda,91-00156-a0",
>   		.data = &pda_91_00156_a0,
> +	}, {
> +		.compatible = "powertip,ph128800t006-zhc01",
> +		.data = &powertip_ph128800t006_zhc01,
>   	}, {
>   		.compatible = "powertip,ph800480t013-idf02",
>   		.data = &powertip_ph800480t013_idf02,
> -- 
> 2.25.1
>