Received-SPF: pass (google.com: domain of linux-kernel+bounces-106706-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 18 Mar 2024 14:31:27 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Robert Richter <rrichter@amd.com>, "Rafael J. Wysocki"
	<rafael@kernel.org>, Alison Schofield <alison.schofield@intel.com>, "Dan
 Williams" <dan.j.williams@intel.com>, Dave Hansen
	<dave.hansen@linux.intel.com>
CC: <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, Derick Marks <derick.w.marks@intel.com>, "Len
 Brown" <lenb@kernel.org>
Subject: Re: [PATCH 1/3] x86/numa: Fix SRAT lookup for CFMWS ranges with
 numa_fill_memblks()
Message-ID: <65f8b2afdfc38_aa22294ef@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240318210904.2188120-1-rrichter@amd.com>
 <20240318210904.2188120-2-rrichter@amd.com>
 <Zfiuow9LiOIl3C7X@rric.localdomain>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Zfiuow9LiOIl3C7X@rric.localdomain>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xE3o83aCZ8mkNtBEkHnyI2pUQmBfUHTWGFya6aqJiO1xmyjjCuXxD2HmHZoZ?=
 =?us-ascii?Q?z9peizTQCXxd6444HR4Nek5ZSD2alumDAyPeXY1ODIjo1QU+SUxMyGO4fHHv?=
 =?us-ascii?Q?XvmDhm9s3admF+Dgpgws7Np6bfzzCk6Bd93sYeK3wmjv/J5HD6OY3vb469Se?=
 =?us-ascii?Q?ncJcMiml3xSPa0zac6rcNBinIGJ+lXr6ut5C2dAFiAI83hwTtGmcRTKMbWH0?=
 =?us-ascii?Q?oXFmq3RKO/Eam6ARtg+h29N7hKveVsjGrLgBoZvSIbMo9kkIAV8IOQShzntn?=
 =?us-ascii?Q?V6b2b/bn0xcSTuk2FjU2HYoymlvhzEe75WQ/+Vih9Fs7wwLaqOSpJJ2PCaV7?=
 =?us-ascii?Q?XZAzn3wPldk5L8SypD4Dr0DsAaLCW4LUyWAepbQ0gcSk6RQP5JQ6N1prLHEX?=
 =?us-ascii?Q?Js/5g/2jWmqrRUaHD/UygBL8cv+iYlk63Pgg58xtVUEMMN26uOOo13g3xJm6?=
 =?us-ascii?Q?XCRyFAl+WICJwcIUUbvUsuQaFPOpUMlchMceGtckS2822gHdqAczAyxCLlLi?=
 =?us-ascii?Q?zrlI0ApshUsH9wpHISqjiIVXOgBevnEOF/ONRxfQc1an9Jpb533P6mPrPIBE?=
 =?us-ascii?Q?QR2o3IlbFHSaCnVkyx80lEMV6PWe0B+AjEHJagw001vn2N1UjyoZVyElrA0u?=
 =?us-ascii?Q?WFd1iB3dcaQIAJGuR8Eo9YLRcRqWgWqa0NX0fQFVPv8fDdphDhD5Z8k4PLd4?=
 =?us-ascii?Q?gOW4ZWl135P+oPbIVY01vIaikstSJMfWL1JOM3ozvh69a5ViVbzP0xyGfzMD?=
 =?us-ascii?Q?FNXUGXh8UbGG1JdrzSwJCApQkf9gU4dvH7YTwiqtlIJQL3xCA7D0//9xVsUd?=
 =?us-ascii?Q?yuWiy0WcbJ0Q5NjNbWcXmhmsArccNkfotjVjHWbJStFJ5pdcRKA7r7JZ0bNi?=
 =?us-ascii?Q?6DGPHcyafQTYStkuS3spaVc7y6CERFa6R+RIgG0mp5Wr+FOf9U6aHVouEez8?=
 =?us-ascii?Q?W5+Quqr8+C1tVuDnR3W2Os0VE9r8fMv5pVMCP2xPaojpnW5sIhQT50Toa0Pb?=
 =?us-ascii?Q?TufegBX1kl8Iwsyr9b5cimpxmSEICh0PM/0R/iIIquZGb8SkB7fB8f0VA1mA?=
 =?us-ascii?Q?ccFArOAs57ddzopBvkWHDMyTPIQ33u8/DRZ2bcwCjLkga45dxXqxJ2oNtN8Z?=
 =?us-ascii?Q?H0zgWZHJpN2d9loGHKGF7EPIhRl3VRCWgjZ7p4PsxKXo9nUUo25DloY9ScW/?=
 =?us-ascii?Q?B6GuW5FMTBpH8tfTvxLvXkxPalseCYSdNRFLOkcv6sk0WnOhQI1ZfbycGrPv?=
 =?us-ascii?Q?5c+Fh8nFjGzmsErXensgA+vs2oeAzP8on3bb0Cj3RD0o1KdscpMn0fn88dZ5?=
 =?us-ascii?Q?81k+v+4ReLxw8n1bOHFAztrak+0SjvDzhtX0M5kYpOAzaPXpe9/zT8p+/BXl?=
 =?us-ascii?Q?q0Q944384da8UKrsRKfa4lh+k0US+BVIvlFquMn+Cz+SUSblsnhdopKjoWL/?=
 =?us-ascii?Q?gZWXvH1nHqg2Csfarifc+LsO/WAcdOiwHqSrTnEFEaQprfmlJzRnDYt6RfUu?=
 =?us-ascii?Q?4S5aknKfM+GyjvCktApucR9KW59CIpIIlXN1IfEtWl0gmW4ZE+fdJr6l6lYZ?=
 =?us-ascii?Q?CLRxWgE5YpqbbWg0+mdMCQ1wG7rjgbiV9GLwgCWNVa7u8kWcsAbbK3TpEec9?=
 =?us-ascii?Q?QQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f1d67cb-0fb2-4159-7947-08dc4792c692
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2024 21:31:30.3212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FoZSerQMuWe75/orpsLMb3JfhzC93y9z2uYXrQXkysYvmdgbIyXL+pfeSz21Mnv6J8Vb2yNry6HykMEIRi5nXEt86YNlRe7r6hctwPg/SEo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5816
X-OriginatorOrg: intel.com

Robert Richter wrote:
> On 18.03.24 22:09:00, Robert Richter wrote:
> > With kconfig option NUMA_KEEP_MEMINFO disabled the SRAT lookup done
> > with numa_fill_memblks() fails returning NUMA_NO_MEMBLK (-1). An
> > existing SRAT memory range cannot be found for a CFMWS address range.
> > This causes the addition of a duplicate numa_memblk with a different
> > node id and a subsequent page fault and kernel crash during boot.
> > 
> > Note that the issue was initially introduced with [1]. But since
> > phys_to_target_node() was originally used that returned the valid node
> > 0, an additional numa_memblk was not added. Though, the node id was
> > wrong too.
> > 
> > Fix this by enabling NUMA_KEEP_MEMINFO for x86 with ACPI and NUMA
> > enabled.
> > 
> > [1] fd49f99c1809 ("ACPI: NUMA: Add a node and memblk for each CFMWS not in SRAT")
> > 
> > Fixes: 8f1004679987 ("ACPI/NUMA: Apply SRAT proximity domain to entire CFMWS window")
> > Cc: Derick Marks <derick.w.marks@intel.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Alison Schofield <alison.schofield@intel.com>
> > Signed-off-by: Robert Richter <rrichter@amd.com>
> 
> This patch should be dropped in favor of the other 1/3 patch, it is a
> leftover.

What "other" patch? Did I respond to the wrong one?