Received-SPF: pass (google.com: domain of linux-kernel+bounces-106711-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 18 Mar 2024 23:37:19 +0200
Message-Id: <CZX77XLG67HZ.UAU4NUQO27JP@kernel.org>
Cc: "Eric Biggers" <ebiggers@kernel.org>, <keyrings@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] keys: update key quotas in key_put()
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Jarkko Sakkinen" <jarkko@kernel.org>, "Luis Henriques"
 <luis.henriques@linux.dev>, "David Howells" <dhowells@redhat.com>
References: <20240130101344.28936-1-lhenriques@suse.de>
 <3007646.1707134664@warthog.procyon.org.uk> <87il33f24c.fsf@suse.de>
 <87msr2qpd9.fsf@brahms.olymp> <CZX6QS05JAHA.M82GVT11TIQC@kernel.org>
In-Reply-To: <CZX6QS05JAHA.M82GVT11TIQC@kernel.org>

On Mon Mar 18, 2024 at 11:14 PM EET, Jarkko Sakkinen wrote:
> On Wed Mar 13, 2024 at 2:37 PM EET, Luis Henriques wrote:
> > Luis Henriques <lhenriques@suse.de> writes:
> >
> > > David Howells <dhowells@redhat.com> writes:
> > >
> > >> Luis Henriques <lhenriques@suse.de> wrote:
> > >>
> > >>> Delaying key quotas update when key's refcount reaches 0 in key_put=
() has
> > >>> been causing some issues in fscrypt testing, specifically in fstest
> > >>> generic/581.  This commit fixes this test flakiness by dealing with=
 the
> > >>> quotas immediately, and leaving all the other clean-ups to the key =
garbage
> > >>> collector.
> > >>
> > >> Okay, I'll accept this.
> > >>
> > >
> > > That's awesome, thanks a lot David.  And, as Eric requested, I'll sen=
d out
> > > shortly a follow-up fscrypt-specific patch, which will make generic/5=
81
> > > fstest finally pass.
> >
> > Ping.  Looks like this fell through the cracks...?
> >
> > I took a quick look at some git trees ('jarkko' and 'dhowells') but
> > couldn't see this patch anywhere.
> >
> > Cheers,
>
> My bad! I'll pick this up now.

I applied it.

Only for completeness sake I mention that I tuned the 2nd paragraph so
that lines do no exceed 75 characters :-) Otherwise, I did not modify
the commit.

I'll schedule this to a PR after rc1 is out (just to see if there is
something else that needs to be picked before that).

BR, Jarkko