Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp507521lqt; Mon, 18 Mar 2024 14:39:11 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWyTcduIZmhilbzlS+iezc6S/kd0pr4up3NgpLUgVvm99T2k1PuRMqw2TOng03N1OTj+wsJtx/Fi+2v/MgrkWQai036oW/NuWUxPIquaA== X-Google-Smtp-Source: AGHT+IGS2rstRYZiLd7vL7pal04WVmPbhW6VTNW0Bnkhig+/8xC8zWk4BqawKGbS4vZsKLON2gH8 X-Received: by 2002:a17:90b:1086:b0:29d:d77f:f893 with SMTP id gj6-20020a17090b108600b0029dd77ff893mr10180440pjb.38.1710797951028; Mon, 18 Mar 2024 14:39:11 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710797951; cv=pass; d=google.com; s=arc-20160816; b=UY+tPaIDb8/7Nu9/wcFhELOAvViXC1Pp/2xo+t/eDBmFJWyRc2yu0EAV5Ls8kZuZGv DgBp6I7HJsE8eYj7hWPgioN0dbHCfXr3juxyPC+eUzZa3+dhqUuy+FXdberOhsE6lGtN IUN19ln6cixVPcaMbJ7138Ztu0lwY6dHl2qiF/3Hn7ISqUrHPlwP4ho8NE8dHCYLl9YC XPvU6/tpD+zl7jPbWN5sV17rDytR/8GltOFTkfLAem6nrv/XnfjmA82h8n4HPkHEUvz+ Do/IAevNK9IWlrMfJU7jkGlgzwHWaIqlk8GVaIHvvr6lEBgPTY4qCF/ku5ywUE98kvNM BcVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:from :dkim-signature; bh=P0SOW6+g0gbF8DU5iHpH960YQxkLq5Ws1it0zmKAALc=; fh=575oLajY16KmbPss8F5nAwtzEYYSJWRpQHUZNGML8gE=; b=kpVYtkirh3CWgStM/V9/gaNgtVMwDR2Un49O+bbXwXGsc0SJsAzayALz2u5mHL+HES KtBSNWZqZHM1dIOaiKLFJiOfVoPaEZI2K+SdGSTvCDwqYbvNK+RMqD0llIrIjfcKX9yo jaYf8kp25yS2dkuWLvGjMECOVkdPzcJB6YHz6J+3U8UnsEYE6acZMYEr3g+yAkovg/ui pPv+4gWDNpYI9vzai4VbWn6P5xkYFsHSdQ4APteIANrGjPrCBa9VbL5ZcPFPDClWC9X4 ve2ukIwH5gCfm7mUQmLCkCsmeTI0WFHabQxSOvf7N1EOMhlatAHNDZPIR23VgFpXrzp2 PV9w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=G+cV+Zud; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-106715-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106715-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id k6-20020a17090a9d8600b0029c14d14301si8942483pjp.115.2024.03.18.14.39.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 14:39:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-106715-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=G+cV+Zud; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-106715-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106715-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 42CBEB2199C for ; Mon, 18 Mar 2024 21:38:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C24E15A4CA; Mon, 18 Mar 2024 21:38:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="G+cV+Zud" Received: from out-189.mta0.migadu.com (out-189.mta0.migadu.com [91.218.175.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F3075A0FA for ; Mon, 18 Mar 2024 21:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710797893; cv=none; b=pdjFk+cqZ+uXPkoY6EtWdmFwRMRZJjLfnR47BNa9sP71CshQPnFZOpHvkUt30vtGBg1y5ok4Rs10By+eSdeinMHpafXwDAMLkKZOs/2qA2SpM2iUJgt5tc83Np+qp/hAKlICr9UVL7kumcweBv2SegI0Zunfm/x3BVRwIAQkBZ8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710797893; c=relaxed/simple; bh=EfBl7JuECHz7HlqxR5vRgZJaunMWQ9dYHiogpv1qmMo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ahmHlhzgaPaO2hvoxOeLGFkstRcZZEk2xFm7dBt2Zgfd9JC+2W/Vfg1p4P/XMp4eGW7WiaJACbOA6Yb5Ydka7W9Ha+sQVMemK3A5pr5+eqcYdDzJexmZALkW2zHDe6ICTTSOw4sy0tjxm8IRBsSSkfZceHoY6BGbk4fVR/UaD54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=G+cV+Zud; arc=none smtp.client-ip=91.218.175.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710797889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P0SOW6+g0gbF8DU5iHpH960YQxkLq5Ws1it0zmKAALc=; b=G+cV+ZudHb99EOjOkEyYkRbNweyknEYF0BiWBTEx7dWWxiblPSPAh7duJ2+LHdgItIbn6M TAd6gKys5aTGgPyteoXBTcyCivHuPdyRatBMpeppVL3fuT+nIq2C3aM1Vj9bFCGAR47Aj3 uRzT77InOc8li8Ta6WbMvqIAxG4VjYM= From: Luis Henriques To: "Jarkko Sakkinen" Cc: "David Howells" , "Eric Biggers" , , Subject: Re: [PATCH v3] keys: update key quotas in key_put() In-Reply-To: (Jarkko Sakkinen's message of "Mon, 18 Mar 2024 23:14:55 +0200") References: <20240130101344.28936-1-lhenriques@suse.de> <3007646.1707134664@warthog.procyon.org.uk> <87il33f24c.fsf@suse.de> <87msr2qpd9.fsf@brahms.olymp> Date: Mon, 18 Mar 2024 21:38:05 +0000 Message-ID: <87plvr9q6a.fsf@camandro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT "Jarkko Sakkinen" writes: > On Wed Mar 13, 2024 at 2:37 PM EET, Luis Henriques wrote: >> Luis Henriques writes: >> >> > David Howells writes: >> > >> >> Luis Henriques wrote: >> >> >> >>> Delaying key quotas update when key's refcount reaches 0 in key_put() has >> >>> been causing some issues in fscrypt testing, specifically in fstest >> >>> generic/581. This commit fixes this test flakiness by dealing with the >> >>> quotas immediately, and leaving all the other clean-ups to the key garbage >> >>> collector. >> >> >> >> Okay, I'll accept this. >> >> >> > >> > That's awesome, thanks a lot David. And, as Eric requested, I'll send out >> > shortly a follow-up fscrypt-specific patch, which will make generic/581 >> > fstest finally pass. >> >> Ping. Looks like this fell through the cracks...? >> >> I took a quick look at some git trees ('jarkko' and 'dhowells') but >> couldn't see this patch anywhere. >> >> Cheers, > > My bad! I'll pick this up now. Awesome, thanks a lot Jarkko. Cheers, -- Luis