Received-SPF: pass (google.com: domain of linux-kernel+bounces-106724-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 18 Mar 2024 14:53:09 -0700
From: Kees Cook <keescook@chromium.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: elver@google.com, andreyknvl@gmail.com, ryabinin.a.a@gmail.com,
	akpm@linux-foundation.org, kasan-dev@googlegroups.com,
	linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
	Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] ubsan: Remove unused function
Message-ID: <202403181452.500EF35300@keescook>
References: <20240315015347.2259-1-jiapeng.chong@linux.alibaba.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240315015347.2259-1-jiapeng.chong@linux.alibaba.com>

On Fri, Mar 15, 2024 at 09:53:47AM +0800, Jiapeng Chong wrote:
> The function are defined in the test_ubsan.c file, but not called
> elsewhere, so delete the unused function.
> 
> lib/test_ubsan.c:137:28: warning: unused variable 'skip_ubsan_array'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8541
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  lib/test_ubsan.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/lib/test_ubsan.c b/lib/test_ubsan.c
> index 276c12140ee2..be335a93224f 100644
> --- a/lib/test_ubsan.c
> +++ b/lib/test_ubsan.c
> @@ -133,11 +133,6 @@ static const test_ubsan_fp test_ubsan_array[] = {
>  	test_ubsan_misaligned_access,
>  };
>  
> -/* Excluded because they Oops the module. */
> -static const test_ubsan_fp skip_ubsan_array[] = {
> -	test_ubsan_divrem_overflow,
> -};

But then I'll get warnings about test_ubsan_divrem_overflow() being
defined and not used. :)

-Kees

> -
>  static int __init test_ubsan_init(void)
>  {
>  	unsigned int i;
> -- 
> 2.20.1.7.g153144c
> 

-- 
Kees Cook