Received-SPF: pass (google.com: domain of linux-kernel+bounces-106726-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Christian Brauner <brauner@kernel.org>
Cc: amir73il@gmail.com, hu1.chen@intel.com, miklos@szeredi.hu,
 malini.bhandaru@intel.com, tim.c.chen@intel.com, mikko.ylinen@intel.com,
 lizhen.you@intel.com, linux-unionfs@vger.kernel.org,
 linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC v3 1/5] cleanup: Fix discarded const warning when defining
 lock guard
In-Reply-To: <20240318-flocken-nagetiere-1e027955d06e@brauner>
References: <20240216051640.197378-1-vinicius.gomes@intel.com>
 <20240216051640.197378-2-vinicius.gomes@intel.com>
 <20240318-flocken-nagetiere-1e027955d06e@brauner>
Date: Mon, 18 Mar 2024 14:54:56 -0700
Message-ID: <875xxjp5n3.fsf@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Christian Brauner <brauner@kernel.org> writes:

> On Thu, Feb 15, 2024 at 09:16:36PM -0800, Vinicius Costa Gomes wrote:
>> Fix the following warning when defining a cleanup guard for a "const"
>> pointer type:
>>=20
>> ./include/linux/cleanup.h:211:18: warning: return discards =E2=80=98cons=
t=E2=80=99 qualifier from pointer target type [-Wdiscarded-qualifiers]
>>   211 |         return _T->lock;                                        =
        \
>>       |                ~~^~~~~~
>> ./include/linux/cleanup.h:233:1: note: in expansion of macro =E2=80=98__=
DEFINE_UNLOCK_GUARD=E2=80=99
>>   233 | __DEFINE_UNLOCK_GUARD(_name, _type, _unlock, __VA_ARGS__)       =
        \
>>       | ^~~~~~~~~~~~~~~~~~~~~
>> ./include/linux/cred.h:193:1: note: in expansion of macro =E2=80=98DEFIN=
E_LOCK_GUARD_1=E2=80=99
>>   193 | DEFINE_LOCK_GUARD_1(cred, const struct cred, _T->lock =3D overri=
de_creds_light(_T->lock),
>>       | ^~~~~~~~~~~~~~~~~~~
>>=20
>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>> ---
>>  include/linux/cleanup.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/include/linux/cleanup.h b/include/linux/cleanup.h
>> index c2d09bc4f976..085482ef46c8 100644
>> --- a/include/linux/cleanup.h
>> +++ b/include/linux/cleanup.h
>> @@ -208,7 +208,7 @@ static inline void class_##_name##_destructor(class_=
##_name##_t *_T)	\
>>  									\
>>  static inline void *class_##_name##_lock_ptr(class_##_name##_t *_T)	\
>>  {									\
>> -	return _T->lock;						\
>> +	return (void *)_T->lock;					\
>>  }
>
> I think both of these patches are a bit ugly as we burden the generic
> cleanup code with casting to void which could cause actual issues.

Fair point.

>
> Casting from const to non-const is rather specific to the cred code so I
> would rather like to put the burden on the cred code instead of the
> generic code if possible.

For what it's worth, I liked your changes, will remove these two "fixes"
from the series and use your suggestions in the next version.


Thank you,
--=20
Vinicius