Received-SPF: pass (google.com: domain of linux-kernel+bounces-106761-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240318-ad7944-cleanups-v1-1-0cbb0349a14f@baylibre.com>
In-Reply-To: <20240318-ad7944-cleanups-v1-1-0cbb0349a14f@baylibre.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Tue, 19 Mar 2024 00:43:24 +0200
Message-ID: <CAHp75VfKZy45RVJmAAOEPyUFTW7MhxJmOeQHj3YV7p-NPKpkvg@mail.gmail.com>
Subject: Re: [PATCH] iio: adc: ad7944: simplify adi,spi-mode property parsing
To: David Lechner <dlechner@baylibre.com>
Cc: Jonathan Cameron <jic23@kernel.org>, Michael Hennerich <michael.hennerich@analog.com>, 
	=?UTF-8?B?TnVubyBTw6E=?= <nuno.sa@analog.com>, linux-iio@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 18, 2024 at 11:57=E2=80=AFPM David Lechner <dlechner@baylibre.c=
om> wrote:
>
> This simplifies the adi,spi-mode property parsing by using
> device_property_match_property_string() instead of two separate
> functions. Also, the error return value is now more informative
> in cases where there was problem parsing the property.

a problem

..

> +       ret =3D device_property_match_property_string(dev, "adi,spi-mode"=
,
> +                                                   ad7944_spi_modes,
> +                                                   ARRAY_SIZE(ad7944_spi=
_modes));
> +       if (ret < 0) {
>                 /* absence of adi,spi-mode property means default mode */
> -               adc->spi_mode =3D AD7944_SPI_MODE_DEFAULT;
> +               if (ret =3D=3D -EINVAL)
> +                       adc->spi_mode =3D AD7944_SPI_MODE_DEFAULT;
> +               else
> +                       return dev_err_probe(dev, ret,
> +                                            "getting adi,spi-mode proper=
ty failed\n");

No need to have 'else'

               if (ret !=3D -EINVAL)
                       return dev_err_probe(dev, ret, "getting
adi,spi-mode property failed\n");

               /* absence of adi,spi-mode property means default mode */
               adc->spi_mode =3D AD7944_SPI_MODE_DEFAULT;

> +       } else {
> +               adc->spi_mode =3D ret;
>         }

--=20
With Best Regards,
Andy Shevchenko