Received-SPF: pass (google.com: domain of linux-kernel+bounces-106772-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <3eeda38b-0bfa-4b46-8088-303f78b5f340@baylibre.com>
Date: Mon, 18 Mar 2024 17:48:39 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iio: adc: ad7944: simplify adi,spi-mode property parsing
Content-Language: en-US
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
 Michael Hennerich <michael.hennerich@analog.com>,
 =?UTF-8?Q?Nuno_S=C3=A1?= <nuno.sa@analog.com>, linux-iio@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240318-ad7944-cleanups-v1-1-0cbb0349a14f@baylibre.com>
 <CAHp75VfKZy45RVJmAAOEPyUFTW7MhxJmOeQHj3YV7p-NPKpkvg@mail.gmail.com>
From: David Lechner <dlechner@baylibre.com>
In-Reply-To: <CAHp75VfKZy45RVJmAAOEPyUFTW7MhxJmOeQHj3YV7p-NPKpkvg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 3/18/24 5:43 PM, Andy Shevchenko wrote:
> On Mon, Mar 18, 2024 at 11:57 PM David Lechner <dlechner@baylibre.com> wrote:
>>
>> This simplifies the adi,spi-mode property parsing by using
>> device_property_match_property_string() instead of two separate
>> functions. Also, the error return value is now more informative
>> in cases where there was problem parsing the property.
> 
> a problem
> 
> ...
> 
>> +       ret = device_property_match_property_string(dev, "adi,spi-mode",
>> +                                                   ad7944_spi_modes,
>> +                                                   ARRAY_SIZE(ad7944_spi_modes));
>> +       if (ret < 0) {
>>                 /* absence of adi,spi-mode property means default mode */
>> -               adc->spi_mode = AD7944_SPI_MODE_DEFAULT;
>> +               if (ret == -EINVAL)
>> +                       adc->spi_mode = AD7944_SPI_MODE_DEFAULT;
>> +               else
>> +                       return dev_err_probe(dev, ret,
>> +                                            "getting adi,spi-mode property failed\n");
> 
> No need to have 'else'
> 
>                if (ret != -EINVAL)
>                        return dev_err_probe(dev, ret, "getting
> adi,spi-mode property failed\n");
> 
>                /* absence of adi,spi-mode property means default mode */
>                adc->spi_mode = AD7944_SPI_MODE_DEFAULT;
> 
>> +       } else {
>> +               adc->spi_mode = ret;
>>         }
> 

I agree it is better that way. Will send a v2.