Received-SPF: pass (google.com: domain of linux-kernel+bounces-106845-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240318-apss-ipq-pll-cleanup-v1-0-52f795429d5d@gmail.com>
 <20240318-apss-ipq-pll-cleanup-v1-2-52f795429d5d@gmail.com>
 <CAA8EJpo2Vo-XqstNk69dWW8pqNkGi0tz3UmHY7j6LLKd-yH22w@mail.gmail.com> <09c91419-8bce-49dc-86d1-3ed1b9f28ee6@gmail.com>
In-Reply-To: <09c91419-8bce-49dc-86d1-3ed1b9f28ee6@gmail.com>
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date: Tue, 19 Mar 2024 02:09:36 +0200
Message-ID: <CAA8EJpq+PUavezxAwpStm98_3uW7HQraFyUdr6uwZCNHJ4yU5w@mail.gmail.com>
Subject: Re: [PATCH 2/5] clk: qcom: apss-ipq-pll: use an 1-D array for Huayra
 pll register offsets
To: Gabor Juhos <j4g8y7@gmail.com>
Cc: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, 
	Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, 
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 18 Mar 2024 at 23:23, Gabor Juhos <j4g8y7@gmail.com> wrote:
>
> 2024. 03. 18. 15:16 keltez=C3=A9ssel, Dmitry Baryshkov =C3=ADrta:
>
> ...
>
> >> +static const u8 ipq_pll_huayra_regs[PLL_OFF_MAX_REGS] =3D {
> >> +       [PLL_OFF_L_VAL] =3D 0x08,
> >> +       [PLL_OFF_ALPHA_VAL] =3D 0x10,
> >> +       [PLL_OFF_USER_CTL] =3D 0x18,
> >> +       [PLL_OFF_CONFIG_CTL] =3D 0x20,
> >> +       [PLL_OFF_CONFIG_CTL_U] =3D 0x24,
> >> +       [PLL_OFF_STATUS] =3D 0x28,
> >> +       [PLL_OFF_TEST_CTL] =3D 0x30,
> >> +       [PLL_OFF_TEST_CTL_U] =3D 0x34,
> >>  };
> >
> > Can you please move this to clk_alpha_pll? We can then drop it from
> > clk-cbf-8996.c too.
>
> Sure, I can do that. By any chance, do you have a suggestion for the name=
 of the
> new enum value to be used in the clk_alpha_pll_regs array?
>
> CLK_ALPHA_PLL_TYPE_HUAYRA_IPQ seems too generic, and it would be a bit
> misleading using that for MSM8996 CBF.
>
> CLK_ALPHA_PLL_TYPE_HUAYRA_IPQ6018_A53 is quite long and it is also mislea=
ding.
>
> Maybe we could use CLK_ALPHA_PLL_TYPE_IPQ6018_A53 which is short and uniq=
ue
> enough and we could add an alias for that like CLK_ALPHA_PLL_TYPE_MSM8996=
_CBF or
> something similar.

HUAYRA_APSS ?

>
> Regards,
> Gabor
>


--=20
With best wishes
Dmitry