Received-SPF: pass (google.com: domain of linux-kernel+bounces-106866-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <1197b7f7-c43b-4ae6-b914-9e3f547810bb@amd.com>
Date: Mon, 18 Mar 2024 19:37:42 -0500
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH 1/3] dt-bindings: remoteproc: add Versal platform support
To: Conor Dooley <conor@kernel.org>
Cc: andersson@kernel.org, mathieu.poirier@linaro.org, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 michal.simek@amd.com, ben.levinsky@amd.com,
 linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240315211533.1996543-1-tanmay.shah@amd.com>
 <20240315211533.1996543-2-tanmay.shah@amd.com>
 <20240317-overturn-frozen-b152dc552a2f@spud>
Content-Language: en-US
From: Tanmay Shah <tanmay.shah@amd.com>
In-Reply-To: <20240317-overturn-frozen-b152dc552a2f@spud>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eU1IajFSQXZvQmUyVWhjcTBMcXUwQnZzUlJ0S1B6QTdXaGo4ckRTNk9NdWZV?=
 =?utf-8?B?NjhTcEhqOEFMekZMVnJRa0xCTmFBeUNkOTljTGVLSGU2aUNVbFYrYWhNbDhF?=
 =?utf-8?B?U1JwZmFsakgvYkVFWTJjdHpEUW1aSUxaOWpQWkNHN2hKeURaNUxaL1hUN1dw?=
 =?utf-8?B?ZDFyZWoybXhYWDZ2K0RZNEdSdFZVSXVrcnhkZ3A2WmdkYkJNSVFiS1llRG1z?=
 =?utf-8?B?YmtzcUhJc3puejV0UE55cFNpODNQd2pLNFRGNStKRUR4TStLRnZhaEEvWldx?=
 =?utf-8?B?NXZtaTlpSW41REljQ0Qwcm1rNkcvcXZIVVg5ck9sYjZQVGxld2hsTStoOSsv?=
 =?utf-8?B?cjN6SVVkTmtXNCtDcUROU0k0bU94dnV4bHY5ZDl6b2FFdGVKYVB2U29NR1lv?=
 =?utf-8?B?dDdlUXlOc3ErOXI0UURCR3JpSDlOS2hpU2kyNXlnbk5sRDhnMUY5dDZJQjZj?=
 =?utf-8?B?RUdHZEkrVFl1RkR1TXFDTkdxZE94VWNQVTk3dUVWcXBXVlM2VFpZNmlxSEw2?=
 =?utf-8?B?OUN4R1JpUy9UZzRQY0FlelEzd2c5SWpsMnh5dW4yMHl2TU9lVmdhUEVveDVH?=
 =?utf-8?B?YWFYMTBuY2RYd0ZaMVhkRHhhaGJQVTErQk4xdy9VODZ6OStRWFgwWFdlSzRn?=
 =?utf-8?B?RE9GdkVQNzRmcHRBMzVzMUJJOEx0R0dmajJ1aTVQTTRHTmFxaHhkV0VSNjV3?=
 =?utf-8?B?OHFyMjByNzN1RUliRjdQWDNaTy9XWjE0dXgyUFMrTGpmTmpRQnF1Ump5Y2g1?=
 =?utf-8?B?TytHamdjTnUzRWR4M0U3ZThLMjhRNmtaQUxmS1l1UXh6MmpoRm95S3lHYjMx?=
 =?utf-8?B?N3dpTFVxdmdrMllsRVhPTGRSSGlKVEIrc05DWjB3SHp6aDBSc1M4bVJCZElB?=
 =?utf-8?B?c1h0ZXh3b3l4Y3BJV2VYVTUxKzdkRXJNM2Q0TXVQdTlmWCtQc09nRmszd0RC?=
 =?utf-8?B?WlRUcUtrU0Q4VGtIYlFLamxTNHZQOTFUMTUvVXpUcFhUcFcvcUZXYTIzOHM5?=
 =?utf-8?B?cDl4UGNGYkRzeTRzbFNERE5rMm5oOUtRV0ZLVk5tRzcrQ3d1K2NFMk1LUWhS?=
 =?utf-8?B?clJlVnVkVFUzeUF3SUYyWlFZcHd0NkhGR0tTVGE1UmtVVzFGczFwL3hYb210?=
 =?utf-8?B?eXRQTVRqMlUrRGtHeEcxTWplc1owVW1wOEFMakFiQjVuUTREelpMUGpMakxB?=
 =?utf-8?B?L1pueVhPT282ZEdoMWhTbERBVW9SNGwwR0J0UXZHNS9CWkE1bHl1WEp4UE15?=
 =?utf-8?B?K2N1cWNPOWFZcENvYmhRdFJ5QUI2a0tSU3Q4WnlSMVZVOVlOUmptTDZmZzVX?=
 =?utf-8?B?eEY3ME5rV2x0NmR1UVhmMnZYcjlCNzZaZWRzRnQwODF4NHM1ZTBkdEtlMUlS?=
 =?utf-8?B?Zm1YSzZyamIrTVhkMUJtdU05WEpYUk4va3FaS3AvWGFGbUl6aytBbEJEaUhY?=
 =?utf-8?B?YW9nRFVZUDY5ZytEZVBxVmt6RU9iNjZ3L1k4S3cvcnB4NkYwUEIxRFhDYW9V?=
 =?utf-8?B?R2Jla1FtQ1lSOXBXSWRRWlhUV1VmRk1xblk2VFY1a3RTM2M2VVY3RUlmREh6?=
 =?utf-8?B?TExHdEN5REZNdytQQUxVNEh6T3VYT0JvbkNEdnRyNzlUdEdJdHRwcTNXWVVL?=
 =?utf-8?B?S0FjYUE1R2htNEVLV0VXMWFucnBxV1JkcDY5bmxYbGUxZmdWc0dwNTlNbDFH?=
 =?utf-8?B?aWJneUs4MVo0Y1hQTFMxcmNMczBLVUxRamhtM3FUNTE2bVlXT295Vk5POTJk?=
 =?utf-8?B?YUpyU1dCQ1FKaEo2dUNTVzZpUlpvamdsRjZUSk1RcTl4YTI3UGZoYktlcm1U?=
 =?utf-8?B?UlNiTTB3SEpuQklIWGRJQ0dXMWM0ZmkyWHUxYTBjL1c4Y2R0d0JCN1Mvd3F4?=
 =?utf-8?B?Q2NSaWNkeU9vSXFXRm80ZTRKWnR1UjVOVHF1b0V1cWVkQiswVFFnNmhsbVY1?=
 =?utf-8?B?WHJ0VUpicURKbVZsTzdCbW14c2t1dTFKenZyZ2NTSjhkNm9pY0tCWkNPTHNU?=
 =?utf-8?B?U09uQVpUZEhMd0FKNE9EZU9UWld6L0ZPZWw0NmVGVmJVSE11WCtVZVZyQ2lC?=
 =?utf-8?B?WEhuQWtiQXVZZTk5eDhZa2cydFowZTZ5WFF4OFFBL1ZiUVAvRW5JWGVGQkpL?=
 =?utf-8?Q?SostVpEFo3fc7fF5KF+GWOozg?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0778848-b312-4eae-3d70-08dc47accb22
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 00:37:44.8875
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RO01Lu+FTFPie2c7zWfz8kgWHhY00jyNg/pVV4KLzO4xTyw0cqhO8DKRPLe16pcx
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6189

Hello,

Thanks for reviews, please find my comments below.

On 3/17/24 9:50 AM, Conor Dooley wrote:
> On Fri, Mar 15, 2024 at 02:15:31PM -0700, Tanmay Shah wrote:
>> AMD-Xilinx Versal platform is successor of ZynqMP platform. Real-time
>> Processor Unit R5 cluster IP on Versal is same as of ZynqMP Platform.
> 
>> Only difference is power-domains ID needed by power management firmware.
>> Hence, keeping the compatible property same as of zynqmp node.
> 
> No, don't be lazy. Add a compatible with a fallback please.

It's same IP on different platform. I am not sure how adding compatible string
adds value. I will refactor this series based on other comments provided.

> This doesn't apply to linux-next either FYI.

Actually cover-letter contains dependent series link that is needed for this
patch. That series was acked recently but hasn't made to linux-next yet.

I may be missing something in the process. In such case there is no other way
to send patch except for waiting?

Thanks,
Tanmay