Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp606528lqt; Mon, 18 Mar 2024 19:20:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXaJfQOps2y5DyDofGdR5ufT7a/CQ/XJbxcAehEtTzKchWL8DNKvrL4KTPFX1YpzTxAbZm20mywgKNi4WjE6D6fz1sNKig/ruxbIyispw== X-Google-Smtp-Source: AGHT+IHUQIfzUmMrMHSYC2WeaszKPRl2vaJ3TYL7DlCkzm5yt0yWbicoIHWrBzbrxsne/nJQ2SXR X-Received: by 2002:a19:691c:0:b0:513:d3c0:f66 with SMTP id e28-20020a19691c000000b00513d3c00f66mr8182930lfc.51.1710814823968; Mon, 18 Mar 2024 19:20:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710814823; cv=pass; d=google.com; s=arc-20160816; b=yfEEqKvvG5u3QZmm5caHS5xfy/6uk6vKUvp0IR11zaxcxmQpYQcE9FjK1mCXsoPJcA 3amUwnLyNY09nDR7p+mPIMGY1fi2eZqDViJu9uEsKTin2MLHja5rFf4jxObS4TT/foi1 NACZ1McZY63Pvpnw+Rj5Vm4eijV7uC0ah95FVE3MetFg+xlHH6aLBJgSV5joIvJBb/5l Op5mfN+bxBsBBuyFdX+o+ZiSWQe8V4RDNJHF1DrExsD0Dad83s3UEEWyC5/VJd+o4/70 lnVFiEHqeGPMQwp40WLPG+B9+CpjgT/wh3xqkxK/8+6+17zewf7wdGNMdvpO4xu0Cz39 avDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:to:from:dkim-signature; bh=k6rINp0way2lyVv3peFrobuPlDokerF7vmkwEfe9Xuo=; fh=6joi1ZpP6zJT9PqsDf7qiLYs+4YElGuAnVOxg7AwKqc=; b=N51Jy9YAy0yxCdP6FtWWAm3IJXc8yBU4kR/b3MlXATzh72Bx8mP+oOMphXyDHMFDAo 5rGUaf1kJOx/xHXB549FQCij2PrUU71ljCTdp9c7xDEYoV60eLA1F1O+fwGLzpt7qrHV 6q5qdtNHfl78ba4gjBVLJi0M28OTIdmc5dO/1YdkcE5Actuw9ArMmHqClaQ9N8/H9Eje LHSrLFAcYuduf2RVrJNHp5nB6H0V4FeGFmL3O3IedmNS+NL/gFIBio+KTgPb5kiM44MA Ml+EyrtG1utvbnIAqZieUDAO0WmAjo4hCkc67LcqPSM6b8xkwU11IGMPsXVOOysT39EQ BSRQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=1OU6lEyn; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-106914-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106914-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id d11-20020a1709067f0b00b00a4531dfb191si5061398ejr.84.2024.03.18.19.20.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 19:20:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-106914-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=1OU6lEyn; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-106914-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-106914-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id ABA0D1F21EC8 for ; Tue, 19 Mar 2024 02:20:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BB50964CFF; Tue, 19 Mar 2024 02:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="1OU6lEyn" Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D9BE2F22 for ; Tue, 19 Mar 2024 02:20:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710814814; cv=none; b=SA+Ce75jIdvrT6T/YtRkJJN8g10JE4aduyraHbQ0S8+GHCEjTva8nvbBFLVFtven0OhI3tbcMg3C753wD7AYJJmAfsTx5Fzrc9wTzjT7qWr5kmlgR4JgiNSq+nDcrORy2vYf2pKM7Nc1Sy15T7j2Xbt+FArfITql8NorvZ3K+qY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710814814; c=relaxed/simple; bh=NkB88W5odC1JOVEAvvKJhHDlY4baHLv2+zt6C5wYeU4=; h=From:To:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=TbPsTo07Sz0lC5U4kdbQ9vEjluRcUr7zTtL2hYL3UE4rvDu/05l9ejf6MqjaAkKkRjZ+VCgipHr1r2ixk9SozLbKbAapfhb5VoGYcjvX7POV0v1/HAHWqZiVH+wuqOgFVqEfg5PYgLfa8tHUDQHEAnF1DauTH3WNfac5WhZ6Qwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=1OU6lEyn; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-29df844539bso911870a91.1 for ; Mon, 18 Mar 2024 19:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1710814812; x=1711419612; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:to:from:from:to:cc:subject:date:message-id :reply-to; bh=k6rINp0way2lyVv3peFrobuPlDokerF7vmkwEfe9Xuo=; b=1OU6lEyngpVvbebxokTite4Ph3MAyg/wB+BWB1xnerJHDGHuqVSmwTWUkFNQNUUxBG JvbEWeArhs8oT4FEu2brMF/V7suKaHvx/CRmH9NtxERYfYQRQizTevL8040l9Xxhukmx 9F5aTFkr9B2Roo2ODvzlzMtJi3uhXUTJlGTVVg7aLUe4prZgXvr9BL0T+89CvBMY3pw0 gbrSCqJkmSRMhqosmcA8CXT4pZO38Jb3/mfD/TPY/Fx0oxegW4oSJihHi4JjB9AaSjlJ /rltEE1BfT4DCLcf0htIUgj96YMs9FDCtHx1v5GezzYmOW5PWh+H8KVvvET3pMEJzVdA OtsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710814812; x=1711419612; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k6rINp0way2lyVv3peFrobuPlDokerF7vmkwEfe9Xuo=; b=WfSmincfBfxFVEbvSAsF3uRoBqbP0dXHkBAYuXNtpaV30UOLPd6EQzjUuT5ou+sIPW PpIIiIYfZQr2k9Xil7IbHh/oa6JPEDRPHqWEPR7A2pm38mQqS0f817r7di+BsKBqdMg2 2ZfBaerbRleqfoH5QpI4MEZNyu3I4aeR5+LpB/AYK6HmSH9zFTzCT6mO4RExKh81D9L3 x8ip8ciZySfKIkcoCHxL6jA74TEOzvBEZb5eFQVxDOp/ok07+mUYhpWBVPGYWn/w5oA6 GAEejVamhpG4e26JGK1YbMF3jajWY5X38IzNB8ezUquZNiU+zfXgQMzWfaY2dcSPD/Pe 1QMQ== X-Forwarded-Encrypted: i=1; AJvYcCXfC2ICVsIgsx3cd4wrjNLtWF+M0/X6pat+jtQlA+XqbR7709FOcsWTyYKWPPzc4CWBEIV9uWiWjQ+3LbFfOKWFbtJ71UtWUyrQVPx4 X-Gm-Message-State: AOJu0YxgENYSpyWGMV8AtqNx8AA40Ze5UGL8wKOmlPeme75EBjQWmsAA ZopigWVztAUwyvRrEB7tCMPUqT+17prJICAPNRxP1AuRvjVp9Q0z31oWvC6TB3OonOR/32nfTrg a X-Received: by 2002:a05:6a21:9982:b0:1a3:713d:1059 with SMTP id ve2-20020a056a21998200b001a3713d1059mr1022446pzb.4.1710814811772; Mon, 18 Mar 2024 19:20:11 -0700 (PDT) Received: from [127.0.0.1] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id z3-20020a170903018300b001e00295e3dbsm3062473plg.149.2024.03.18.19.20.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 19:20:11 -0700 (PDT) From: Jens Axboe To: Denis Efremov , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Yufeng Wang In-Reply-To: <20240319014219.7812-1-wangyufeng@kylinos.cn> References: <20240319014219.7812-1-wangyufeng@kylinos.cn> Subject: Re: [PATCH v2] floppy: remove duplicated code in redo_fd_request() Message-Id: <171081481063.643317.5474387504952434927.b4-ty@kernel.dk> Date: Mon, 18 Mar 2024 20:20:10 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.5-dev-2aabd On Tue, 19 Mar 2024 09:42:19 +0800, Yufeng Wang wrote: > duplicated code in redo_fd_request(), > unlock_fdc() function has the same code "do_floppy = NULL" inside. > > Applied, thanks! [1/1] floppy: remove duplicated code in redo_fd_request() commit: 50171b8667733146f139c773d8f00866ceb4cee4 Best regards, -- Jens Axboe