Received-SPF: pass (google.com: domain of linux-kernel+bounces-106951-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 19 Mar 2024 10:49:16 +0800
From: Oliver Sang <oliver.sang@intel.com>
To: Christoph Hellwig <hch@lst.de>
CC: <oe-lkp@lists.linux.dev>, <lkp@intel.com>, <linux-kernel@vger.kernel.org>,
	Keith Busch <kbusch@kernel.org>, Max Gurtovoy <mgurtovoy@nvidia.com>,
	<linux-nvme@lists.infradead.org>, <ying.huang@intel.com>,
	<feng.tang@intel.com>, <fengwei.yin@intel.com>, <oliver.sang@intel.com>
Subject: Re: [linus:master] [nvme]  63dfa10043:  fsmark.files_per_sec 6.4%
 improvement
Message-ID: <Zfj9LGMEjMEaN2DS@xsang-OptiPlex-9020>
References: <202403151552.e3809b61-oliver.sang@intel.com>
 <20240317203645.GB5975@lst.de>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240317203645.GB5975@lst.de>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?r+6mGVVwjaDxOcpjsS1EtMcwdhd0rG9ZqObffswz0oPYZG2tH8YhHTfBeGtO?=
 =?us-ascii?Q?uMJtDwnT7LAMSnlP/fqarJGx1Tp7YUSIuQ0RlrLkjOTBbd+1JlpsUtHF/U8l?=
 =?us-ascii?Q?Kr/QGuZeUOthjHd5211mA/o/4+ZixxqUmmZs54Qr8/RGH/eGxFcBCl/EyZzw?=
 =?us-ascii?Q?OKS4njdnafOKVFCA189BVxUrhVkS0rNOfugsEO3GRRhXUvv507XfPK5Ktanv?=
 =?us-ascii?Q?SzGRirv5eCUU9NOUYfxQuKekWgngXSazpW7kyZJlwuh82Imm7HGlRQZcvxMM?=
 =?us-ascii?Q?QFKjeFZS19kohsenq7AuxRgi64sDOVCfJR+a+6mXVKgXcCg6rsdZR36hDPY4?=
 =?us-ascii?Q?fB+6DRxDNkB+wSq6Wng0Sr+hhNh3M1as808Snb6qv2/0pM9jKVBkfrPAhkhD?=
 =?us-ascii?Q?uLdiMxszt7Gsu9RkHcaEJTJ/RJc6SB3lrNV5ulm460ITreOWV9nIekqnZnXK?=
 =?us-ascii?Q?+49KtNbqg49x8evya4l3D8Oj2Gnvc9XIGQutdJqokAUqDIJuw6Hxb4JvhmZp?=
 =?us-ascii?Q?1KEs/Q5zEgQkL/jNSKphoFVk53qygGMIY/QjZU187IAIN7+ZGUENrZcIKXHq?=
 =?us-ascii?Q?SXT+WNoGhyCZBNzL1ZabPFYBj/JD3JikZm6wr5pvbyAUq42VFxHcRrSn8snw?=
 =?us-ascii?Q?WyvBbXTdsEJDgq6R98ExJc+tA5ggZbYIux/n+c1wtGFiTB0mlSBFCG7fxsK4?=
 =?us-ascii?Q?OxeUqn87h9b5qzo37jQXheZK0VZz0e2427ladbw1ZU3IxQSu/4ZBNJQ3XJ5+?=
 =?us-ascii?Q?pboqRA9/6+41Qt/9Eo/51ljzRbIqvDZSamNI/Rt0hcOv7LofQL3iqDV9ABRf?=
 =?us-ascii?Q?hGxwvo3VznhoI9kXjwdlywQh+xlXvEbAIqZD0JAlw5ILRQMSPWg/k6GLI9LD?=
 =?us-ascii?Q?Je6Zp9+rkFJhCVr0+7ns0Vcq8qejnw48ZCWNi07WtdWF4gfco5ZjjFydpU56?=
 =?us-ascii?Q?Oxsk1bCBfx4MlgxFRjXDnS7gI+ZnoCbBdKW8yiPvqJ6HXCIboroOsUjfEQQe?=
 =?us-ascii?Q?JWG1EN1qQFh8UiYfagPcltb39RU/m7Fk9a46AREaK3w3sz8HgCz1zWK2OoRL?=
 =?us-ascii?Q?qkRl9TR09XrpzyxusYBqQHo5FNfmILkCop4B3Pwr5mgRhB5KDQvYhpAtdSvw?=
 =?us-ascii?Q?V9R/n/o4LieoIQWTwqM5rQab/lCAAZbdbNIFTYkbfUup0ueT5XsiiDOnruCZ?=
 =?us-ascii?Q?1EK38Q2gtVfaPs3V6hVzCuIMD5PJpqYyyZwCK2tLzXwGgmvETGbKz4cq3Lc5?=
 =?us-ascii?Q?A8ZxxIrAnY8EfYqVJ7RuS2/FiGlBIWjK5aWfx3Jr+Azn0dlxTbJOv6Q/6VTU?=
 =?us-ascii?Q?vHSlwf8rHQncSV+zx3antlPwa53NGZ51N/RIIaD1y4JLpB0j8kagqi0hLDnX?=
 =?us-ascii?Q?hKzIPcyAvS67vVaUcw20c1ofgK+ieNsXRpmZ6ueY7yBdEefOHD99XquMxX7s?=
 =?us-ascii?Q?LIhLxUgEMAMIrvdMppFTOIMekCWs1wv+JP56X3Vkb7a1N3WZ1nhs3PWV1tio?=
 =?us-ascii?Q?nqN8+7hLzy+JnaFp9iN+qNYXscpJt4xaXYo5AqNjSMf8QcAeDe9gsHr4qM2B?=
 =?us-ascii?Q?hJhjtcGmpxXurLj+AY3XKAoLYoxZk/4+GMuJgUoi9JNFl4/yfpfbrHJHcSXV?=
 =?us-ascii?Q?xg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 33e9dfd2-4137-4b5c-2434-08dc47bf3009
X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 02:49:25.0847
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iBCAtT6xENTItun8pN2dUyP0frn20t+lJcqPLOZSJarywSps2JuNiGG4ILrKHJrzSVzu5JceG6a9NUvB7kOW7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7394
X-OriginatorOrg: intel.com

hi, Christoph Hellwig,

On Sun, Mar 17, 2024 at 09:36:45PM +0100, Christoph Hellwig wrote:
> On Fri, Mar 15, 2024 at 04:21:13PM +0800, kernel test robot wrote:
> > 
> > 
> > Hello,
> > 
> > kernel test robot noticed a 6.4% improvement of fsmark.files_per_sec on:
> > 
> > 
> > commit: 63dfa1004322d596417f23da43cdc43cf6298c71 ("nvme: move NVME_QUIRK_DEALLOCATE_ZEROES out of nvme_config_discard")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > 
> > testcase: fsmark
> > test machine: 96 threads 2 sockets Intel(R) Xeon(R) Platinum 8260L CPU @ 2.40GHz (Cascade Lake) with 128G memory
> > parameters:
> 
> That is kinda odd and unexpected.  Is this system using one of the old
> Intel SSDs that this quirk is actually used for?
>

yeah, the nvme sdd on this system is quite old (DC P3608 serial):

https://www.intel.com/content/dam/www/public/us/en/documents/product-specifications/ssd-dc-p3608-spec.pdf