Received-SPF: pass (google.com: domain of linux-kernel+bounces-106992-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0
Subject: Re: [PATCH v2 05/14] mm/sparc: Change pXd_huge() behavior to exclude
 swap entries
From: Muchun Song <muchun.song@linux.dev>
In-Reply-To: <20240318200404.448346-6-peterx@redhat.com>
Date: Tue, 19 Mar 2024 12:25:39 +0800
Cc: LKML <linux-kernel@vger.kernel.org>,
 Linux-MM <linux-mm@kvack.org>,
 Andrew Morton <akpm@linux-foundation.org>,
 x86@kernel.org,
 Mike Rapoport <rppt@kernel.org>,
 Matthew Wilcox <willy@infradead.org>,
 sparclinux@vger.kernel.org,
 Jason Gunthorpe <jgg@nvidia.com>,
 linuxppc-dev@lists.ozlabs.org,
 Christophe Leroy <christophe.leroy@csgroup.eu>,
 linux-arm-kernel@lists.infradead.org,
 "David S . Miller" <davem@davemloft.net>,
 Andreas Larsson <andreas@gaisler.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <744C19CB-4AE0-472B-ABD8-2064EB04FDA0@linux.dev>
References: <20240318200404.448346-1-peterx@redhat.com>
 <20240318200404.448346-6-peterx@redhat.com>
To: Peter Xu <peterx@redhat.com>


> On Mar 19, 2024, at 04:03, peterx@redhat.com wrote:
>=20
> From: Peter Xu <peterx@redhat.com>
>=20
> Please refer to the previous patch on the reasoning for x86.  Now =
sparc is
> the only architecture that will allow swap entries to be reported as
> pXd_huge().  After this patch, all architectures should forbid swap =
entries
> in pXd_huge().
>=20
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Andreas Larsson <andreas@gaisler.com>
> Cc: sparclinux@vger.kernel.org
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> arch/sparc/mm/hugetlbpage.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c
> index b432500c13a5..d31c2cec35c9 100644
> --- a/arch/sparc/mm/hugetlbpage.c
> +++ b/arch/sparc/mm/hugetlbpage.c
> @@ -409,14 +409,12 @@ pte_t huge_ptep_get_and_clear(struct mm_struct =
*mm, unsigned long addr,
>=20
> int pmd_huge(pmd_t pmd)
> {
> - 	return !pmd_none(pmd) &&
> - 	(pmd_val(pmd) & (_PAGE_VALID|_PAGE_PMD_HUGE)) !=3D _PAGE_VALID;
> + 	return pmd_leaf(pmd);;

There is a redundant semicolon in the end.

Thanks.

> }
>=20
> int pud_huge(pud_t pud)
> {
> - 	return !pud_none(pud) &&
> - 	(pud_val(pud) & (_PAGE_VALID|_PAGE_PUD_HUGE)) !=3D _PAGE_VALID;
> + 	return pud_leaf(pud);
> }
>=20
> static void hugetlb_free_pte_range(struct mmu_gather *tlb, pmd_t *pmd,
> --=20
> 2.44.0
>=20