Received-SPF: pass (google.com: domain of linux-kernel+bounces-107016-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 19 Mar 2024 13:37:53 +0800
From: Huang Rui <ray.huang@amd.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: "Yuan, Perry" <Perry.Yuan@amd.com>,
	"Limonciello, Mario" <Mario.Limonciello@amd.com>,
	"Shenoy, Gautham Ranjal" <gautham.shenoy@amd.com>,
	"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
	"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
	"Petkov, Borislav" <Borislav.Petkov@amd.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Huang, Shimmer" <Shimmer.Huang@amd.com>,
	"Du, Xiaojian" <Xiaojian.Du@amd.com>,
	"Meng, Li (Jassmine)" <Li.Meng@amd.com>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 0/8] AMD Pstate Fixes And Enhancements
Message-ID: <ZfkksfgB9cIUkWlu@amd.com>
References: <cover.1710754409.git.perry.yuan@amd.com>
 <CAJZ5v0iQnJCVX0kHNxtOWLcnTXRRjR1HZ6m4CFhKZcQVp1SbEA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJZ5v0iQnJCVX0kHNxtOWLcnTXRRjR1HZ6m4CFhKZcQVp1SbEA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?d1JFUERjRUZ0MUpsL1U2MDVMVGZRVUdZZnNCNGJIMVdQY0I2RmNMak1BTVFi?=
 =?utf-8?B?S0hkcGJvQzUvM0hsb1lrOEU4cjhuaWxWR0tHUjIrNTVtYkhYYWZQR3pvbWxk?=
 =?utf-8?B?UmdtMVdqNFJYa0piZ2NzL0FDRmZSaFRqWmNqZk51aWxtL1QzdVVnZUc1RGVI?=
 =?utf-8?B?UG9EVTk2L3J1VVVMcXRyYUlrS0JiYmYzMXRYZUxZMlUzWEF3NGUwdnpVaWVp?=
 =?utf-8?B?NEJKOUFoaGtXQVdhbkJxZlk5NWJSb3RzaGpvQ3o5c1JBRjcvdEpDQk5talBY?=
 =?utf-8?B?MVJWT1pmTTRhQ1VacTA2Tlg0RGRkSHJRRjc4d2thUUFnc3o4QittWDE4ZkRp?=
 =?utf-8?B?dHZ3MkE1REpMdHVLeW1aTFhBNUR2bUpiRVNPc1NVRzhNYitsS1k2OWp4U2ds?=
 =?utf-8?B?SHZHNlhMeTh4eDdvZHpYdnUvVUtPNnFZM21mSFBMbWhUWGQ1ZzJwcy9TclJF?=
 =?utf-8?B?RlVGZzZ3SVZNN0QrTGNrUzlJUWdOR0thK2hWRjIzdWR6dDAvOVVVV01kNHpo?=
 =?utf-8?B?dkhabzdVcU5yQTU2SVBZNGZkODdKWlFWNkgyTGkrUTFkTS9sRWx5QmtCOGs3?=
 =?utf-8?B?eDVnYlpTekNyVmk2UmJtMVJRam5USHNUckVqanNkVUdOWnpvOUlLdFNCUmcv?=
 =?utf-8?B?cUhiUk81dUhxQ0FOZHdkVTlUL0VDN3pqUXdFUW4vaXdpZDBCd1A0d3FGUDU5?=
 =?utf-8?B?MXB1MmlXU3BUV1RjZ2FCTXVUTjNhdGtYVmpNdkNxcnNKSlMwM2xwaUNFaHVQ?=
 =?utf-8?B?RURXNlg0bEh0MGxhQWE3Wkl1azduK2RCUnZXSG5rbVdxZlMwSlpCcnhRYU12?=
 =?utf-8?B?cU1TZGY4ZU15U09DcEc5OGlEcVJNVks2VklvS1gvbDR5V21FdXhEckpQTFo3?=
 =?utf-8?B?bG1kaUJpbkNnU1JvUmUvT1NhazBPdFhNV2pSZ21YSVF5eVgrc1FjY1JYbEhy?=
 =?utf-8?B?b3VuOGs3bE5yMnZEN3FxSDh6YXMvS1V0d3Rlb1d2VTVYaXFQRTdTcnNtWGZ2?=
 =?utf-8?B?U0Nja2JIRXJ0Rk41VGRDM0NOSi80Q0k2ZWdXakRYMXE3OGp6cXBsZDZTQmFw?=
 =?utf-8?B?MXVCQWZwNXJMdVlkSzkvUUdaSFJ5UksvVW9BbXZNZXdwUXVYMm56RjZncSs3?=
 =?utf-8?B?ZEF5Mk8wclRQaXp2aW83MExNOU1TSXp6WDJvVUpoM3duMG52YmNoTy94R0RU?=
 =?utf-8?B?aWdWNlVFM2MxOUI0N21hdUhTeFNKWmlqREpMQW9scDNuNDhUQjFHVy9ITEdx?=
 =?utf-8?B?VGZiZERqTzkxRW1oQXMveXNZSGxubW93OU80aUxPQWFvM21pQWl6MWdJczR5?=
 =?utf-8?B?Y0xxNTNQWXByRUNtM1ZSbmJZYm9DTVZWR3BsUlI1SnBEUy9TazgyKzRpRXNL?=
 =?utf-8?B?TE9KZHltV3hheVE0SWNSQWtRNzVFcThLQlF2SEt3L201NjE3ODZpczBNR1c4?=
 =?utf-8?B?OGtJNUlUOG10UUo1V2dodTN1QkRjc2lnOVFGM3hmRG5QNGNuSlBEZTRXcWlZ?=
 =?utf-8?B?dFBXRzFuMEpaRys2b201ZjhMd1FwajA4NWtDaEkyRlVqd2lmV1d3Y1dhcytN?=
 =?utf-8?B?ZGx4dWtxdTV3WHVlUk5TWHJGeEYwb2ErcW5lb2Q1cHk1cUo2Q1dEZGZWNVhO?=
 =?utf-8?B?Y0pGejU2OWV6QkQrajczcDBmRTVEVitjRnkrL2JyN284T0dVbGhUbEVEa29n?=
 =?utf-8?B?T3BBZG04WWZUMmNKdzYxR1U0Z0Jld3lZOWgrOXZtRmRFbHRHMlZYZTRZNytK?=
 =?utf-8?B?cVpCbTZLNEw2L1ZNejZIMFlGeks3cVZWZ00zTUp1ckZJZVNTakN0Mi9ZOFdq?=
 =?utf-8?B?Nkx4Z2E3aGJndFAvWkxYMHFRNWR5UDlsdmllYmFscGJCRUFKOFU4bU4yY1FG?=
 =?utf-8?B?QkptSmttamlDMmludWRzYy9xN2JDSzlGV2hzeGR1U1A0bFAyNmkxUzVwTzNw?=
 =?utf-8?B?WEd6emIvNElWOExJSENpVERWaGZYanY4dTNNeVBJU1dHNGtlc3kzd29LV0w2?=
 =?utf-8?B?S2lTdVJrWVpLM1Y3TFRvRzA1RlYwL000a1kxYmhrV1JpN1JzMzhFRFdxVDVB?=
 =?utf-8?B?RkFxeGJEdUhLdWUvU250SFRvWTlZRTJzM0oyN2VzSDBvck03aUZDVnA2QVlB?=
 =?utf-8?Q?3bxpVdlbQrCIT64SmpDL4H6v0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6a19b3c-ce3b-4f02-3017-08dc47d6c59b
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8690.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 05:38:14.6874
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1AIaxCTABz+la8MRP5/mi/mN1uoraKUXbqT/LjkgQtOtZOeVxMwnda7lLdmf+XRwebRy8QqknjX71Jdbs9LImA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5723

On Mon, Mar 18, 2024 at 08:49:55PM +0800, Rafael J. Wysocki wrote:
> On Mon, Mar 18, 2024 at 10:48 AM Perry Yuan <perry.yuan@amd.com> wrote:
> >
> > The patch series adds some fixes and enhancements to the AMD pstate
> > driver.
> > It enables CPPC v2 for certain processors in the family 17H, as
> > requested
> > by TR40 processor users who expect improved performance and lower system
> > temperature.
> >
> > Additionally, it fixes the initialization of nominal_freq for each
> > cpudata
> > and changes latency and delay values to be read from platform firmware
> > firstly
> > for more accurate timing.
> >
> > A new quirk is also added for legacy processors that lack CPPC
> > capabilities which caused the pstate driver to fail loading.
> >
> > Testing done with one APU system while cpb boost on:
> >
> > amd_pstate_lowest_nonlinear_freq:1701000
> > amd_pstate_max_freq:3501000
> > cpuinfo_max_freq:3501000
> > cpuinfo_min_freq:400000
> > scaling_cur_freq:3084836
> > scaling_max_freq:3501000
> > scaling_min_freq:400000
> >
> > analyzing CPU 6:
> >   driver: amd-pstate-epp
> >   CPUs which run at the same hardware frequency: 6
> >   CPUs which need to have their frequency coordinated by software: 6
> >   maximum transition latency:  Cannot determine or is not supported.
> >   hardware limits: 400 MHz - 3.50 GHz
> >   available cpufreq governors: performance powersave
> >   current policy: frequency should be within 400 MHz and 3.50 GHz.
> >                   The governor "powersave" may decide which speed to use
> >                   within this range.
> >   current CPU frequency: Unable to call hardware
> >   current CPU frequency: 3.50 GHz (asserted by call to kernel)
> >   boost state support:
> >     Supported: yes
> >     Active: yes
> >     AMD PSTATE Highest Performance: 255. Maximum Frequency: 3.50 GHz.
> >     AMD PSTATE Nominal Performance: 204. Nominal Frequency: 2.80 GHz.
> >     AMD PSTATE Lowest Non-linear Performance: 124. Lowest Non-linear Frequency: 1.70 GHz.
> >     AMD PSTATE Lowest Performance: 30. Lowest Frequency: 400 MHz.
> >
> > If someone would like to test this patchset, it would need to apply
> > another patchset on top of this in case of some unexpected issue found.
> >
> > https://lore.kernel.org/lkml/cover.1707297581.git.perry.yuan@amd.com/
> > It implements the amd pstate cpb boost feature
> > the below patch link is old version, please apply the latest version
> > while you start the testing work.
> >
> > I would greatly appreciate any feedbacks.
> 
> There are missing changelogs and S-o-b tags in a few messages in this series.
> 
> Overall, I would like someone, preferably at AMD, to take
> responsibility for the amd-pstate driver, review patches modifying it
> and ACK the approved ones.
> 
> Huang Rui, who is listed in MAINTAINERS as the official maintainer of
> it, does not seem to be interested in it any more.
> 
> Can this be addressed, please?

Hi Rafael,

Sorry, I was occupied by other task a couple of months ago. I will talk
with AMD colleagues and figure out the way to make sure the amd-pstate
patches will be actively reviewed and tested. Will give you the feedback.

Thanks,
Ray