Received-SPF: pass (google.com: domain of linux-kernel+bounces-107057-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: <Raju.Lakkaraju@microchip.com>
To: <Raju.Lakkaraju@microchip.com>, <netdev@vger.kernel.org>
CC: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
	<edumazet@google.com>, <linux-kernel@vger.kernel.org>,
	<Bryan.Whitehead@microchip.com>, <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH net V1 3/3] net: lan743x: Address problems with wake
 option flags configuration sequences
Thread-Topic: [PATCH net V1 3/3] net: lan743x: Address problems with wake
 option flags configuration sequences
Thread-Index: AQHaecHQxa7+9A3Z0U+Frq/k0pXkjrE+kJyg
Date: Tue, 19 Mar 2024 06:00:15 +0000
Message-ID: <LV8PR11MB87002847609196ABF0D0568F9F2C2@LV8PR11MB8700.namprd11.prod.outlook.com>
References: <20240319055110.764002-1-Raju.Lakkaraju@microchip.com>
 <20240319055110.764002-4-Raju.Lakkaraju@microchip.com>
In-Reply-To: <20240319055110.764002-4-Raju.Lakkaraju@microchip.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+7nzg38Qh6RMBxb6MHzzUpJu9/q5a56d2ZRrj9VdrvZpNLxD9dReYDQXNjq3?=
 =?us-ascii?Q?fGard9JJUbMA0mw+7yljYL+pXC1wwww0qmmRwUTar5YupMvfz8mFfshS7B6B?=
 =?us-ascii?Q?8QD3M2rPEIvHsroIbqIEQ9/CEPplrIBGuGQhHrcviP+hTSmqPGHaP3KlI8/k?=
 =?us-ascii?Q?lv9J2abKSkOrKswD587hqRrkhj86b1su1HN9LEP38YxNPU8RCGTY34oUNZGy?=
 =?us-ascii?Q?JvVJPuWTmAq5S1N1hNP8Vgi97yfW2MzVCiK+pHXuNSf91LqLBSE0HRWmjjIb?=
 =?us-ascii?Q?iRgpd9Tz8VUiGbcDqtkF/FC2rL2mSMNzo1XExCse6c/9KjWAcwYP1RD4zHdg?=
 =?us-ascii?Q?CDGGZoXrKtSlhsuNmGmy0vBZBKefu1oK32EoX/thZjtRiDEja8QHPN9FCe/p?=
 =?us-ascii?Q?R83Rv1pkZEdwLWxaCCcXyceaaOxZ8ORAcZpLQvnRQyNnOLf/z6eGi0lUk8Vb?=
 =?us-ascii?Q?ow0Qes/FJBEvvntYsgif6rTBwpLzbmW2NuWIcU+8xSJU5bvPZFB9NTFnLOLn?=
 =?us-ascii?Q?CVFy82uhtgotcvA7buiR9LkpWetg24qzvcgGdVCqKJ17MAw1g3LJySPXP2z9?=
 =?us-ascii?Q?2NDkNTdFxARNmUvNew6IhzLYOzA8XV+OdJ4AKMxzNTHe+hzdyjmJMPY+iJFL?=
 =?us-ascii?Q?XcevgmUtBRezgiPgABSglajtrB2U3ql3a84hmcFxWzBVyGLvmWncHEMl+31A?=
 =?us-ascii?Q?fNG/Tqp66Ky1aagIRhD32EbZQRBSzQ2GPSFwoYYsnUi1VVTZQpdhlwJBANth?=
 =?us-ascii?Q?X4KbrdLUr09Tk8ZxXUCDvPAMU7BZi4vTg3B8xXJAIx0V4oPVz+Dlo58M1X/0?=
 =?us-ascii?Q?pZ7PLxXeZ1Hr/L7YrxpTJvWu6w+bMBIn+0itsZ8ppE/TIiblR+iHsiDwFeYZ?=
 =?us-ascii?Q?a63qpY2ok4YemUCopJWshPbHiZtLC03fiNmcowTE+jG2RG15lA0YdrIs8Kgw?=
 =?us-ascii?Q?KYz2Z0ROv2Bw5SCQel1hQBSY0qDf4GwaV509bdjSNSM24Kd8OETlhTQ/fY3y?=
 =?us-ascii?Q?oBwbxR9YeRGNpoAiGW0IuvFn7RoEgRO2TAvZnNaLuZxTpMtLpa0w/gqUHIBZ?=
 =?us-ascii?Q?TVsWO6YOWUac6jvyVegG1NbN6yJ100udfJvSDaUT/ClEo/tw9VhaMTJKHIig?=
 =?us-ascii?Q?7yvmaatZrOLwZ8MGYjOqbB5G8XfMVyJcghECLmSgVERii8zdqyv25GAGrjer?=
 =?us-ascii?Q?cd32TiV1B77OeaOae6hbWEkj7ak9jSjmoK9Axz+jsT2/jMYOKXWGOFBn4FIl?=
 =?us-ascii?Q?fj3xbAHsfXpPnaFKdtzyHlqToHKElNCT6a6sa1XTYTGwju+dgby+mnanhrGJ?=
 =?us-ascii?Q?Nw2NziHzeh9WIex63MQZ6oDze530vXjmUc7owPymzWk4UrVyLwqaAlyIF+rF?=
 =?us-ascii?Q?mwmOvbX/4aJZ+x/ZCA0j1UsUp61vvCR49IZi7staIJ4bVIwARogal1zg2UJc?=
 =?us-ascii?Q?srXcxvcL4xDpanEzPADkDN8x43rVeNaVTH0ON5+jiZQNfG7qa4d8XiZkZPjm?=
 =?us-ascii?Q?kGM5Nuegyu+5tZtoLKvP7X/noBVopXVtfcrpjuWvI5cMfjNw0d0+VuiMtMEv?=
 =?us-ascii?Q?aHnf6cXy1iA4jVhDjWnvzgM1TbIJziXR3pc+zDFfXbVSWo9AskCLGH8K6Yr8?=
 =?us-ascii?Q?yA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: LV8PR11MB8700.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6f436ce-8b22-4cd7-6df5-08dc47d9d92d
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2024 06:00:15.6496
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xUleY4OPn9bVQN7ozE0jRcQnkTLn6gHVqSq1MCsWhoZ9QJKZeHtYMi2hakYN/VXF87DU3Ie0yYuRwqh2u3xfLAiIb64OFSQ/xxV5+yof+YA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7532

Hello,

Sorry for inconvenience. Please ignore this mail only.=20
By mistake it was not out.

Thanks,
Raju
> -----Original Message-----
> From: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
> Sent: Tuesday, March 19, 2024 11:21 AM
> To: netdev@vger.kernel.org
> Cc: davem@davemloft.net; kuba@kernel.org; pabeni@redhat.com;
> edumazet@google.com; linux-kernel@vger.kernel.org; Bryan Whitehead -
> C21958 <Bryan.Whitehead@microchip.com>; UNGLinuxDriver
> <UNGLinuxDriver@microchip.com>
> Subject: [PATCH net V1 3/3] net: lan743x: Address problems with wake opti=
on
> flags configuration sequences
>=20
> WOL secure-on and magic packet configuration table:
> -------------------------------------------------------------------------=
-------
> | Ethtool Ops     | Send magic packet | Send magic packet | Send magic pa=
cket
> |
> |                 |                   | with password     | with wrong pa=
ssword|
> -------------------------------------------------------------------------=
-------
> |WAKE_MAGIC (g)   |      wake         |     wake          |        wake  =
      |
> -------------------------------------------------------------------------=
-------
> |WAKE_SECURE_MAGIC|    no wake        |     wake          |       no wake=
      |
> |     (s)         |                   |                   |              =
      |
> -------------------------------------------------------------------------=
-------
> | WAKE_MAGIC &    |                   |                   |              =
      |
> |WAKE_SECURE_MAGIC|      wake         |     wake          |        wake  =
      |
> |     (gs)        |                   |                   |              =
      |
> -------------------------------------------------------------------------=
-------
>=20
> Fixes: 6b3768ac8e2b3 ("net: lan743x: Add support to Secure-ON WOL")
> Signed-off-by: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
> ---
> Change List:
> ------------
> V0 -> V1:
>   - Fix the wake option flags configuration sequences
>=20
>  drivers/net/ethernet/microchip/lan743x_ethtool.c | 3 +--
>  drivers/net/ethernet/microchip/lan743x_main.c    | 8 +++++++-
>  2 files changed, 8 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/microchip/lan743x_ethtool.c
> b/drivers/net/ethernet/microchip/lan743x_ethtool.c
> index 4899582b3d1d..442c52aa0b0e 100644
> --- a/drivers/net/ethernet/microchip/lan743x_ethtool.c
> +++ b/drivers/net/ethernet/microchip/lan743x_ethtool.c
> @@ -1188,8 +1188,7 @@ static int lan743x_ethtool_set_wol(struct
> net_device *netdev,
>  		adapter->wolopts |=3D WAKE_PHY;
>  	if (wol->wolopts & WAKE_ARP)
>  		adapter->wolopts |=3D WAKE_ARP;
> -	if (wol->wolopts & WAKE_MAGICSECURE &&
> -	    wol->wolopts & WAKE_MAGIC) {
> +	if (wol->wolopts & WAKE_MAGICSECURE) {
>  		memcpy(adapter->sopass, wol->sopass, sizeof(wol->sopass));
>  		adapter->wolopts |=3D WAKE_MAGICSECURE;
>  	} else {
> diff --git a/drivers/net/ethernet/microchip/lan743x_main.c
> b/drivers/net/ethernet/microchip/lan743x_main.c
> index 5641b466d70d..43e8e35fe9d0 100644
> --- a/drivers/net/ethernet/microchip/lan743x_main.c
> +++ b/drivers/net/ethernet/microchip/lan743x_main.c
> @@ -3639,9 +3639,15 @@ static void lan743x_pm_set_wol(struct
> lan743x_adapter *adapter)
>  		lan743x_csr_write(adapter, MAC_MP_SO_LO, sopass);
>  		sopass =3D *(u16 *)&adapter->sopass[4];
>  		lan743x_csr_write(adapter, MAC_MP_SO_HI, sopass);
> -		wucsr |=3D MAC_MP_SO_EN_;
> +		wucsr |=3D MAC_MP_SO_EN_ | MAC_WUCSR_MPEN_;
> +		macrx |=3D MAC_RX_RXEN_;
> +		pmtctl |=3D PMT_CTL_WOL_EN_ |
> PMT_CTL_MAC_D3_RX_CLK_OVR_;
>  	}
>=20
> +	if (adapter->wolopts & WAKE_MAGICSECURE &&
> +	    adapter->wolopts & WAKE_MAGIC)
> +		wucsr &=3D ~MAC_MP_SO_EN_;
> +
>  	lan743x_csr_write(adapter, MAC_WUCSR, wucsr);
>  	lan743x_csr_write(adapter, PMT_CTL, pmtctl);
>  	lan743x_csr_write(adapter, MAC_RX, macrx);
> --
> 2.34.1