Received-SPF: pass (google.com: domain of linux-kernel+bounces-107132-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <beddae56-caef-4684-958b-d11ca0808055@gmail.com>
Date: Tue, 19 Mar 2024 08:01:06 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] dt-bindings: hwmon: adc128d818: convert to dtschema
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>,
 Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <20240318-adc128d818_dtschema-v1-1-d0af2caef145@gmail.com>
 <de0b32b3-348a-4d42-89cd-df2c439b8009@linaro.org>
Content-Language: en-US, de-AT
From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
In-Reply-To: <de0b32b3-348a-4d42-89cd-df2c439b8009@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 3/19/24 06:49, Krzysztof Kozlowski wrote:
> On 18/03/2024 21:12, Javier Carrasco wrote:
>> Convert adc128d818 bindings to dtschema to support validation.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> 
>> +$id: http://devicetree.org/schemas/hwmon/ti,adc128d818.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Texas Instruments ADC128D818 ADC System Monitor With Temperature Sensor
>> +
>> +maintainers:
>> +  - Javier Carrasco <javier.carrasco.cruz@gmail.com>
>> +
>> +description: |
>> +  The ADC128D818 is a 12-Bit, 8-Channel Analog to Digital Converter (ADC)
>> +  with a temperature sensor and an I2C interface.
>> +
>> +  Datasheets:
>> +    https://www.ti.com/product/ADC128D818
>> +
>> +properties:
>> +  compatible:
>> +    const: ti,adc128d818
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  ti,mode:
> 
> You need | to preserve the formatting.
> 

Thanks, I overlooked that. If I am not mistaken, 2 are still missing 
(ti,mode and vref-supply descriptions).

By the way, do you know why dtschema does not complain about that? If I 
place a '|' in a wrong place, it does complain, though.

> With this:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 

Best regards,
Javier Carrasco