Received-SPF: pass (google.com: domain of linux-kernel+bounces-107271-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 19 Mar 2024 09:55:37 +0100
From: Michal Hocko <mhocko@suse.com>
To: liuhailong@oppo.com
Cc: akpm@linux-foundation.org, nathan@kernel.org, ndesaulniers@google.com,
	trix@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	llvm@lists.linux.dev, surenb@google.com, zhaoyang.huang@unisoc.com,
	quic_charante@quicinc.com, yuzhao@google.com
Subject: Re: [PATCH v2] Revert "mm: skip CMA pages when they are not
 available"
Message-ID: <ZflTCY-Oaxm0U70u@tiehlicka>
References: <20240314141516.31747-1-liuhailong@oppo.com>
 <20240315081803.2223-1-liuhailong@oppo.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240315081803.2223-1-liuhailong@oppo.com>

On Fri 15-03-24 16:18:03, liuhailong@oppo.com wrote:
> From: "Hailong.Liu" <liuhailong@oppo.com>
> 
> This reverts
> commit b7108d66318a ("Multi-gen LRU: skip CMA pages when they are not eligible")
> commit 5da226dbfce3 ("mm: skip CMA pages when they are not available")
> 
> skip_cma may cause system not responding. if cma pages is large in lru_list
> and system is in lowmemory, many tasks would direct reclaim and waste
> cpu time to isolate_lru_pages and return.
> 
> Test this patch on android-5.15 8G device
> reproducer:
> - cma_declare_contiguous 3G pages
> - set /proc/sys/vm/swappiness 0 to enable direct_reclaim reclaim file
>   only.
> - run a memleak process in userspace

Does this represent a sane configuration? CMA memory is unusable for
kernel allocations and memleak process is also hard to reclaim due to
swap suppression. Isn't such a system doomed to struggle to reclaim any
memory? Btw. how does the same setup behave with the regular LRU
implementation? My guess would be that it would struggle as well.
-- 
Michal Hocko
SUSE Labs