Received-SPF: pass (google.com: domain of linux-kernel+bounces-107303-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <e7727b4e-c173-4edf-8d8e-a9dc00ba7653@intel.com>
Date: Tue, 19 Mar 2024 10:33:25 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RFC kspp-next 0/3] compiler_types: add
 Endianness-dependent __counted_by_{le,be}
Content-Language: en-US
To: Kees Cook <keescook@chromium.org>, Przemek Kitszel
	<przemyslaw.kitszel@intel.com>
CC: <linux-hardening@vger.kernel.org>, "Gustavo A. R. Silva"
	<gustavoars@kernel.org>, Marco Elver <elver@google.com>, Jakub Kicinski
	<kuba@kernel.org>, <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240318130354.2713265-1-aleksander.lobakin@intel.com>
 <202403181038.EC9DF8CE3C@keescook>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
In-Reply-To: <202403181038.EC9DF8CE3C@keescook>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjBlK00rRko2UEN4OFphdEN1bjlMS1RlYXVJWHJCZjRPSWxEU3E4SG9PWmhi?=
 =?utf-8?B?Y0dzRTMwVUtMVjBRSzZXUkhOR3pXZEZaMFo2QWxmTk91V2lXcDB1aGZ4cGp2?=
 =?utf-8?B?Z3Q2WWk3UFFjSGpsRVVpVURERWdOMDE3OXcrSFdKSFN0Tk83U2IxMTE3Rms0?=
 =?utf-8?B?eFI4Qk9RakRjdDJGUFdueWM5MjRiUVk5dFFmTFZ6Y29IMG1kQm1wamdHYUo2?=
 =?utf-8?B?dE1uTk4wMUVMQ1krSDFyZ3pUcEwxc1FCRjUraC9SL2xMWlBhNUVCekl4cUNB?=
 =?utf-8?B?SE5jb1NOdEdYZ29JZStvWTJwWVNwV2g5NGtiM1JGeExEZTZOVG5rSi9JRDV6?=
 =?utf-8?B?NlpaaE93QWU5RWlxRi9kWlk5Mi81SlVCYXBnakVqNXJaWnBXNzhsNzIxN1R0?=
 =?utf-8?B?aVBuT2xkeGpoYnZvL2RYNlo0TXpHQW54RkdvSHJvNWpCeEZ4eFdWZVN5RXFV?=
 =?utf-8?B?c1o3TytMSGdIVk9qZjR6cGpodTAzN1JoamczWlFlUWZmRDJ1MXpnZGxia2FJ?=
 =?utf-8?B?OUtqR2x6enc3YWcrRE5lY2RGVjZxb3EwZjkyY2RFcVpIc3ZFc2RIbXE2TFMx?=
 =?utf-8?B?T01ocENCd1A2b2w4WDI1ejN5RkhCbGNkdnFTQkpSVVNmdzhGcldsL0swT2Rn?=
 =?utf-8?B?YSs2eTE0cS80TUxwdlJEV1B4NHZhbGU4UkNvaHRKMkZvSnZqcm83Z092Zit3?=
 =?utf-8?B?OFRvbnBJVS9DOUI2RjREMHRwSFJYSk9qTkF2RjMybVRNRXpURm9leEkzNjRo?=
 =?utf-8?B?dHpZYUhiQUxIQU5NRE96b0YxNXJaN0l0NUt4bW5HdFdra0U4aDIyWTRkQzZI?=
 =?utf-8?B?NGNUL1U0NnVKN0pkQWtYRUdMMWpuU0k0UlpERUFMelFBc3lObTlFakdENVdu?=
 =?utf-8?B?NC8wRC8vUnZhWi9MNHdxSUJsenJUck9vaG9QMEFhemZEck9FSG9hQ1dPVGRh?=
 =?utf-8?B?NVJQclIrZFZ5N21UU0QxQW01RE1SVW15NlhlMUdFa0RVWU9VWW96anEyaGth?=
 =?utf-8?B?aU4wQU5Dc2UrTmtMRW1JV3RCZU95VVFHc3NQaWR3d3V4N1dWVUkrL3UwMFJX?=
 =?utf-8?B?NmIvbmUyYTA0QnlBM3RTeWZKYjFEUUNGWmxRUEtWSnpyejQ3R3c4WEY0eTB4?=
 =?utf-8?B?NXUwalY1TDl4OW9YemNsTHNzNWFPTjQreXFHVjNFYmx5am1GVHI3SmV1M0l6?=
 =?utf-8?B?dFJWczZvNGE0amZ4RzVhZ2hDZFFweHNhOE5lTFZMZ0lXTEZaTGNsR2VqNkZz?=
 =?utf-8?B?ejZZYVo4akMyZnZNM1QyRk4wTFdIa09xd09DY20wcDkweVc1dktETWM0OGtW?=
 =?utf-8?B?dTFzeUszS2V0RytvNXBVa2RRRndMODNDM1RKWW1jVEV4YW1DSWw3cXVIQnVn?=
 =?utf-8?B?YmZiWWVhR2o1YVJUZUM5eDFrMUFicFM2b0c5d0ZmUU11YkJsUWs5ZXFuanVU?=
 =?utf-8?B?Q1k1ZVVPbGUwRWpzUHRmTWt4WFQ0MzVvN1JRZm9tRGNPTDU3dXVWb3FaY21L?=
 =?utf-8?B?eDNwaWlhWjNtQzN3WGt2OHRjT2lXaUZWM1lRV2ZMdCtBSHIwMWgzZDNuMUFo?=
 =?utf-8?B?eWs0ajB5MzRBZEc1VWUxdU8zYlI3TUhnaHR5V01LK2tiVXVUZzZaUVVjWnBB?=
 =?utf-8?B?Tmp2SE0rN2UrNGcxTDBRMnc4bTh5bTVKOURZZ2tuV1RCZlYzZzRuc1czeEh5?=
 =?utf-8?B?UzJlS1I0MGN0NDYxRW10NUU0T3VqRXlVZ0JlblMvVGwzVWQyZDVKZVpmRnZM?=
 =?utf-8?B?b1cwUUQrYXlVTHFJSGtvMEtZcjBBV3pmcVh3OXpZNlFrU01ZQlo4Tk5NMjk3?=
 =?utf-8?B?a05Ydm4vUTMyZU9GdVlHell6VnNZb2I1eGFDT2hldjVrVTVoSlFDQkwxTzNJ?=
 =?utf-8?B?YU1xYktTdHJBbnpSS0ZDQ1FmZEpOZHVlR3dtUDFFVERaRzNENWVnYnE4dGNw?=
 =?utf-8?B?Y1lVQWlPTndYK0hVYUhjUCtJTm9mdDdDK1lWbGhTSDlvTnFKVS8zc25TdzZ4?=
 =?utf-8?B?NjB1UzA3dlpZdG90UjBaQU8zYmZ3OTVES3gvc3hiYkY0TS92VmN4bGxwSTNp?=
 =?utf-8?B?S1VFVEhaZnNEbnNjeVB6VXNHNXdiTTdlWWIyelNoWHo2ZEFiazU2UWtZTzBO?=
 =?utf-8?B?eE1kR0E2bnlsK1JoSGNQeFNLb2UzQmwvUEhSVURSclBxS1orODRRQVdSMEFu?=
 =?utf-8?B?OWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 223f2ca8-7f03-444e-db17-08dc47f7a304
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 09:33:29.9733
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wrsjINAe2FmShIYmXKFJVfUPuLpd4zA2jXVJVbp+5G1uT60hCoCz5xunROYwIUOtaOuVDs7LCPeU+eyBpxS+drVS0Ow8XWveJnJa5u7MFsc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6977
X-OriginatorOrg: intel.com

From: Kees Cook <keescook@chromium.org>
Date: Mon, 18 Mar 2024 10:49:25 -0700

> On Mon, Mar 18, 2024 at 02:03:51PM +0100, Alexander Lobakin wrote:
>>  include/linux/compiler_types.h              | 11 ++++++++++
>>  drivers/net/ethernet/intel/idpf/virtchnl2.h | 24 ++++++++++-----------
>>  2 files changed, 23 insertions(+), 12 deletions(-)
> 
> Oh, I see the Subject says "kspp-next" -- normally I'd expect things
> touch net to go through netdev. I'm fine with this going through either
> tree. Perhaps better through netdev since that subsystem has the most
> users and may gain more using the new macros?

Yeah sure. I send it with "kspp-next", so that it would be clear it's a
security feature :>

Thanks for the ack. Re expressions -- Przemek suggested it would be nice
to have something like

	__le32 counter;
	struct a flex[] __counted_by(le32_to_cpu(counter));

but we don't know whether something like this is possible to implement
in the compiler.

> 
> -Kees

Thanks,
Olek