Received-SPF: pass (google.com: domain of linux-kernel+bounces-107320-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\))
Subject: Re: [PATCH v2] perf evlist: Fix 'perf record -C xx' failed issue
From: Chunxin Zang <spring.cxz@gmail.com>
In-Reply-To: <20240319091429.2056555-1-spring.cxz@gmail.com>
Date: Tue, 19 Mar 2024 17:43:17 +0800
Cc: yangchen11@lixiang.com,
 Jerry Zhou <zhouchunhua@lixiang.com>,
 linux-perf-users@vger.kernel.org,
 linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <9B585813-A300-4793-AC65-8C69086508CE@gmail.com>
References: <20240319091429.2056555-1-spring.cxz@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>,
 mingo@redhat.com,
 acme@kernel.org,
 Namhyung Kim <namhyung@kernel.org>,
 mark.rutland@arm.com,
 alexander.shishkin@linux.intel.com,
 jolsa@kernel.org,
 irogers@google.com,
 adrian.hunter@intel.com

Sorry, I'm a little out of it, maybe because I didn't sleep at noon. =
This version is deprecated, v1 is correct.

v1: =
https://lore.kernel.org/linux-kernel/20240319084022.2036296-1-spring.cxz@g=
mail.com/T/#u

Best wishes
Chunxin


> On Mar 19, 2024, at 17:14, Chunxin Zang <spring.cxz@gmail.com> wrote:
>=20
> The cpu has 8 performance-cores and 8 efficient-cores on my pc.
> 0-15 are performance-cores
> 16-23 are 8 efficient-cores
>=20
> When I run "perf record -C xxx", the command fails if xxx all belong =
to
> performance cores or efficient cores
>=20
> The results are as follows
>=20
>  # perf record -C 12
>  WARNING: A requested CPU in '12' is not supported by PMU 'cpu_atom' =
(CPUs 16-23) for event 'cycles:P'
>  Error:
>  The sys_perf_event_open() syscall returned with 22 (Invalid argument) =
for event (cpu_atom/cycles:P/).
>  /bin/dmesg | grep -i perf may provide additional information.
>=20
>  # perf record -C 14-17
>  WARNING: A requested CPU in '14-17' is not supported by PMU =
'cpu_atom' (CPUs 16-23) for event 'cycles:P'
>  WARNING: A requested CPU in '14-17' is not supported by PMU =
'cpu_core' (CPUs 0-15) for event 'cycles:P'
>  ^C[ perf record: Woken up 1 times to write data ]
>=20
> The reason is that the cpu_map of 'cpu_atom'-evsel is empty, causing
> the sys_perf_event_open() result to fail.
>=20
> Changes in v2:
> - fix memory leak about 'intersect'
>=20
> Signed-off-by: Chunxin Zang <spring.cxz@gmail.com>
> Reviewed-by: Chen Yang <yangchen11@lixiang.com>
> ---
> tools/perf/util/evlist.c | 24 +++++++++++++++++-------
> 1 file changed, 17 insertions(+), 7 deletions(-)
>=20
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 55a300a0977b..babbde29341f 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -2499,7 +2499,7 @@ void evlist__check_mem_load_aux(struct evlist =
*evlist)
> void evlist__warn_user_requested_cpus(struct evlist *evlist, const =
char *cpu_list)
> {
> struct perf_cpu_map *user_requested_cpus;
> - struct evsel *pos;
> + struct evsel *pos, *tmp;
>=20
> if (!cpu_list)
> return;
> @@ -2508,18 +2508,28 @@ void evlist__warn_user_requested_cpus(struct =
evlist *evlist, const char *cpu_lis
> if (!user_requested_cpus)
> return;
>=20
> - evlist__for_each_entry(evlist, pos) {
> + evlist__for_each_entry_safe(evlist, tmp, pos) {
> struct perf_cpu_map *intersect, *to_test;
> const struct perf_pmu *pmu =3D evsel__find_pmu(pos);
>=20
> to_test =3D pmu && pmu->is_core ? pmu->cpus : cpu_map__online();
> intersect =3D perf_cpu_map__intersect(to_test, user_requested_cpus);
> - if (!perf_cpu_map__equal(intersect, user_requested_cpus)) {
> - char buf[128];
> + if (!intersect) {
> + evlist__remove(evlist, pos);
> + evsel__delete(pos);
> + perf_cpu_map__put(intersect);
> + continue;
> + }
> +
> + if (!perf_cpu_map__is_subset(user_requested_cpus, intersect)) {
> + char buf_test[128];
> + char buf_intersect[128];
>=20
> - cpu_map__snprint(to_test, buf, sizeof(buf));
> - pr_warning("WARNING: A requested CPU in '%s' is not supported by PMU =
'%s' (CPUs %s) for event '%s'\n",
> - cpu_list, pmu ? pmu->name : "cpu", buf, evsel__name(pos));
> + cpu_map__snprint(to_test, buf_test, sizeof(buf_test));
> + cpu_map__snprint(intersect, buf_intersect, sizeof(buf_intersect));
> + pr_warning("WARNING: A requested CPU '%s' in '%s' is not supported =
by "
> +   "PMU '%s' (CPUs %s) for event '%s'\n", buf_intersect, cpu_list,
> +   pmu ? pmu->name : "cpu", buf_test, evsel__name(pos));
> }
> perf_cpu_map__put(intersect);
> }
> --=20
> 2.34.1
>=20