Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp756623lqt; Tue, 19 Mar 2024 02:56:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCULpopFiq1Kjttyq0nxfFpIESMc4hsm891AND/GgxY4sU4HiZkkNwSRMIT/bYzYJFy5YWlMRARljlLq9ySDvYk0R6TZQLf/i8V6NSC3sw== X-Google-Smtp-Source: AGHT+IHvuk0LR/3HnvjkTDCEeHO0WUxNmM7+qZleVKR7FxLNpNlJPftulZPpaTy5ulaVSQ81yiJd X-Received: by 2002:a05:622a:5785:b0:430:c07d:632b with SMTP id eh5-20020a05622a578500b00430c07d632bmr10852745qtb.21.1710842179955; Tue, 19 Mar 2024 02:56:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710842179; cv=pass; d=google.com; s=arc-20160816; b=rX6emc+KdWLqzSOJM5btxOEFs4Bo4hfDmWZ3ksavbZcl+tu9uSVVFqEAiJMCZLKXPv KnGM15cHQzYfe+5AJ5S7Wh7Tp2O1I+pUra44ZgoDVSId2RPd4BfP2V2/vbK9CfHdycYd /+Bje/OJU7EU1u1GvOQ2WVgqeKmofsnYMsf7hcaAsC8ZKfNlvHKkdSQM50nfQFZJQVbU pRYsSOjMTVaspzC0XAjm3eVL+nAnHkx/Ndkpow81WWWsnDjXhCGd6hAPoN6Dc5PuZw0l fsWvj3QAZLs8muLxyTZsk99ui7pfSqiLsQmk7kal7gZZ6ynjiIsB8by7A9qQSJJLTkHj N17Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=5q3zd5E/6R1QVeji5djwTwQZyfcCs8b1Manxa1AHPpQ=; fh=/4zNEedhPJIVch8Igj0cRhVshwu3u2xv8BKnMyMmgFc=; b=nhceCtfWK8PUMW6p8U+VoPDbAJAtSctREj7Oc0rY6OcHIxxs0UMVvZ47nF5NdukHJf +QBiYElgiWCYa1nZc82d2IQ9K3wv0/B29BiFtWcLPK9M52oC33vVEIJCafwRkj6tGfOS jCNWxGWrv7mcFLhHodeDznNBC0DC3jp7LOTv4IogHdzQ7Caz3g3+bozH+0n/285SOmM9 SkqjHZTEuFIz9d113kODj/HsRU9alJv5wHO0cGfuFvpUd6b9+P+nVuMAB7nS63+TSHrb KHtIEAlSdW8i1GgAJ+MPdJQ0deg2gMtFME9TMR/orD1WWuPkH218xIqsFhK6Dz9/WRjK zJnA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f8O5Oava; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-107342-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-107342-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id s10-20020a05622a178a00b0042f172748f4si6253446qtk.565.2024.03.19.02.56.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 02:56:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-107342-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f8O5Oava; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-107342-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-107342-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id AB8A31C21C38 for ; Tue, 19 Mar 2024 09:56:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4864B7D40B; Tue, 19 Mar 2024 09:53:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="f8O5Oava" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7160D7FBB1; Tue, 19 Mar 2024 09:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710842026; cv=none; b=T+FqTZ9enPxlvphMAYYTOZB4sQOjxrg+SV37/Dxrux2ID07i5knYz8Oj9/B4asSll/AeQY+xrbkjgEsEcwHU672TAxI1y7XI4cGYJ/UmPK/Sl8W1A4GaHhk7wD9hTcLd6O1TQkY3d5m7ZJXoSMXDqi17vS9lc4SgiQvipOn8x1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710842026; c=relaxed/simple; bh=wKzRdXC2CGMBk+yjNkNCtzVfVM9PNiFuCla4o//SuBU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jxnAi6NyXk2IGTzQ1Wwno+so8+nx/y4dzXjW1c48mwp6oDBZYH0qyikUPCILri/Jz2IlFhvVf2xHyGrHnsHSQmIbVaCVhP7RNQaY95r7pf9FQMxQmguFlPz0QV8UrApOBYoO8VQq/moydrPbdp1c8yOZOjpF6SC3qcT3A85ctOo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=f8O5Oava; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C0FCC433C7; Tue, 19 Mar 2024 09:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710842025; bh=wKzRdXC2CGMBk+yjNkNCtzVfVM9PNiFuCla4o//SuBU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f8O5OavaKbe48Cwfe30+zoZzglhaJ1CyFuUEnxzTjmjaRkhWtYtchg12yT4duUx2q dcbW3jsB/aEZiAiSjHy++0PPpJvyIHAi8iNH7BtLFjEoo+2UBRKU0WbOavTOS0c5FB Vx4lbiLziNGTEnd07/fSzTq+uKTLy4dJvOoFqlICe1Nspmpu00rT4mwI/KB3+Djx+9 sdPP/hCW/KGiqhtsPmdEYF6mnwADCgCUIoQjZLatHU+F/tLCz1ugB2fCgFXcxKRCcf nnOX2NBiVqn5jylkAmpzLRM9aksnXmuRnhAeam3Up5ofLSgvxhPmbety5ERwolMb8E 3kBCdCQua2Plg== From: "Jiri Slaby (SUSE)" To: linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [RFT 09/15] tty: 8250_dma: use dmaengine_prep_slave_sg() Date: Tue, 19 Mar 2024 10:53:09 +0100 Message-ID: <20240319095315.27624-11-jirislaby@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240319095315.27624-1-jirislaby@kernel.org> References: <20240319095315.27624-1-jirislaby@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is a preparatory for the serial-to-kfifo switch. kfifo understands only scatter-gatter approach, so switch to that. No functional change intended, it's just dmaengine_prep_slave_single() inline expanded. Signed-off-by: Jiri Slaby (SUSE) --- drivers/tty/serial/8250/8250_dma.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/8250/8250_dma.c b/drivers/tty/serial/8250/8250_dma.c index 8b30ca8fdd3f..8b2c3f478b17 100644 --- a/drivers/tty/serial/8250/8250_dma.c +++ b/drivers/tty/serial/8250/8250_dma.c @@ -89,6 +89,7 @@ int serial8250_tx_dma(struct uart_8250_port *p) struct circ_buf *xmit = &p->port.state->xmit; struct dma_async_tx_descriptor *desc; struct uart_port *up = &p->port; + struct scatterlist sg; int ret; if (dma->tx_running) { @@ -111,10 +112,13 @@ int serial8250_tx_dma(struct uart_8250_port *p) serial8250_do_prepare_tx_dma(p); - desc = dmaengine_prep_slave_single(dma->txchan, - dma->tx_addr + xmit->tail, - dma->tx_size, DMA_MEM_TO_DEV, - DMA_PREP_INTERRUPT | DMA_CTRL_ACK); + sg_init_table(&sg, 1); + sg_dma_address(&sg) = dma->tx_addr + xmit->tail; + sg_dma_len(&sg) = dma->tx_size; + + desc = dmaengine_prep_slave_sg(dma->txchan, &sg, 1, + DMA_MEM_TO_DEV, + DMA_PREP_INTERRUPT | DMA_CTRL_ACK); if (!desc) { ret = -EBUSY; goto err; -- 2.44.0