Received-SPF: pass (google.com: domain of linux-kernel+bounces-107357-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 19 Mar 2024 15:27:43 +0530
From: "Gautham R. Shenoy" <gautham.shenoy@amd.com>
To: Perry Yuan <perry.yuan@amd.com>
Cc: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com,
	viresh.kumar@linaro.org, Borislav.Petkov@amd.com, Ray.Huang@amd.com,
	Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
	oleksandr@natalenko.name, Xiaojian.Du@amd.com, Li.Meng@amd.com,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 5/8] cpufreq: amd-pstate: Bail out if
 min/max/nominal_freq is 0
Message-ID: <ZflhlzoGmWCkZjnn@BLR-5CG11610CF.amd.com>
References: <cover.1710836407.git.perry.yuan@amd.com>
 <884cab991815707eb10b720e6f72978cbb5e54f6.1710836407.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <884cab991815707eb10b720e6f72978cbb5e54f6.1710836407.git.perry.yuan@amd.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?sc1VtjpRmo/cQ9LEL1smkLoV7bnCIDh8KN0VjRMTDswPGyUtnBPj+tSMBce0?=
 =?us-ascii?Q?nTDU4bEc1r3HC0uPfdf0kfRWLKaa1GjF6sBG/BqBW8FZylHJvrIGotp0TKZL?=
 =?us-ascii?Q?7NWbpAVEFMwUXAGlv/cep0iBLTBD6GfLUMWhxQDN736CBVHMU64jDuaVd7TA?=
 =?us-ascii?Q?XE2u4QwZhCpjdWmcFL5r+mWVCcqggwYsCplfwkIe3Jr+1w5WP+cC7d7+xv+r?=
 =?us-ascii?Q?YRzfzMu5fk1JEo8HC8VJoHTYMkwg0aA1wAwCnzXji9Pw3VsO6K9gN15iNSYi?=
 =?us-ascii?Q?PMYiLIPf0h1k8/60TnbKu3fc6JuRlOPS7/wYJLxyalTzjW7k9FCgZhi+svCj?=
 =?us-ascii?Q?RKhGmeN1tFiTC3BrPyl5rG3aWHwfMJxhfnTPV/1f/9WcIopm0gwZgvHiChz+?=
 =?us-ascii?Q?kpUPTFEzUCS6IQYUsZY/HfeuRBObeSXbFjGwGpfWVpgRXdgtIGobovTl6qPp?=
 =?us-ascii?Q?F+gz31+oRNUw5oHdTzoJNSpm1uqqlgpYm8jhfyxb2f4DG0JB7mL9oYTvWnLa?=
 =?us-ascii?Q?EAzlQglmO83GIDpQSpjHVeEn3Mcqrw9KS2eLKeDlYjh2V1WeilggwXWCGMU3?=
 =?us-ascii?Q?xGP5t5EozeAzI3XJDTwLyY7eQmmgwTg2feSxpfA+CNOechZUElaVfT3Mudxg?=
 =?us-ascii?Q?QYdaWpUnfqHGVJtAV6Aoj8+aw1+vNJOqO+Hrf9u3r5XrJK/W+yDg5vuyTwTP?=
 =?us-ascii?Q?DumXZ+I+TxO8QSKAOFSQjTHTWbPDWoPc6nFppLBuxCPIlkYkyVAlmdcJRpP2?=
 =?us-ascii?Q?K1lRn7tx4WYSl9GnX88dg9OBXgD+toXeJ4J1nJDtFs/UbESz/TZPSBLE9w+5?=
 =?us-ascii?Q?rYcMLREffnmes9RUp0lNtTSs+Vcn79QWrTT/WzBPNReKtKEf3RPEdMuPhYR1?=
 =?us-ascii?Q?vPYlUOR653Z30Jgrb2CUmat+yuamoxQZRtRktrNqKndLUn+c/gOcaBxEgbWa?=
 =?us-ascii?Q?/DyNabQ//1Vfy0+NdbgEz1NlBn20Xkgr5KVu9Lc124g6SVw5+IbWO27eh11d?=
 =?us-ascii?Q?g89EJUftXYVrAsEEMDvEnTnJMH5KdlXYhlC1VjJfdkVCQrUjf1Yal0/Qp3DQ?=
 =?us-ascii?Q?lFlCr/x1wcnBILchQlNEEEcA+vIRRfkY703J29NgZCXnq+42MrvP7cdNliCU?=
 =?us-ascii?Q?7mXFVUEXiLmXLSSiVoXOZhpe/ntHeY2NDzmdE5qMEjadVkaqqIDbh2RLHD81?=
 =?us-ascii?Q?whjwV3mccrA5rfjshOksmy8rpZQMlwVskcT8Q9SKJeaDcjrmeIT21z50LGmg?=
 =?us-ascii?Q?cegq/OX7PONmwQ7mFLoYl2eSnYV8tUJF18zNK11bjWjwTVhHWQfeJkumNHPM?=
 =?us-ascii?Q?ABb4BAkDsG7DXJ/8+jj9nrIAPhwOa0SRFsPVRQ2MEfuAWZ8LXaOmJ6qq//qU?=
 =?us-ascii?Q?x8Mxi/E3XGDs0mBq/vKUve9jt1xI/j0UOYJplDWyV1FbilRVHydHHtT8E9YL?=
 =?us-ascii?Q?l4N2ETr9UbREIvlPT0pHT3Lz5cpWafstJMS9lp8tJhceGxrzYfLYOTS/KNp2?=
 =?us-ascii?Q?jFZZrgOMj/L/yLgBUVbyUja1L+XNgWpo0fbQC++FMFuIrw4N1v9KP7W4ja42?=
 =?us-ascii?Q?DHmG2bbaI8CLc6D7iUCyPDP6rv7P7shoee7e4iFF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54be2efc-76fc-4b72-30aa-08dc47fb0a16
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB8252.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 09:57:51.4840
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uj78nqUgEJo8P6Lhp8CcO1vxXynHqdhOaP1Dsq8D/3icpRHb7baU0RNQNdsJItblleL5elyeJ+/jz6EaH7yvGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB9011

Hello Perry,

On Tue, Mar 19, 2024 at 04:28:40PM +0800, Perry Yuan wrote:
> The amd-pstate driver cannot work when the min_freq, nominal_freq or
> the max_freq is zero. When this happens it is prudent to error out
> early on rather than waiting failing at the time of the governor
> initialization.
>

This patch looks good to me.

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 16 ++++++++++------
>  1 file changed, 10 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 132330b4942f..6708c436e1a2 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -839,9 +839,11 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>  	nominal_freq = READ_ONCE(cpudata->nominal_freq);
>  	lowest_nonlinear_freq = READ_ONCE(cpudata->lowest_nonlinear_freq);
>  
> -	if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) {
> -		dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n",
> -			min_freq, max_freq);
> +	if (min_freq <= 0 || max_freq <= 0 ||
> +	    nominal_freq <= 0 || min_freq > max_freq) {
> +		dev_err(dev,
> +			"min_freq(%d) or max_freq(%d) or nominal_freq (%d) value is incorrect\n",
> +			min_freq, max_freq, nominal_freq);
>  		ret = -EINVAL;
>  		goto free_cpudata1;
>  	}
> @@ -1299,9 +1301,11 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>  	max_freq = READ_ONCE(cpudata->max_freq);
>  	nominal_freq = READ_ONCE(cpudata->nominal_freq);
>  	lowest_nonlinear_freq = READ_ONCE(cpudata->lowest_nonlinear_freq);
> -	if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) {
> -		dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n",
> -				min_freq, max_freq);
> +	if (min_freq <= 0 || max_freq <= 0 ||
> +	    nominal_freq <= 0 || min_freq > max_freq) {
> +		dev_err(dev,
> +			"min_freq(%d) or max_freq(%d) or nominal_freq(%d) value is incorrect\n",
> +			min_freq, max_freq, nominal_freq);
>  		ret = -EINVAL;
>  		goto free_cpudata1;
>  	}
> -- 
> 2.34.1
>

--
Thanks and Regards
gautham.