Received-SPF: pass (google.com: domain of linux-kernel+bounces-107362-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Nas Chung <nas.chung@chipsnmedia.com>
To: Ivan Bornyakov <brnkv.i1@gmail.com>
CC: Philipp Zabel <p.zabel@pengutronix.de>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
	<conor+dt@kernel.org>, "linux-media@vger.kernel.org"
	<linux-media@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, jackson.lee <jackson.lee@chipsnmedia.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: RE: [PATCH 1/6] media: chips-media: wave5: support decoding higher
 bit-depth profiles
Thread-Topic: [PATCH 1/6] media: chips-media: wave5: support decoding higher
 bit-depth profiles
Thread-Index: AQHaeUKavgcckUHy2EygGbh2NtXhZrE+1aEA
Date: Tue, 19 Mar 2024 10:09:32 +0000
Message-ID:
 <SL2P216MB1246E9790DF5FE273D555768FB2C2@SL2P216MB1246.KORP216.PROD.OUTLOOK.COM>
References: <20240318144225.30835-1-brnkv.i1@gmail.com>
 <20240318144225.30835-2-brnkv.i1@gmail.com>
In-Reply-To: <20240318144225.30835-2-brnkv.i1@gmail.com>
Accept-Language: ko-KR, en-US
Content-Language: ko-KR
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?5K/bNWo5En52ygQlmCHn6CuRqCV0VxDLZ1JomXlqFlA/ZhPYlM+6m9epwlSU?=
 =?us-ascii?Q?rBNwXoe7G9zU0ac6jqtnBLIVsQaQb67/Cc8QWDv/sM7782/ZkRds7Oz0O5zR?=
 =?us-ascii?Q?l54TkSigqCeJ/uRjw93F6XndvtB0tCbbeGfs1uCP/ZwjmvcZjVv04DXlvHu7?=
 =?us-ascii?Q?Rkf24P9IkGu1WbVedVRNOvSLmSwJDlYduyyXtvqo5Nvn9PUPKAZrn42JwF+l?=
 =?us-ascii?Q?vJO5YMUh8mnWFwgGnVI5YSxl7p+89DZaOu6jvpGaBu3IoFDFinZNJZPveQYw?=
 =?us-ascii?Q?dIL5W73V8qy6gPmjO9/UkRBn8DJofzmvqT/5S+ahew7tnRqzhQS6InW4Z9QE?=
 =?us-ascii?Q?649w09I+WOi9d0FI23EWBXuLpQ+DJXoI8NOPKAasnW2XPcOh4UDjhHli14t3?=
 =?us-ascii?Q?N/UYBgl/GvV3BRgPKIQ08DQv4ZkZJsER6MizAvkD0gCuFNihhME1n2haTzTX?=
 =?us-ascii?Q?TpCcLtfA92H0aHFuBXry1ISn6mIBEmrxqIlzu4/WytkvsNR+qcBY19L9xw9k?=
 =?us-ascii?Q?dVF0JJuqvpVVH09rH3pBAAcd90JtxCGh011RIfwkTkrOnaUo3yC8wszdWCIF?=
 =?us-ascii?Q?+/bnv8ni0i63Znb/Jm9FfbuK1HAo5hKg0qc9w8FNVuzFh5FI16owU7BGWPn3?=
 =?us-ascii?Q?NLA91JM0S/uq9wN3AC6uVbyTCofj566pIQXy6kXKrz2vNdRJHafa6BN6W7PB?=
 =?us-ascii?Q?3X5MOyP+eAvRIsgytPsr573gfVN3mZXnqvl0SKFFNeRDRT/3g35WHpp2J3Av?=
 =?us-ascii?Q?5hXgOG8hpoBpyWvvrgRkuFbCc/6tzSc8xBRqNrPl+STY7TqdJ/lLOwlw/SCM?=
 =?us-ascii?Q?/JcIdy9tWk0AvoIor/mNuuoL6J2PlhSQyyVl+Z53XFngLG0GpDtldkFhv5iz?=
 =?us-ascii?Q?Vb7HV6HXO+GzaDlXhfz81jHxgJ5rvNTz0agyTjNHGRBQVQyZ1H/PbFc6nPje?=
 =?us-ascii?Q?NK+JXL/xvOuwhqERnjcFvNBR+6dOB19UYmz8O1VNPeahGy1xtradA+kG0zeX?=
 =?us-ascii?Q?8MBu6tUDzFblr7vFy0h/AfxOAIg2dxyk/MXM39yOrycj4mTsNMP2WSCPE/5z?=
 =?us-ascii?Q?KMhbRivuuVoTXiMXtBQ/waB2fXrz525tNr8rj2WnmH7BIPFmwiq8FVvkr8zX?=
 =?us-ascii?Q?o8PYapBG50hk+Y5lF2rF37Yiw0AN9WGH6FGDx0FmgQ78n7WcZgsg3zWx5jQP?=
 =?us-ascii?Q?4VzPKr7EC1z0tblXJfUdIka3clOoMuJiLCvBJ/WzrMeSU8852xnOfJd0Ca6c?=
 =?us-ascii?Q?3ZSHAcWG84k3Mb0szsLrMNPe5E/d7/aQ+zOI+eBmAGx8fvaQK0ROrwy9tsF6?=
 =?us-ascii?Q?tmNwcxBNBJCluM1PzwsaB9bqc4bTO+k8H6//faijoZGCr4D9HQo1go06b/hW?=
 =?us-ascii?Q?KDgUsjUenkWOgUsZm9Z+YJ+rp7YqHOwg/FZCVawGM022yzmMptcLmjFhp00c?=
 =?us-ascii?Q?cOTZej6X+8Qub6hxGM1iao8Ts2gctF3PUdmTIPaOcxSuVes6pKLiYDjB4xJ3?=
 =?us-ascii?Q?GFqdqVmZ1IwSA2TTVyyyzNEb5NNanc6oXsFs51AiIxDOuAl1pi6WK6Dc61Vd?=
 =?us-ascii?Q?bnq49dlq4ZDUMiAPoBPFEiVb6w4Sl3OLU2i9nIRk?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: chipsnmedia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SL2P216MB1246.KORP216.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 2226b28c-4b46-4c10-a2d6-08dc47fcabff
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Mar 2024 10:09:32.2617
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4d70c8e9-142b-4389-b7f2-fa8a3c68c467
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uwJQOwQuS/e/ssXcbd0Xg2fNLAHdhuGgxnG26K3cd3xmGXVegTlHs+pBbMnVgcWzEhd5ZpzZ7+RorAZBcrfZ+lzsD6x39CY3a65P0Yg5MgY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SE1P216MB1272

Hi, Ivan.

>-----Original Message-----
>From: Ivan Bornyakov <brnkv.i1@gmail.com>
>Sent: Monday, March 18, 2024 11:42 PM
>To: Nas Chung <nas.chung@chipsnmedia.com>; jackson.lee
><jackson.lee@chipsnmedia.com>; Mauro Carvalho Chehab <mchehab@kernel.org>
>Cc: Ivan Bornyakov <brnkv.i1@gmail.com>; Philipp Zabel
><p.zabel@pengutronix.de>; Rob Herring <robh@kernel.org>; Krzysztof
>Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
><conor+dt@kernel.org>; linux-media@vger.kernel.org; linux-
>kernel@vger.kernel.org; devicetree@vger.kernel.org
>Subject: [PATCH 1/6] media: chips-media: wave5: support decoding higher
>bit-depth profiles
>
>Add support for decoding higher than 8 bit-depth profiles by scaling FBC
>buffer stride and size by the factor of (bitdepth / 8).
>
>Signed-off-by: Ivan Bornyakov <brnkv.i1@gmail.com>
>---
> .../platform/chips-media/wave5/wave5-vpu-dec.c    | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
>diff --git a/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c
>b/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c
>index ef227af72348..aa0401f35d32 100644
>--- a/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c
>+++ b/drivers/media/platform/chips-media/wave5/wave5-vpu-dec.c
>@@ -1055,6 +1055,7 @@ static int wave5_prepare_fb(struct vpu_instance
>*inst)
> 	int ret, i;
> 	struct v4l2_m2m_buffer *buf, *n;
> 	struct v4l2_m2m_ctx *m2m_ctx =3D inst->v4l2_fh.m2m_ctx;
>+	u32 bitdepth =3D inst->codec_info-
>>dec_info.initial_info.luma_bitdepth;
>
> 	linear_num =3D v4l2_m2m_num_dst_bufs_ready(m2m_ctx);
> 	non_linear_num =3D inst->fbc_buf_count;
>@@ -1063,7 +1064,7 @@ static int wave5_prepare_fb(struct vpu_instance
>*inst)
> 		struct frame_buffer *frame =3D &inst->frame_buf[i];
> 		struct vpu_buf *vframe =3D &inst->frame_vbuf[i];
>
>-		fb_stride =3D inst->dst_fmt.width;
>+		fb_stride =3D ALIGN(inst->dst_fmt.width * bitdepth / 8, 32);
> 		fb_height =3D ALIGN(inst->dst_fmt.height, 32);
> 		luma_size =3D fb_stride * fb_height;
>
>@@ -1408,22 +1409,10 @@ static int wave5_vpu_dec_start_streaming(struct
>vb2_queue *q, unsigned int count
> 		if (ret)
> 			goto free_bitstream_vbuf;
> 	} else if (q->type =3D=3D V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
>-		struct dec_initial_info *initial_info =3D
>-			&inst->codec_info->dec_info.initial_info;
>-
> 		if (inst->state =3D=3D VPU_INST_STATE_STOP)
> 			ret =3D switch_state(inst, VPU_INST_STATE_INIT_SEQ);
> 		if (ret)
> 			goto return_buffers;
>-
>-		if (inst->state =3D=3D VPU_INST_STATE_INIT_SEQ) {
>-			if (initial_info->luma_bitdepth !=3D 8) {
>-				dev_info(inst->dev->dev, "%s: no support for %d
>bit depth",
>-					 __func__, initial_info->luma_bitdepth);
>-				ret =3D -EINVAL;
>-				goto return_buffers;
>-			}
>-		}
> 	}
>

TI wave521C version cannot support 10bit decoding.
So, We need above error checking codes.
How about adding support_10bit flag in wave5_match_data like below ?
static const struct wave5_match_data ti_wave521c_data =3D {
	.support_10bit =3D false;
};

> 	return ret;
>--
>2.44.0