Received: by 2002:ab2:620c:0:b0:1ef:ffd0:ce49 with SMTP id o12csp800498lqt; Tue, 19 Mar 2024 04:30:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVy0OD9XVFlakYCjZrnUSmIUTN/MgogfwT0NYmjxeUXx8crmp93d3GbZirOYdt4TTCkvGevmIK05/u9xWQGqQexLx2DXzOmV7H+hnpGjg== X-Google-Smtp-Source: AGHT+IHMpUTaDPdnn0YMYFutyQdRVAXdIBNS0zP1ZHpI86shMpSjEPSYOt3miA4ekJ2xAmgSe6Xy X-Received: by 2002:a05:6808:1485:b0:3c3:832d:d449 with SMTP id e5-20020a056808148500b003c3832dd449mr3037267oiw.51.1710847838916; Tue, 19 Mar 2024 04:30:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710847838; cv=pass; d=google.com; s=arc-20160816; b=ELRdaYvMc8t4UWtXgBc9j09+W6gj+9jgVVEt6FWo181RfyR/cr23TW/VHQELISqF9R Gxt5OCcuZvLhvWfNyCO8nqMGGXz/BNLzIBtUDwmePhvvPHH2beEpXbCS+w119FrQmG8S dhxwjjjt+Clw/ZUjkYwoTSxZQQ7okrKNyDbUxdKIt/GQVJsIKwk/BtiIZuCJZOuylTXY 5zGfMgN5xuLXI364bUniwD3ifns6yfuz8g/jKG/N6M7wJkAWl1FR5e1QFwjisrJ0l56w o/8F+AIxdV3rFX8Dkhpwvll9k73BRPaUsvt6d4Vx3hGtz7M2yZb6Uc0q5G+DjNTaCSic MgsA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:date:message-id:from:subject :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=W5HQK1ycqivqMTGRH5cZ+NdOxbFcKHk841qx0mEglms=; fh=YSA6zqfgo1qF+VibebzJGa5ooYl1Sg/ksvnuI22Th4Y=; b=WyuLjtHDhk7qTYoHnXplvkBG08Zki5FB0v31SqeDaJAvZibnzYBWzoEqvfQ7JjW0AV WtGnCfhBGj5CLJdLXN4LqoWIrIFOIdys9AjbhYYQmt5y8FWX7ij0ShutxoEInZ4IBOgS C7txUvTVnEvxR/7TPsoMbb0tV1KoMbUa5Xh7544lG/3Cqo/0b4MHba5CEKR1N+/8PO2n Wv/nsQMjp/tdU6wyqKuwTC9VO8JrgWHlIBdHIGsNan1QInZ9SzMCN51Jf8mE0FZg4pj+ kIT4+o0cQHZl45NekYEpErHzmJk7t13+DDKaANJKRz2JigAGoX3gubO8VSyJNDco7pgj 3hSw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EnFN57yh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-107459-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-107459-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id m8-20020a05622a118800b00430d644738fsi3421941qtk.796.2024.03.19.04.30.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 04:30:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-107459-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EnFN57yh; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-107459-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-107459-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 83E7B1C226AF for ; Tue, 19 Mar 2024 11:30:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 32A627EF1F; Tue, 19 Mar 2024 11:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EnFN57yh" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55BC17BAFB; Tue, 19 Mar 2024 11:30:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710847828; cv=none; b=pYefHA5ld9oN3y/Yh401KvORFv/R+fKNyiFqSNRGNvrbvr4xME83pp1qtNlVW91PkT9nFYRPCxwiWGwyUniGywoKNukIgz8Ai9VYiH59PTpoOBNOgijBFu7zqMhFG9K0UwU6WETW8SN55PCoYMA9tgf3GhcfTAHfLIPVU8hdTNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710847828; c=relaxed/simple; bh=dnqTXQz32jKrSI6GbKSQRO/rglIIbJZjU6uIXfVIv24=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=tGbSoeOvgQkZF8saShZaHIeL/cdyVu1bTu52BgLDQhdIGjgaH3n0qmQ/ZvkXzY8hEPbN3oTuventPSRdjG+9yR8GO8J/ItZXENdqCPZw4IjPGIt9VkGXAIJuDG9uj+dE3gL/8UCsNrJ5+d9OkXPxnFq3l3OBuOeQqdTm3LlrGSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EnFN57yh; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id DA443C433C7; Tue, 19 Mar 2024 11:30:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710847827; bh=dnqTXQz32jKrSI6GbKSQRO/rglIIbJZjU6uIXfVIv24=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=EnFN57yh7tts4vSMWeMyQaIuUk2IdRewsVKIed1jARE7ms6p+gTfC3sCwnHciq2Aj Y0MUqZ0U3awUDn5MPEiLPFff/rVnFnDnAtlNDBvL9U6UxNf7vQ3E37cI2LtX8fnv7i wGcY2v/rRbMp9kDLTq8m0AprJAD8BhuXhR0TUJ3prf+0a9ujJR55ktGnZz1f5/5UVw MZNV7TV4q0JIS8BoNO3tA1uTIhmSfejvDVIjsg+/eAu6K7Tnhn28L1LjapV/xFGp4y RLMQ8a+8rDUl+F6gBRlP20i048uAaQj0t5UzThxe5LoQwJ0x+kQ/Uz3gaT9BEGGIfK +vXI4crY71u9g== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id C653DD982E0; Tue, 19 Mar 2024 11:30:27 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v2] rds: introduce acquire/release ordering in acquire/release_in_xmit() From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171084782780.9693.3451064874189878588.git-patchwork-notify@kernel.org> Date: Tue, 19 Mar 2024 11:30:27 +0000 References: In-Reply-To: To: Yewon Choi Cc: allison.henderson@oracle.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org, threeearcat@gmail.com Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Fri, 15 Mar 2024 18:28:38 +0900 you wrote: > acquire/release_in_xmit() work as bit lock in rds_send_xmit(), so they > are expected to ensure acquire/release memory ordering semantics. > However, test_and_set_bit/clear_bit() don't imply such semantics, on > top of this, following smp_mb__after_atomic() does not guarantee release > ordering (memory barrier actually should be placed before clear_bit()). > > Instead, we use clear_bit_unlock/test_and_set_bit_lock() here. > > [...] Here is the summary with links: - [net,v2] rds: introduce acquire/release ordering in acquire/release_in_xmit() https://git.kernel.org/netdev/net/c/1422f28826d2 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html