Received-SPF: pass (google.com: domain of linux-kernel+bounces-107477-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 19 Mar 2024 12:40:17 +0100
From: Alejandro Colomar <alx@kernel.org>
To: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= <mic@digikod.net>
Cc: =?utf-8?Q?G=C3=BCnther?= Noack <gnoack@google.com>,
	Paul Moore <paul@paul-moore.com>,
	"Serge E . Hallyn" <serge@hallyn.com>,
	Konstantin Meskhidze <konstantin.meskhidze@huawei.com>,
	Shervin Oloumi <enlightened@chromium.org>,
	linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v2 1/2] landlock: Extend documentation for kernel support
Message-ID: <Zfl5oT1amymvxjjL@debian>
References: <20240227110550.3702236-1-mic@digikod.net>
 <Zd4OlL1G3t1D3TgC@google.com>
 <20240307.oxQuab5tho0u@digikod.net>
 <ZfgOf2dHBVT4WUcp@debian>
 <20240319.eeb8tajeiPee@digikod.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="lVXM4NhaC2HReP5T"
Content-Disposition: inline
In-Reply-To: <20240319.eeb8tajeiPee@digikod.net>


--lVXM4NhaC2HReP5T
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 19 Mar 2024 12:40:17 +0100
From: Alejandro Colomar <alx@kernel.org>
To: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= <mic@digikod.net>
Cc: =?utf-8?Q?G=C3=BCnther?= Noack <gnoack@google.com>,
	Paul Moore <paul@paul-moore.com>,
	"Serge E . Hallyn" <serge@hallyn.com>,
	Konstantin Meskhidze <konstantin.meskhidze@huawei.com>,
	Shervin Oloumi <enlightened@chromium.org>,
	linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v2 1/2] landlock: Extend documentation for kernel support

Hi Micka=C3=ABl!

On Tue, Mar 19, 2024 at 11:46:34AM +0100, Micka=C3=ABl Sala=C3=BCn wrote:
> On Mon, Mar 18, 2024 at 10:50:42AM +0100, Alejandro Colomar wrote:
> > Hi Micka=C3=ABl, G=C3=BCnther,
> >=20
> > Sorry for the delay!
> >=20
> > On Thu, Mar 07, 2024 at 11:21:57AM +0100, Micka=C3=ABl Sala=C3=BCn wrot=
e:
> > > CCing Alejandro
> > >=20
> > > On Tue, Feb 27, 2024 at 05:32:20PM +0100, G=C3=BCnther Noack wrote:
> > > > On Tue, Feb 27, 2024 at 12:05:49PM +0100, Micka=C3=ABl Sala=C3=BCn =
wrote:
> > > > > Extend the kernel support section with one subsection for build t=
ime
> > > > > configuration and another for boot time configuration.
> > > > >=20
> > > > > Extend the boot time subsection with a concrete example.
> > > > >=20
> > > > > Update the journalctl command to include the boot option.
> > > > >=20
> > > > > Cc: G=C3=BCnther Noack <gnoack@google.com>
> > > > > Cc: Kees Cook <keescook@chromium.org>
> > > > > Signed-off-by: Micka=C3=ABl Sala=C3=BCn <mic@digikod.net>
> > > > > ---
> > > > >=20
> > > > > Changes since v1:
> > > > > * New patch, suggested by Kees Cook.
> > > > > ---
> > > > >  Documentation/userspace-api/landlock.rst | 57 ++++++++++++++++++=
+++---
> > > > >  1 file changed, 51 insertions(+), 6 deletions(-)
> >=20
> > [...]
> >=20
> > > > > +
> > > > > +  lsm=3Dlandlock,lockdown,yama,integrity,apparmor
> > > > > +
> > > > > +After a reboot, we can check that Landlock is up and running by =
looking at
> > > > > +kernel logs:
> > > > > +
> > > > > +.. code-block:: console
> > > > > +
> > > > > +    # dmesg | grep landlock || journalctl -kb -g landlock
> > > > > +    [    0.000000] Command line: [...] lsm=3Dlandlock,lockdown,y=
ama,integrity,apparmor
> > > > > +    [    0.000000] Kernel command line: [...] lsm=3Dlandlock,loc=
kdown,yama,integrity,apparmor
> > > > > +    [    0.000000] LSM: initializing lsm=3Dlockdown,capability,l=
andlock,yama,integrity,apparmor
> > > > > +    [    0.000000] landlock: Up and running.
> > > > > +
> > > > > +Note that according to the built time kernel configuration,
> > > >=20
> > > > s/built time/build time/
> > > >                  ^
> > >=20
> > > OK
> >=20
> > Here, this should actually be "build-time" since it works as an
> > adjective.
>=20
> Thanks Alex but this was already merged:
> https://git.kernel.org/torvalds/c/35e886e88c803920644c9d3abb45a9ecb7f1e761
>=20
> Because I picked G=C3=BCnther's below suggestion, it should be good right?

Yeah, it's a minor grammar mistake that is widespread elsewhere.  If you
want to patch it, go ahead, if you want to keep it until next time you
revise this text, it's not something that will significantly hurt the
understanding of the text.

See also: <https://www.grammar-monster.com/lessons/hyphens_in_compound_adje=
ctives.htm>

Have a lovely day!
Alex

>=20
> >=20
> > >=20
> > > >=20
> > > > It feels like the phrase "according to" could be slightly more spec=
ific here.
> > > >=20
> > > > To paraphrase Alejandro Colomar, "Note that" is usually redundant.
> > > > https://lore.kernel.org/all/0aafcdd6-4ac7-8501-c607-9a24a98597d7@gm=
ail.com/
> > > >=20
> > > > I'd suggest:
> > > >=20
> > > >   The kernel may be configured at build time to always load the ``l=
ockdown`` and
> > > >   ``capability`` LSMs.  In that case, these LSMs will appear at the=
 beginning of
> > > >   the ``LSM: initializing`` log line as well, even if they are not =
configured in
> > > >   the boot loader.
> >=20
> > LGTM
> >=20
> > >=20
> > > OK, I integrated your suggestion.  I guess `capability` is not really
> > > considered an LSM but it would be too confusing and out of scope for =
an
> > > user documentation to explain that.
> > >=20
> > > >=20
> > > > > +``lockdown,capability,`` may always stay at the beginning of the=
 ``LSM:
> > > > > +initializing lsm=3D`` list even if they are not configured with =
the bootloader,
> > > >=20
> > > > Nit: The man pages spell this in two words as "boot loader".
> > >=20
> > > OK, I'll use "boot loader" too.
> > >=20
> > > >=20
> > > >=20
> > > > > +which is OK.
> > > > > +
> > > > > +Network support
> > > > > +---------------
> > > > > +
> > > > >  To be able to explicitly allow TCP operations (e.g., adding a ne=
twork rule with
> > > > >  ``LANDLOCK_ACCESS_NET_BIND_TCP``), the kernel must support TCP
> > > > >  (``CONFIG_INET=3Dy``).  Otherwise, sys_landlock_add_rule() retur=
ns an
> > > > >=20
> > > > > base-commit: b4007fd27206c478a4b76e299bddf4a71787f520
> > > > > --=20
> > > > > 2.44.0
> > > > >=20
> > > >=20
> > > > Reviewed-by: G=C3=BCnther Noack <gnoack@google.com>
> > >=20
> > > Thanks!
> >=20
> > Reviewed-by: Alejandro Colomar <alx@kernel.org>
> >=20
> > Have a lovely day!
> > Alex
> >=20
> > --=20
> > <https://www.alejandro-colomar.es/>
> > Looking for a remote C programming job at the moment.
>=20
>=20

--=20
<https://www.alejandro-colomar.es/>
Looking for a remote C programming job at the moment.

--lVXM4NhaC2HReP5T
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmX5eaEACgkQnowa+77/
2zLeYxAAnJTAbKLQYz/5DxQmedRvL+W3k/fnLGakyKe+gmMvXAFsrAPRdPJqx+B/
IrnjIXRGN9heqRpBuuq8BTxAFfnlapd5zatjGNMxD3f2VhlFjsH5WYj0fDj59+9d
w8unSYIMyd/pvhxiSl9NvIzu/O7zWPFmDJ+mY+tLVzHkaQmZ/SO2X6U2DRW2d6F2
25iJujYtmp6hQtANfVzJY7Qmufbp7GB4s83KuKd/IXqExlzLS7sG0H9mxHi0Ii3w
2OOGZ7lVTk8yCCqAxlr9gNwgbbeHZ55DKPwUobBllhQr4tvbrbE09QXm6WgLK+Hk
Tgsdw/MsviWRuWUztcSJjnqiEkAwSREB5EZXP/+QQqWCrbiTsdfJoVYvdz4uIUvg
78/eE6vIW/iSliJe9MnXv8nCH3vJ3QsENV6S3HgeXAx6dlvy2r3gMul5VklSfztR
4BWP3Usx42rOs33ielFDVPncJFYbFjIaNGvaraa6gWlott6YoYzaLetGK0pnUs78
gTD1ZECDe2UuQGcoiEEH47U7Hg9uLYnAEfahXpE60kf555p4exQWoXs1r2pMmEzm
ylWrd2TfmWV15CVCNpR1bK4AgAIiOel5FU+nYjAq9GoBeqThqjbwZlGhGWXY/Nlp
cnJAH59ziEI8YPqdKq3BRglpzWldmGwCLQXvR1hQuyc1Dq6I6Bc=
=5omu
-----END PGP SIGNATURE-----

--lVXM4NhaC2HReP5T--