Received-SPF: pass (google.com: domain of linux-kernel+bounces-107486-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 19 Mar 2024 12:54:57 +0100
From: Robert Richter <rrichter@amd.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Alison Schofield <alison.schofield@intel.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-cxl@vger.kernel.org, Derick Marks <derick.w.marks@intel.com>,
	Len Brown <lenb@kernel.org>
Subject: [PATCH] cxl: Fix use of phys_to_target_node() outside of init section
Message-ID: <Zfl9Efxe7DwuU_i3@rric.localdomain>
References: <20240318210904.2188120-1-rrichter@amd.com>
 <20240318210904.2188120-2-rrichter@amd.com>
 <65f8b191c0422_aa222941b@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <65f8b191c0422_aa222941b@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?QICQKAySqibtC6UTqgPaaebHtjoJWz9KKUwSEzNnQ9mnotr9Y+3h7PtlhSzG?=
 =?us-ascii?Q?mIhck9wTqQ4rZqqfOmCGb7Fi0gTaqmf1v3U54aS27Yeyxgv7l3pBFOKxbSJW?=
 =?us-ascii?Q?nRQ3c7oFgBonKSf/oSc57W6Xs4jpcEaTgJJguNEKzJTb9nsbnTzcBegMKkjf?=
 =?us-ascii?Q?H55GwnFeHUJ/kf06c3zlCykyjaO1wNA6sjOr/fWBl2HbMPjyfDxepPUez22m?=
 =?us-ascii?Q?YphPKZqS/2LC/5OchI4uyzvd+wZ08K10lXtVxPjBWMAg7gMbxKFdaif2fBjQ?=
 =?us-ascii?Q?YG4c7yTL/PEM9xOzrDAATIczuP0ki/1HbaOU0hYb5tC90vqw3h64gy4vsH+H?=
 =?us-ascii?Q?C3scJz+cpwNzmQIQ1wGhg2QPP6lD1Y5ak0tRewGTiHJVnIkYo2Yt54d3Z2V9?=
 =?us-ascii?Q?YTkE6Lw6Uj7Bf5Xn974WyJFOb7e2yVb54wd6ScBdawVUN7sAL6ShazXdy85e?=
 =?us-ascii?Q?8RXkqGLpJBvLlJkyYuwKa4Qq/jpn8NoL5S+LKMh4GjiSfb+ba7fEoTXoBc69?=
 =?us-ascii?Q?fUUW3PzalCCj9Tw8u8Ql3+h9y+S6tbs/3hgi7VmKnwqNyN4r1kjAC7b5R2lO?=
 =?us-ascii?Q?aYDpU/p0Hhs+zHqenAFzrceh1MTI3TM249EbVbVOQhnRWmJBthbl4xf9Id2t?=
 =?us-ascii?Q?wovSaHbOL1OJ0V6SRd8P2haQhfe8O/4mePBwleyaBraRa8Ap8AmsYDKpi2zO?=
 =?us-ascii?Q?LO8m/5PDnGSaETpXZG5USrptze2whS56d+fA6UA6lGqwPEI6iR4qVjntBbu/?=
 =?us-ascii?Q?N51gCVOmZRIBzEvE4cV2TBEVsXGEKQvmm68NzC1HIaM0QlYFo0liUmndRWvN?=
 =?us-ascii?Q?XbCH0k2Q6GRrpj4n3XljlqUY+BV3+z/pPLtgHT+1Hm/sgCreabb6xWEpog+L?=
 =?us-ascii?Q?jydogFLZkGtFLJ4NWq0BA1VRvJaXLmNKU3bmiBh2oQo4x5jkNsm77QnAN88U?=
 =?us-ascii?Q?OPTO4vhFxaVO06xaN9WAYKXJa/oIk/E/IpfiWefryxX8jnsBIPmep4UFVg2i?=
 =?us-ascii?Q?ZNXaobeRggjCuKKWWxa+LLFGV4ev6yV1JPPAzvtabcCVM1gjt5hxfnSTidbb?=
 =?us-ascii?Q?JXDX3SIwjBJ9y2nWb6y3ECHszXJQWV7h80LtNB93oNa+s4fJNPLhcKwaJJAl?=
 =?us-ascii?Q?0xAsf4l92eBm7+Vy5WmBYHeOKGAok+FGdEkfyXm4NeNX11LvxxM32+kp4wrF?=
 =?us-ascii?Q?LpAowfK9sdptbiRMFFFgnZKkWiVKTlUxSG/J0/U9rVCyraiQuDWNkxbioLP/?=
 =?us-ascii?Q?lE8VXz9PAzZj510+KA8hT3TqA1Vc/Tr8GdNweuIBFNw4hAA9N2HD60SFNFUH?=
 =?us-ascii?Q?D70C5/1v2BFbvWeo1LmdSLXULjOspXjY/4LO87IUa6RWTGAJurnH+8yPwwNA?=
 =?us-ascii?Q?jQRk61jED0FlPTgXl2lNBMHvaXZq8fvRbeEe43qQ7/8k6DlG4lx0FkDW9VMi?=
 =?us-ascii?Q?Y8v3TeJDwtQrJmD4A40OYfRAqVxWUdI4Yz2McKzsghRK1PVyn1d3i1tk4Yr4?=
 =?us-ascii?Q?T1aLXEmhO0EI0DAD1tWjwjLRNxC6tC4GsB4MkEee5PAbDJX1pok00KBLrC4I?=
 =?us-ascii?Q?8RM05tR14MHPf2EpEM8=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0277663b-b900-43b7-64f8-08dc480b6989
X-MS-Exchange-CrossTenant-AuthSource: CYYPR12MB8750.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 11:55:03.3898
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IIy8SU6lrpNzG7Bohlp+85ybXqj6UGGR7ksTbMyqszNL1AqpReGUKqVx5PBvNQQzUBY2lSlkjBFK4K3I3NLidg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6852

Hi Dan,

patch below. I have not included it into v2 of the SRAT/CEDT changes
as it is cxl specific and can be applied separately.

Thanks,

-Robert


On 18.03.24 14:26:41, Dan Williams wrote:
> It should also be the case that cxl_acpi needs this:
> 
> diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
> index 67998dbd1d46..1bf25185c35b 100644
> --- a/drivers/cxl/Kconfig
> +++ b/drivers/cxl/Kconfig
> @@ -6,6 +6,7 @@ menuconfig CXL_BUS
>         select FW_UPLOAD
>         select PCI_DOE
>         select FIRMWARE_TABLE
> +       select NUMA_KEEP_MEMINFO if NUMA
>         help
>           CXL is a bus that is electrically compatible with PCI Express, but
>           layers three protocols on that signalling (CXL.io, CXL.cache, and

From be5b495980bae41d879909212db02dac0fba978e Mon Sep 17 00:00:00 2001
From: Robert Richter <rrichter@amd.com>
Date: Tue, 19 Mar 2024 09:28:33 +0100
Subject: [PATCH] cxl: Fix use of phys_to_target_node() outside of init section

The CXL driver uses both functions phys_to_target_node() and
memory_add_physaddr_to_nid(). The x86 architecture relies on the
NUMA_KEEP_MEMINFO kernel option to be set. Enable the option for the
driver accordingly.

Suggested-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Robert Richter <rrichter@amd.com>
---
 drivers/cxl/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
index 67998dbd1d46..6140b3529a29 100644
--- a/drivers/cxl/Kconfig
+++ b/drivers/cxl/Kconfig
@@ -6,6 +6,7 @@ menuconfig CXL_BUS
 	select FW_UPLOAD
 	select PCI_DOE
 	select FIRMWARE_TABLE
+	select NUMA_KEEP_MEMINFO if (NUMA && X86)
 	help
 	  CXL is a bus that is electrically compatible with PCI Express, but
 	  layers three protocols on that signalling (CXL.io, CXL.cache, and
-- 
2.39.2