Received-SPF: pass (google.com: domain of linux-kernel+bounces-107527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 19 Mar 2024 13:40:56 +0100
From: Francesco Dolcini <francesco@dolcini.it>
To: Nishanth Menon <nm@ti.com>
Cc: Francesco Dolcini <francesco@dolcini.it>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	=?iso-8859-1?Q?Jo=E3o_Paulo_Silva_Gon=E7alves?= <joao.goncalves@toradex.com>
Subject: Re: [PATCH v1] arm64: dts: ti: verdin-am62: use SD1 CD as GPIO
Message-ID: <20240319124056.GA13970@francesco-nb>
References: <20240312144956.40211-1-francesco@dolcini.it>
 <20240319120717.e2p65ricusxuz3wm@subatomic>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240319120717.e2p65ricusxuz3wm@subatomic>

Hello Nishanth,

On Tue, Mar 19, 2024 at 07:07:17AM -0500, Nishanth Menon wrote:
> On 15:49-20240312, Francesco Dolcini wrote:
> > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> > 
> > TI SDHCI IP has a hardware debounce timer of 1 second as described in
> > commit 7ca0f166f5b2 ("mmc: sdhci_am654: Add workaround for card detect
> > debounce timer"), because of this the boot time increases of up to 1
> > second.
> > 
> > Workaround the issue the same way that is done on
> > arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts, using the SD1 CD as
> > GPIO.
> > 
> > Suggested-by: Nishanth Menon <nm@ti.com>
> > Reported-by: Jo?o Paulo Silva Gon?alves <joao.goncalves@toradex.com>
> > Closes: https://lore.kernel.org/all/0e81af80de3d55e72f79af83fa5db87f5c9938f8.camel@toradex.com/
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > ---
> >  arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi | 12 ++++++++++--
> >  1 file changed, 10 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> > index e8d8857ad51f..a9bf2c17f95a 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-verdin.dtsi
> > @@ -1441,8 +1447,10 @@ &sdhci0 {
> >  /* Verdin SD_1 */
> >  &sdhci1 {
> >  	pinctrl-names = "default";
> > -	pinctrl-0 = <&pinctrl_sdhci1>;
> > +	pinctrl-0 = <&pinctrl_sdhci1>, <&pinctrl_sd1_cd_gpio>;
> > +	cd-gpios = <&main_gpio1 48 GPIO_ACTIVE_LOW>;
> >  	disable-wp;
> > +	ti,fails-without-test-cd;
> >  	vmmc-supply = <&reg_sdhc1_vmmc>;
> >  	vqmmc-supply = <&reg_sdhc1_vqmmc>;
> >  	status = "disabled";
> 
> Minor style comment based on recently added https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-properties-in-device-node
> 
> ti,fails-without-test-cd comes after vqmmc-supply and above status.

Whoops, you are right, of course, thanks. I'll send a v2 once the merge
window closes and rc1 is out.

Francesco