Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757514AbYAIBdN (ORCPT ); Tue, 8 Jan 2008 20:33:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754136AbYAIBcw (ORCPT ); Tue, 8 Jan 2008 20:32:52 -0500 Received: from hs-out-0708.google.com ([64.233.178.251]:40825 "EHLO hs-out-2122.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754003AbYAIBct (ORCPT ); Tue, 8 Jan 2008 20:32:49 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=AD/JuocH3E4kbbPF5w0reWv+p6Rx0oy6qmHZVPJzP1AffqUFBCgFe5rd7iNZrirZVJw599Zx7dx1XmyMo0BTnlrGRLwxYIvTrUXmBUGziydiQ19P3ZoYump4mRnFz/BhPOXWakdtl3Bu9tvaM3yO6EDqlwxrqBpkZpqglA9YVI4= Message-ID: Date: Wed, 9 Jan 2008 09:32:48 +0800 From: "Dave Young" To: "Greg KH" Subject: Re: [PATCH 0/7] convert semaphore to mutex in struct class Cc: "Stefan Richter" , James.Bottomley@hansenpartnership.com, dbrownell@users.sourceforge.net, linux-scsi@vger.kernel.org, a.zummo@towertech.it, peterz@infradead.org, cbou@mail.ru, linux-kernel@vger.kernel.org, "David Brownell" , krh@redhat.com, stern@rowland.harvard.edu, rtc-linux@googlegroups.com, spi-devel-general@lists.sourceforge.net, linux1394-devel@lists.sourceforge.net, dwmw2@infradead.org, davem@davemloft.net, jarkao2@gmail.com In-Reply-To: <20080108224837.GA19623@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080103055019.GA4885@darkstar.te-china.tietoenator.com> <20080107020944.GA3637@darkstar.te-china.tietoenator.com> <20080107084528.GA8365@suse.de> <200801070101.15168.david-b@pacbell.net> <478227D5.8050402@s5r6.in-berlin.de> <20080107154404.GA10880@suse.de> <47825DC1.3090102@s5r6.in-berlin.de> <20080107172009.GA25943@suse.de> <20080108224837.GA19623@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1869 Lines: 42 On Jan 9, 2008 6:48 AM, Greg KH wrote: > On Tue, Jan 08, 2008 at 03:05:10PM +0800, Dave Young wrote: > > On Jan 8, 2008 1:20 AM, Greg KH wrote: > > > On Mon, Jan 07, 2008 at 06:13:37PM +0100, Stefan Richter wrote: > > > > It's already in the driver core to the most part. It remains to be seen > > > > what is less complicated in the end: Transparent mutex-protected list > > > > accesses provided by driver core (requires the iterator), or all the > > > > necessary locking done by the drivers themselves (requires some more > > > > lock-taking but perhaps fewer lock instances overall in the drivers, and > > > > respective redefinitions and documentation of the driver core API). > > > > > > I favor changing the driver core api and doing this kind of thing there. > > > It keeps the drivers simpler and should hopefully make their lives > > > easier. > > > > What about this? > > > > #define class_for_each_dev(pos, head, member) \ > > for (mutex_lock(&(container_of(head, struct class, devices))->mutex), po > > s = list_entry((head)->next, typeof(*pos), member); \ > > prefetch(pos->member.next), &pos->member != (head) ? 1 : (mutex_unlock(& > > (container_of(head, struct class, devices))->mutex), 0); \ > > pos = list_entry(pos->member.next, typeof(*pos), member)) > I'm wrong, it's same as before indeed. > Eeek, just make the thing a function please, where you pass the iterator > function in, like the driver core has (driver_for_each_device) Ok, so need a new member of knode_class, I will update the patch later. Thanks. > > thanks, > > greg k-h > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/