Received-SPF: pass (google.com: domain of linux-kernel+bounces-107599-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 19 Mar 2024 10:38:44 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Ankit Agrawal <ankita@nvidia.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	"maz@kernel.org" <maz@kernel.org>,
	"oliver.upton@linux.dev" <oliver.upton@linux.dev>,
	"will@kernel.org" <will@kernel.org>,
	Aniket Agashe <aniketa@nvidia.com>, Neo Jia <cjia@nvidia.com>,
	Kirti Wankhede <kwankhede@nvidia.com>,
	"Tarun Gupta (SW-GPU)" <targupta@nvidia.com>,
	Vikram Sethi <vsethi@nvidia.com>, Andy Currid <acurrid@nvidia.com>,
	Alistair Popple <apopple@nvidia.com>,
	John Hubbard <jhubbard@nvidia.com>, Dan Williams <danw@nvidia.com>,
	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>,
	"kvmarm@lists.linux.dev" <kvmarm@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] KVM: arm64: determine memory type from VMA
Message-ID: <20240319133844.GA159172@nvidia.com>
References: <ZR7hKYU1Wj+VTqpO@arm.com>
 <20231005165458.GM682044@nvidia.com>
 <ZSVe0nb02S4kz5D2@arm.com>
 <20231010150502.GM3952@nvidia.com>
 <ZSWHkvhutlnvVLUZ@arm.com>
 <20231010182328.GS3952@nvidia.com>
 <ZSbfUNLwDkaYL4ts@arm.com>
 <20231011183839.GC3952@nvidia.com>
 <ZSgb0WBSsXHHYJT0@arm.com>
 <SA1PR12MB7199AB860E0C76B80B421C66B0252@SA1PR12MB7199.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <SA1PR12MB7199AB860E0C76B80B421C66B0252@SA1PR12MB7199.namprd12.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WlNXMnRtRkVwYTI1b3AzT3p6VEJSWHFRdTRqQ3cwTlFlL0FKSi8zTFg5aGM4?=
 =?utf-8?B?aGRlWXEraTduQ2NLT1I4Z1pqRTg4Y1M3clZSNGJQNkNIbzhFeTdTQXd4Nkkz?=
 =?utf-8?B?MEcva1NJbi93V1g3b1hIY3dBVFdkVHpiV0NHU2N5UHJ1YlVFNEF1ZFZHUlhV?=
 =?utf-8?B?M3YrYk1nV3M1OGVlSDdsdW1Kc1AzL1NYREdTdkJIak1PTlo5ejY4MHNtakFi?=
 =?utf-8?B?QUhSbVd0M3ZJR3BGMVBJVG5pa1JDMkVFK1VZeTRZTDdwZ2xlaGdIUG9RT3Zn?=
 =?utf-8?B?RDdIUjVKMkNtL0lZaHZYaHA3ZEJDdTBsV0hIOStwd2pIb0M5bzdxaEZuNkFZ?=
 =?utf-8?B?REFJWDlWWDIyTXZaaWpaRS9LQUx5MVAydEFZTGdYcmpsK2REY0NRTjJmajEy?=
 =?utf-8?B?ckVYVVhISWZQRmhlM0QzUlMyaitLeStUSjZBeTllMmswZDVLOW8xbzY5ZHJD?=
 =?utf-8?B?Y1NHbHFOejFEaUdLSzJyWHU4YlRhUjZsalA4WnAvWTJJL2lsN2dSb0pLc0Er?=
 =?utf-8?B?UllpY3ZlZ0tkUzEycDBsVEZXUGFVb3oxcUx4aGYydHYzdFpuRFBXS1ZjdExS?=
 =?utf-8?B?bFpxSlBtSUhYeEJTdVBIWWNtdFlybS8vRXl2VkZCTVNDRVlvcXRCMzhPVFNH?=
 =?utf-8?B?N0JORW5nQkNzbkN2K3FyQjVxT0M0am1JQ2JVaCtXZHBjSkE0enF1YllSaExp?=
 =?utf-8?B?TjBwOVNsN2gyMmZDdEZjL1FKQWZDd09WbGJTRlA2RlptOFpxaHRpSGZkOFFz?=
 =?utf-8?B?bjB1c1c0elppN1BSd1F6cHJIVzNkemlxOVdYcm1mMndEUG15S1E0QmFhWFc2?=
 =?utf-8?B?djlNNHdlTXBGUjhMbTFtRVIySmt2aENWamVIRGV6bTdQQnVRM2dlUmdSaHBP?=
 =?utf-8?B?VE05NHNzNXc1UDVHcEU0WDdlY2Z6NVRyWGxTSnhHR3VkL2ZpYStTSW54alI3?=
 =?utf-8?B?YUcwWlF2ZWk3UzR1UE9tSlhkL3RGa2xqOFB6SjNlTis2NDhheXU2cnNhWWMy?=
 =?utf-8?B?ZWh5bUNIYVhQajl0SXpjMitWRkRKbUw1aWpsQXVTTFBoUjErRHZmZ1BuLzJP?=
 =?utf-8?B?eDc3UytSUDlycGxmVncwVEhIZHRtK0ZiOTg5VmY2aEdCSFA5Y0UvakVocnpj?=
 =?utf-8?B?aXZtNnhOczJXVjJBcFJlUGJGYmRrU3BRbzk5dDNjd3hzblRwZFlCVE0zUG90?=
 =?utf-8?B?aGdDWHU0RFYxd0VNZUNUdHNnYmcrQm1VNUJZRDM3bjBRdXRodlhxVUdTVFQ2?=
 =?utf-8?B?SCs1Y1hVR05GaFlzZjlLMXNCUnpwVi91UURJQXphRUQ2NVp0SVIrMVVPbjdL?=
 =?utf-8?B?bitwUDdGVDVuU09RQXhqQnE2cG5OcjltYnh4VXJMTTRoMkIzZzl1eGQzTEpk?=
 =?utf-8?B?Tzg4T3hid2dPRmRBVmI0b1BNTlhCWklPTjVqOVJuckxrcmh3b3BiT0xESWtx?=
 =?utf-8?B?MUxjQ0VIR3ltTGxSUTJrajVxNjZTRWNSNW5uVTRwVkcyZnViNENJSnZmbVlS?=
 =?utf-8?B?YWl6eXNXZTlKTE9pWGJTeHFvSENVOGhVQmlBZVJLd0dxbjZER1N0anJ2VnZo?=
 =?utf-8?B?UDhnbFZuS3liSmR6RzgyZjZqTWpGQStjM1lvUThWV0NpWU0yUm5xbVJLZ2Na?=
 =?utf-8?B?Qko2NHlxMXp1NEFFVFhtNGhiaWZoOUhQWllrdC9MeThWalFZV1dsd3pMcFFJ?=
 =?utf-8?B?Sy80aTdQRkd4c2NpTXVSMkdmTlY3SjJUTVZvWisyVE15bGlwVXlzc1p5V25w?=
 =?utf-8?B?SGFma0c1NS90ZVBRNllJV1RYWHhUQm84L2NlTWgwMlkvcVZGZmdRUXd1SDNU?=
 =?utf-8?B?eXdvQzZmRFpOWXF0WHlsOG05Tlo4QjlsQXlucGJEWHlEYWRvTVY5cWpHR3ZB?=
 =?utf-8?B?akZJUEV4cURPRFVyRmxzcU5JNFUwQlVBS0dVMXdMMXV1d1EvNlBpQkw0RUNT?=
 =?utf-8?B?ajhLWjhtaVFQUHUxYWpSbjgyV2NIZm5ZTSt3YWd3ZjRlbm9vcmlrdnRiVkFp?=
 =?utf-8?B?SjFXZ054T0c0R3dTRG8vSitBOWhITEUxOXRWaUZ1ZWxHQWdOeFBxV1g2amQ5?=
 =?utf-8?B?TFU0YVVwb1MxckJVd0Z1RXpVdkdmL0VoQ3IyYTJHME9jRTNJOEJkMUs3UFFy?=
 =?utf-8?Q?wAIfEYScl14fmN/s2NI0PhQWP?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cba0a24a-ff33-430d-6724-08dc4819e6be
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2024 13:38:46.4066
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GRznsRzWrcgQyd+MPWEqIRIfkUOc6IG0trIkihqZa3jrcWG3uW9Ivr+ZDpIFkMDf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5734

On Sun, Mar 10, 2024 at 03:49:36AM +0000, Ankit Agrawal wrote:
> Bringing this to the fore.
> 
> >> Where does that leave us for this patch? We check the VM_MTE_ALLOWED
> >> and check for ZONE_MOVABLE struct pages as one of the conditions for
> >> NORMAL?
> >
> > I think we should keep it as simple as possible and, looking at it
> > again, maybe even ignore vm_page_prot. Two questions though:
> >
> > 1. Does VM_IO imply vm_page_prot never having MT_NORMAL or
> >    MT_NORMAL_TAGGED?

Drivers do crazy things, so I would not be surprised if something in
the tree does this (wrong) thing. We can check the pgprot in the vma
as well as the VM_IO to make the decision.

> > 2. Do all I/O ranges (side-effects, non-RAM) mapped into a guest (and
> >   which end up in user_mem_abort()) imply VM_IO?

Yes, this is definately true for VFIO.

Jason